Mailing-List: contact commons-httpclient-dev-help@jakarta.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: "Commons HttpClient Project"
 <commons-httpclient-dev@jakarta.apache.org>
Message-ID: <3F696B1F.2010708@nose.ch>
Date: Thu, 18 Sep 2003 10:21:51 +0200
From: =?ISO-8859-1?Q?Ortwin_Gl=FCck?= <ortwin.glueck@nose.ch>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.4) Gecko/20030612
MIME-Version: 1.0
To: Commons HttpClient Project <commons-httpclient-dev@jakarta.apache.org>
Subject: Re: [PATCH] Reworked digest auth
References: <3F6062B2.7080600@nose.ch>
	 <1063446510.2923.12.camel@kczrh-okt22.corp.bearingpoint.com>
	 <3F68179A.50403@nose.ch>
 <1063828994.2143.38.camel@kczrh-okt22.corp.bearingpoint.com>
In-Reply-To: <1063828994.2143.38.camel@kczrh-okt22.corp.bearingpoint.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Oleg Kalnichevski wrote:

> Odi, the patch looks fine to me. I just dislike this part:
> 
>         try {
>             cnonce = createCnonce();   
>         } catch(AuthenticationException e) {
>             throw new RuntimeException(e.toString());   
>         }
> 
> 
> At the very least I would rethrow the exception as
> MalformedChallengeException, or, preferably, change createCnonce to
> throw MalformedChallengeException instead of AuthenticationException in
> the very first place.

Agreed. It's not nice.

The original exception that is generated is because MD5 is not 
available. I think this should generally trigger an unchecked exception 
since it is a basic feature needed for HttpClient to work (and should 
never happen anyway). I think createCnonce should just throw a 
RuntimeException instead of AuthenticationException. The 
AuthenticationException is sematically wrong here anyway.

> As to the stateful authentication framework, it sounds like a reasonable
> improvement, but I suggest that we hold it off until the comprehensive
> API redesign that should follow the 2.1 release. Feel free to file a bug
> report meanwhile. 

Okay.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org