hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 15435] - New Preferences Architecture
Date Fri, 19 Sep 2003 12:18:57 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15435>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15435

New Preferences Architecture





------- Additional Comments From rolweber@de.ibm.com  2003-09-19 12:18 -------
Hello Oleg,

> Any of parameters relevant on the HttpMethod level should also be settable on 
> HttpClient level when applicable of a number of methods, IMO.

So you want to use the same params object for the client and methods, or use
the client params object as default for the methods object. Sounds good to me.
Keep the hierarchy as it is.

> Addition of HttpClient#HttpClient(HttpClientParams) sounds reasonable. We
> might need to make DefaultHttpParams cloneable, [...]

Right, no-one should use the same params object for multiple clients or methods
and expect setters to be invoked without side effects. That should be made
clear in the JavaDocs for the constructors that accept params objects.

It would surely be useful if all params objects were cloneable. I'd say that
on cloning, a params object should copy the parameters it holds locally, but
keep the same reference for the default params. No need to clone defaults,
since they are accessed read-only.

While you're at it, can you add an "implements Serializable" as well?
I don't know what it would be good for, but maybe someone someday wants
do deserialize params objects in an HttpParamsFactory.

regards,
  Roland

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message