hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 15435] - New Preferences Architecture
Date Sat, 06 Sep 2003 15:32:33 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15435>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15435

New Preferences Architecture





------- Additional Comments From becke@u.washington.edu  2003-09-06 15:32 -------
Hi Oleg,

I'm glad you decided to take another stab at this.  This version has some definite improvements,

and I think I can see the light at the end of the tunnel now.  Specifics below:

 - Removing the reliance on the properties and string based values was an excellent idea.
 This 
greatly simplifies things and makes the process of loading defaults separate.  Nice.

 - To replace the loading of defaults from properties I think we need an HttpParamsFactory.
 This 
would replace the static GLOBAL_DEFAULTS.  HttpParamsFactory would have a plugable mechanism

for defining the default params.  Things like the static initializer in HttpMethodParams could
be 
moved there.

 - Are isParameterFalse() and isParameterTrue() necessary?  Seems like getBooleanParameter()

should be enough :)

 - All of the various PROTOCOL_STRICTNESS_PARAMS should be broken out to individual methods
I 
think.

 - Once parameters have methods for getting/setting them I do not think the public param Strings

for them are required.

Again, nice work.

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message