hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 21210] - HeaderElement#parse(String) implementation is not optimal
Date Sat, 12 Jul 2003 19:53:23 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21210>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21210

HeaderElement#parse(String) implementation is not optimal





------- Additional Comments From olegk@apache.org  2003-07-12 19:53 -------
> There are a few places where methods that return arrays or a list 
> return null. I think they should instead return an empty array or list.  e.g. 
> HeaderElement.parseElements(), 
> ParameterParser.parse().

I think the above mentioned parsing routines return null only when receive null
as input. They always return an array or list when input is not a null (empty
string, for instance). If you think it is still inconsistent, I'll happily
change these methods

> Header.getValues()  is using the newly deprecated HeaderElement.parse().

Good catch. Corrected.

> There are a number of style violations.  Mostly minor stuff like spacing
> and missing or incorrect javadocs.  It's nitpicking but we want to keep
> that code pretty:)

It turned out that all javadoc warnings had been caused by removal of deprecated
methods. Corrected. 

Oleg

Mime
View raw message