hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ron Tower" <rto...@sugarloafsw.com>
Subject Re: Commas in Cookie Value
Date Fri, 20 Jun 2003 12:31:42 GMT
Oleg,

I noticed that there didn't seem to be a way to plug in a custom CookieSpec.
I was wondering how to do it. For now, I will wait for 2.1 or download the
source and modify one of the CookieSpecs.

Thanks,

Ron Tower

----- Original Message -----
From: "Oleg Kalnichevski" <olegk@apache.org>
To: "Commons HttpClient Project" <commons-httpclient-dev@jakarta.apache.org>
Sent: Wednesday, June 18, 2003 5:32 PM
Subject: Re: Commas in Cookie Value


> Ron (I apologise for misspelling your name in my previous post),
>
> You can easily subclass any of the CookieSpec classes. The trouble is
> there's no way to plug a custom cookie spec into the existing
> implementation of HttpClient. At the moment you have to modify
> CookiePolicy class and recompile Httpclient in order to get it done. We
> are aware of the problem and will address it in 2.1 release.
>
> Oleg
>
> PS: Brett's patch may eventually make it into the official Httpclient
> source tree, but that is not going to happen too soon. Maybe in 3.0
>
>
>
> On Wed, 2003-06-18 at 22:06, Ron Tower wrote:
> > Brett,
> >
> > I didn't download the source, just the jar and the docs. Could I
subclass
> > from a CookieSpec and just replace the parse of Set-Cookie? I would
prefer
> > to not have to modify the source so I can easily replace it with
upcoming
> > versions without having to put my change back in.
> >
> > Is your fix going into the main source? Do you know when?
> >
> > But if there is no other way, I can download the source, and then I
would
> > appreciate your fix.
> >
> > Thanks,
> >
> > Ron Tower
> >
> > ----- Original Message -----
> > From: "Brett Knights" <brett@knightsofthenet.com>
> > To: "Commons HttpClient Project"
<commons-httpclient-dev@jakarta.apache.org>
> > Sent: Wednesday, June 18, 2003 3:06 PM
> > Subject: Re: Commas in Cookie Value
> >
> >
> > > I have a fix for this but it uses the org.apache.oro regular
> > > expression parser.
> > > E-mail me off line if you want the code to hack your own copy of
> > > HttpClient
> > >
> > > ----- Original Message -----
> > > From: "Ron Tower" <rtower@sugarloafsw.com>
> > > To: <commons-httpclient-dev@jakarta.apache.org>
> > > Sent: Wednesday, June 18, 2003 9:26 AM
> > > Subject: Commas in Cookie Value
> > >
> > >
> > > Hello All,
> > >
> > > Is there a problem when  a comma appears in a cookie value? See
> > > 02109POS below. It has a comma in the value and is split into two
> > > cookies. IE at least parses this cookie as one cookie. Is there a
> > > workaround for this?
> > >
> > > My understanding is that a cookie value can have any character other
> > > than a semicolon, space, or tab.
> > >
> > > I got the following Set-Cookie headers:
> > >
> > > [DEBUG] wire - -<< "Set-cookie: CDSContentDistributor=137169;
> > > expires=Tuesday, 17-Jun-03 20:52:01 GMT; path=/[\r][\n]"
> > > [DEBUG] wire - -<< "Set-cookie: 02109POS=<www4210513143792642538,>;
> > > domain=.fidelity.com; path=/; expires=Fri, 12-Sep-2003 00:00:00
> > > GMT;[\r][\n]"
> > > [DEBUG] wire - -<< "Set-cookie:
> > > MC=clHza1XIKW50aXo3nr5LD3gDFYMSAiWYtqihBBHXpfPA37wNqncGBAAAAQAGBT7vfRk
> > > AP03; expires=Monday, 15-Sep-2003 20:42:01 GMT; domain=.fidelity.com;
> > > path=/[\r][\n]"
> > >
> > > And HttpClient sent the following Cookies:
> > >
> > > [DEBUG] wire - ->> "Cookie: $Version=0; CDSContentDistributor=137169;
> > > $Path=/[\r][\n]"
> > > [DEBUG] wire - ->> "Cookie: $Version=0;
> > > 02109POS=<www4210513143792642538[\r][\n]"
> > > [DEBUG] wire - ->> "Cookie: $Version=0; >=; $Domain=.fidelity.com;
> > > $Path=/[\r][\n]"
> > > [DEBUG] wire - ->> "Cookie: $Version=0;
> > > MC=clHza1XIKW50aXo3nr5LD3gDFYMSAiWYtqihBBHXpfPA37wNqncGBAAAAQAGBT7vfRk
> > > AP03; $Domain=.fidelity.com; $Path=/[\r][\n]"
> > >
> > > Thanks,
> > >
> > > Ron Tower
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> > commons-httpclient-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail:
> > commons-httpclient-dev-help@jakarta.apache.org
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
commons-httpclient-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail:
commons-httpclient-dev-help@jakarta.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:
commons-httpclient-dev-help@jakarta.apache.org
>


Mime
View raw message