hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 10807] - Handle virtual hosts, relative urls, multi-homing
Date Tue, 08 Apr 2003 01:28:12 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10807>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10807

Handle virtual hosts, relative urls, multi-homing





------- Additional Comments From becke@u.washington.edu  2003-04-08 01:28 -------
Oleg,

Generally speaking looks good to me.  It's simple and gets the job done with no
damaging API changes.  There is only one missing piece of functionality in
HttMethodBase.generateRequestLine().  I'm guessing it should probably be using
the virtual host name here.  Perhaps it should the host should always be used
when virtual.

I also have only a few minor comments:

- I think the comments in HttpConnection.setHost() and getHost() should stay as
they are.  Using "host name" implies it should be a DNS name.
- HostConfiguration.sethost(String) has an extra @param javadoc
- there should probably be some test cases for the virtual host

Mike

Mime
View raw message