Return-Path: Mailing-List: contact commons-httpclient-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list commons-httpclient-dev@jakarta.apache.org Received: (qmail 87879 invoked from network); 7 Feb 2003 23:37:56 -0000 Received: from tomts10.bellnexxia.net (HELO tomts10-srv.bellnexxia.net) (209.226.175.54) by daedalus.apache.org with SMTP; 7 Feb 2003 23:37:56 -0000 Received: from sympatico.ca ([64.230.115.53]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.04.19 201-253-122-122-119-20020516) with ESMTP id <20030207233802.IRRV23728.tomts10-srv.bellnexxia.net@sympatico.ca> for ; Fri, 7 Feb 2003 18:38:02 -0500 Message-ID: <3E44435A.7060201@sympatico.ca> Date: Fri, 07 Feb 2003 18:38:02 -0500 From: Jeffrey Dever User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20021120 Netscape/7.01 X-Accept-Language: en-ca, en-us, en MIME-Version: 1.0 To: Commons HttpClient Project Subject: Re: [patch] for Bug 16864 References: <0AC2D75550100F4DBDB025D4D0561188770428@BIGCOW.intraephox.ephox.com> <3E433A62.3050902@sympatico.ca> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N I guess no comments are good comments ;-) I'll check in the patch. Jeffrey Dever wrote: > I was too hot on the send button. This'll help ;-) > > I have tests that I'm just committing now ... > > Adrian Sutton wrote: > >> Jeff, >> There was no attached patch. :) At least, not at my end.... >> >> Thanks for the quick response, I'm sure the user will appreciate it >> greatly! >> :) >> >> Adrian Sutton, Software Engineer >> Ephox Corporation >> www.ephox.com >> >> >> -----Original Message----- >> From: Jeffrey Dever [mailto:jsdever@sympatico.ca] >> Sent: Friday, 7 February 2003 2:33 PM >> To: Commons HttpClient Project >> Subject: [patch] for Bug 16864 >> >> >> I created some tests for this issue and checked them in. >> >> Attached is a patch to fix the issue and make the tests pass, but it >> needs to be reviewed. I changed slightly the semantics of one very >> important method: HttpConnection.readLine(). >> It now requires the a "\r\n" be present as a pair to terminate the >> line (that was the root cause of bug 16846). If the end of stream is >> read before a \n\r is found, the data read up untill that point will >> be returned, whereas before this was discarded. I also tried to >> minimize the number of checks in the while loop to try and speed it >> up a bit. >> >> Please review the attached patch. >> >> Jandalf. >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: >> commons-httpclient-dev-unsubscribe@jakarta.apache.org >> For additional commands, e-mail: >> commons-httpclient-dev-help@jakarta.apache.org >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: >> commons-httpclient-dev-unsubscribe@jakarta.apache.org >> For additional commands, e-mail: >> commons-httpclient-dev-help@jakarta.apache.org >> >> >> >> > > >------------------------------------------------------------------------ > >--------------------------------------------------------------------- >To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org >For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org >