hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <o.kalnichev...@dplanet.ch>
Subject [PATCH] MultipartPost revisited (take 2) ATTN: Mike Becke
Date Tue, 11 Feb 2003 22:19:35 GMT
On Tue, 2003-02-11 at 04:19, Jeffrey Dever wrote:
> I like the refactoring. Only complaint is that the classes are public. 
> Package access would be prefered, but this may not be possible.

The new patch addressed concerns raised by Jeff "Jandalf". Now all the
wire logging is (should be) confined to the HttpConnection classes.
Wire, WireLogInputStream, WireLogOutputStream classes have package

To Mike Becke:
The modifications to the wire logging I made did not coexist well with
the changes introduced by your most recent patch. It's a bit of a
problem that response headers are now retrieved outside HttpConnection
class, which makes wire logging difficult. 

Please let me know if you find acceptable those modifications I made to
your code. 

There were subtle problems HttpConnection#readLine which I believe I
have fixed. Besides, I tend to lean toward separating
HttpConnection#readLine method and new HttpConnection#readRawLine into a
helper class of its own. Any objections to that? If not, do you happen
to think of a good name for that class? LineParser?  

As always I would greatly appreciate your response



Fixes the following bugs:


Change log:
- MultipartPost related methods clean-up
- Part#send(OutputStream out) &  long Part#length() are no more final
- Content encoding can be specified 
- FilePart's content type can be specified 
- Wire logging improvement

View raw message