Return-Path: Mailing-List: contact commons-httpclient-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list commons-httpclient-dev@jakarta.apache.org Received: (qmail 24711 invoked from network); 31 Jan 2003 22:04:34 -0000 Received: from duba04h04-0.dplanet.ch (212.35.36.38) by daedalus.apache.org with SMTP; 31 Jan 2003 22:04:34 -0000 Received: from 254-195-zh-1-1.dplanet.ch (254-195-zh-1-1.dplanet.ch [62.167.254.195]) by duba04h04-0.dplanet.ch (8.9.3/8.9.3/1.01dplanet-smtp) with ESMTP id XAA28725 for ; Fri, 31 Jan 2003 23:04:37 +0100 Subject: Re: [PATCH] PostMethod & PutMethod revision (take 3) From: Oleg Kalnichevski To: Commons HttpClient Project In-Reply-To: <3E3AEE04.20609@u.washington.edu> References: <3E3AEE04.20609@u.washington.edu> Content-Type: text/plain Organization: Message-Id: <1044050688.1148.4.camel@kczrh-okt22.corp.bearingpoint.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.1 Date: 31 Jan 2003 23:04:48 +0100 Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Thanks, Mike Good points. I'll make corrections before committing the patch Enjoy your weekend Cheers Oleg On Fri, 2003-01-31 at 22:43, Michael Becke wrote: > Looks good, nice work. I only noticed a few things, mostly in regard to > formatting, comments. > > - in EntityEnclosingMethod there are a few places when there is an extra > carriage return between the Javadoc comment and the method. > - PostMethod and EntityEnclosingMethod have some unused imports > - the @deprecated message for PostMethod.getParameters() points to > setRequestBody(), but I'm guessing you wanted getRequestBody(). > - EntityEnclosingMethod.setFollowsRedirects() always sets to false. > perhaps a warning should be printed until this can be remedied. > > All tests passed for me. > > Mike > > Kalnichevski, Oleg wrote: > > Bug fixes: > > > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11095 > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11653 > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14731 > > > > Changelog: > > > > - Abstract EntityEnclosingMethod class has been introduced to encapsulate common behaviour of all entity enclosing methods > > - "Expect: 100-continue" header support > > - HttpClient does not hang indefinitely if the server of origin does not return status code 100 when expected. HttpClient resumes sending request body after 3 seconds if no response is sent > > - Support for chunk encoded requests in all entity enclosing methods > > - Entity enclosing methods do not allow automatic redirection > > - More robust (or so I'd like to hope) request content buffering logic > > - PostMethod inherited from EntityEnclosingMethod class > > - PutMethod inherited from EntityEnclosingMethod class > > - Older methods of PostMethod dealing with url-encoded parameters deprecated in favour of new setRequestBody(NameValuePair[]) method > > > > Feedback, critique appreciated, as always. > > > > Jeff, Mike > > I decided to not touch request body buffering as yet. The patch is getting really unwieldy. I would like to have it committed, if you confirm it does not break test cases on your systems. We can deal with smaller issues and improvements incrementally once the patch has been checked in > > > > Cheers > > > > Oleg > > > > PS: The patch appears to have exceeded the allowed maximum. It has just been thrown back to me ;-) > > I am afraid I'll have to compress the file > > > > > > ------------------------------------------------------------------------ > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org > > For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org > For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org -- Oleg Kalnichevski