hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sung-Gu" <jeri...@apache.org>
Subject Re: [PATCH] relative URIs
Date Tue, 28 Jan 2003 04:21:50 GMT
I guess the first one may be ok.. (not second one)
(Perhaps it might be compared with included test cases
 that it's not consistent with httpclient test cases.)

Sung-Gu

P.S. Someone modify them comittable to httpclient?

----- Original Message -----
From: "Jeffrey Dever" <jsdever@sympatico.ca>
To: "Commons HttpClient Project" <commons-httpclient-dev@jakarta.apache.org>
Sent: Tuesday, January 28, 2003 1:09 PM
Subject: Re: [PATCH] relative URIs


> Sung-Gu,
>
> Do you approve of this patch?
>
>
> Sung-Gu wrote:
>
> >----- Original Message -----
> >From: "Michael Becke" <becke@u.washington.edu>
> >Subject: [PATCH] relative URIs
> >
> >
> >
> >
> >>Attached is a patch and test case for a few minor bugs I discovered in
> >>the URI(URI, URI) constructor.  The patch changes the following:
> >>
> >>- fixes the case when the second arg to URI(URI,URI) is just a fragment
> >>(e.g. "#s").  According to RFC 2396 a relative reference that is just a
> >>fragment should resolve to the "current document" plus the fragment.  I
> >>took this to mean that URI( "http://a/b/c/d;p?q", "#s" ) should resolve
> >>to "http://a/b/c/d;p?q#s".  Please let me know if this seems incorrect.
> >>
> >>
> >
> >Isn't it?  then a bug... :(
> >It seems like query not to be resolved ...
> >
> >
> >
> >>- changes setURI() to no longer ignores fragments, getURI() and
> >>toString() now return the full URI including the fragment.
> >>
> >>
> >
> >There is getURIReference().   That's not like getURI().
> >Actually, URI and URI-reference is different...
> >
> >In common, on both protocol and document uses,
> >an URI is effective...  not URI-reference.  That's why...
> >
> >Sung-Gu
> >
> >--
> >To unsubscribe, e-mail:
<mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
> >For additional commands, e-mail:
<mailto:commons-httpclient-dev-help@jakarta.apache.org>
> >
> >
> >
> >
>
>
> --
> To unsubscribe, e-mail:
<mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:commons-httpclient-dev-help@jakarta.apache.org>
>

Mime
View raw message