hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kalnichevski, Oleg" <oleg.kalnichev...@bearingpoint.com>
Subject RE: [HttpClient] Proposed style change
Date Tue, 28 Jan 2003 11:06:50 GMT
There is quite a few people out there (including myself) who prefer adding 'this.' to their
instance variables in order to be able to differentiate them from local ones. I am aware there
are tons of people who passionately hate this kind of convention. However, I am just wondering
if it is going to be considered a violation new coding guidelines?

Oleg

-----Original Message-----
From: Jeffrey Dever [mailto:jsdever@sympatico.ca]
Sent: Dienstag, 28. Januar 2003 02:04
To: Commons HttpClient Project
Subject: Re: [HttpClient] Proposed style change


>
>
>>I propose that we change the pattern for instance variables to
>>^_?[a-z][a-zA-Z0-9]*$ so that we will allow leading underscores but will
>>not insist on it.
>>    
>>
>
>Uuuugh, please no!  Besides being ugly, it's worth sticking to the Sun
>coding
>style (as is the default with checkstyle). That way, anyone who has done any
>Java will be immediately familiar with it.
>
>  
>
I'd agree with Simon on this.  Leading (and trailing) underscores are 
ugly (just look a Python!).  If its too difficult to determine if a 
variable is a member or a local, then the method is probablly too big. 
 And you can always prefix this to a member for clarity.



--
To unsubscribe, e-mail:   <mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-httpclient-dev-help@jakarta.apache.org>


Mime
View raw message