hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kalnichevski, Oleg" <oleg.kalnichev...@bearingpoint.com>
Subject RE: [PATCH] You see, it did not even hurt [no more disk buffering in GetMethod]
Date Fri, 24 Jan 2003 10:15:51 GMT
Jeff, Mike

I felt that removal of disk buffering code was justified because of several reasons:

1) Disk buffering is completely transparent to HttpClient consumers. Its removal *should*
not break any existing code 

2) The whole disk buffering thingy is fundamentally flawed

3) This is an outstanding bug related to disk buffering that none seems to be eager to fix

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11052

4) Even in out own test case suite there's NOT A SINGLE test case which would make use of
GetMethod specific constructors. Our own tests cases in their majority simply turn off disk
buffering

That's my way of doing things: I would rather have less features that always work, rather
than more features that work sometimes. Applied to this particular case I would rather have
buggy code removed even at the cost of upsetting a few people (even that I suspect it not
going to be the case) rather than releasing library that is flawed

Oleg

-----Original Message-----
From: Jeffrey Dever [mailto:jsdever@sympatico.ca]
Sent: Donnerstag, 23. Januar 2003 21:55
To: Commons HttpClient Project
Subject: Re: [PATCH] You see, it did not even hurt [no more disk
buffering in GetMethod]


Mike is right Oleg, that hurts more than you said!

I was just expecting a bunch of @deprecated tags and no removal of 
methods or members.  In each  @deprecated tag, it should state what 
method to use instead or how to gain equivelent functionality.

 Deprecated methods should still work, but are no longer recomended and 
are flagged for removal at a later date.

-jsd

Michael Becke wrote:

> It looks like the methods are deprecated and the functionality has 
> been removed.  I thought it was just going to be deprecated and then 
> removed in 2.1.
>
> Also, the constructors GetMethod(String path, String tempDir) and 
> GetMethod(String path, String tempDir, String tempFile) should 
> probably be deprecated.
>
> Mike
>
> Kalnichevski, Oleg wrote:
>
>> Comments, critique welcome
>> Cheers
>> Oleg
>>
>>
>>
>> -----Original Message-----
>> From: Ortwin Gl├╝ck [mailto:ortwin.glueck@nose.ch]
>> Sent: Donnerstag, 23. Januar 2003 16:42
>> To: Commons HttpClient Project
>> Subject: Re: Would anyone miss GetMethod.setUseDisk()?
>>
>>
>>
>>
>> Jeffrey Dever wrote:
>>
>>> I agree that the disk buffering methods are obsolete.  Its trivial 
>>> for a user to wrap our outputstream  into a fileoutputstream.  
>>> However, we must remember that we are building a library as opposed 
>>> to an application and such be careful what we remove.  Methods that 
>>> don't make sense anymore should be deprecated for 2.0, but not 
>>> removed untill 2.1
>>
>>
>>
>> Good point.
>>
>>
>>> One possible enhancement to 2.1 would be to add a Cache module which 
>>> would work like a web browser cache to write gets to file and refers 
>>> to the cache before pulling the resource again.  Just a thought.
>>
>>
>>
>> Cool, if this is something our users want. I don't want to build in 
>> functionality that nobody uses, though.
>>
>>
>>> <ha ha>
>>> Odo, like Frodo
>>> Ortagorn, like Aragorn
>>> Odomir, like Boromir
>>> Odli, like Gimli
>>> Ortrond or Elwin like Elrond
>>> </ha ha>
>>
>>
>>
>> Orthanc, maybe? (hostname of my home computer actually)
>>
>>
>> --
>> To unsubscribe, e-mail:   
>> <mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
>> For additional commands, e-mail: 
>> <mailto:commons-httpclient-dev-help@jakarta.apache.org>
>>
>>
>> ------------------------------------------------------------------------
>>
>> --
>> To unsubscribe, e-mail:   
>> <mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
>> For additional commands, e-mail: 
>> <mailto:commons-httpclient-dev-help@jakarta.apache.org>
>
>
>
> --
> To unsubscribe, e-mail:   
> <mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: 
> <mailto:commons-httpclient-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:commons-httpclient-dev-help@jakarta.apache.org>


Mime
View raw message