hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeffrey Dever <jsde...@sympatico.ca>
Subject Re: [PATCH] Bug 16429 Align the code base with checkstyle
Date Tue, 28 Jan 2003 04:38:02 GMT
Hey Mike,
A couple issues with the patch.  The tests failed due to a change to the 
parameters member in HeaderElement.  A protected member was made to be 
private and given an accessor.  I think that this is a good change, but 
patches should pass the tests before they are posted.  The tests were 
pretty bogus anyway, so I just patched them so its OK now.  This is what 
I had:

     [java] There was 1 error:
     [java] 1) 
testOldMain(org.apache.commons.httpclient.TestHeaderElement)java.lang.NoSuchFieldError: 
parameters
     [java]     at 
org.apache.commons.httpclient.TestHeaderElement.testOldMain(TestHeaderElement.java:118)
     [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
     [java]     at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
     [java]     at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

     [java] FAILURES!!!
     [java] Tests run: 161,  Failures: 0,  Errors: 1


Also, I don't want to change to using any style that is contentious.  In 
particular allowing members to be prefixed with an underscore.  Its fine 
to leave them untill this is ironed out, but don't add any new ones! I 
commited the patch regardless because it represents several hours of 
good work and can be changed (or not) later with a search and replace 
depending on the decision.

Jandalf.


Mike Bowler wrote:

> I've added a second patch to the bug which fixes more checkstyle 
> warnings.  I'm still not sure why the patches were being discarded 
> from my emails this morning so I'm just playing it safe and putting 
> them in bugzilla.
>
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16429
>
>


Mime
View raw message