Return-Path: Mailing-List: contact commons-httpclient-dev-help@jakarta.apache.org; run by ezmlm Delivered-To: mailing list commons-httpclient-dev@jakarta.apache.org Received: (qmail 2879 invoked by uid 98); 17 Dec 2002 16:04:01 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Received: (qmail 2858 invoked from network); 17 Dec 2002 16:03:59 -0000 Received: from daedalus.apache.org (HELO apache.org) (63.251.56.142) by nagoya.betaversion.org with SMTP; 17 Dec 2002 16:03:59 -0000 Received: (qmail 77170 invoked by uid 500); 17 Dec 2002 16:02:48 -0000 Received: (qmail 77163 invoked from network); 17 Dec 2002 16:02:48 -0000 Received: from unknown (HELO KCCXOEX10.corp.kpmgconsulting.com) (57.80.136.22) by daedalus.apache.org with SMTP; 17 Dec 2002 16:02:48 -0000 Received: from kccxoex03.corp.kpmgconsulting.com ([57.80.136.6]) by KCCXOEX10.corp.kpmgconsulting.com with Microsoft SMTPSVC(5.0.2195.4905); Tue, 17 Dec 2002 16:03:07 +0000 X-MimeOLE: Produced By Microsoft Exchange V6.0.6249.0 content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Subject: RE: javadoc fix and 1 bug found Date: Tue, 17 Dec 2002 16:02:47 -0000 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: javadoc fix and 1 bug found Thread-Index: AcKl4xSFZCV099r4RySnsKUS/hQEHwAAN/gQ From: "Kalnichevski, Oleg" To: "Commons HttpClient Project" X-OriginalArrivalTime: 17 Dec 2002 16:03:07.0394 (UTC) FILETIME=[C9F18E20:01C2A5E5] X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Sylwester There's more work that needs to be done on PutMethod. Currently = PostMethod and PutMethod despite massive commonalities are not even = compatible on the API level. The use of deprecated methods is the most = glaring example of PutMethod requiring some attention. This said, most = of the refactoring work has been somewhat put on hold due to the pending = (even imminent) alpha release - isIpAddress needs to be removed (good catch) - Sung-Gu should take a look at the Uri.java as that class is almost = exclusively his department Since all committers are busy today there's not much we can right now Cheers Oleg -----Original Message----- From: Sylwester Lachiewicz [mailto:matrix@plusnet.pl] Sent: Tuesday, December 17, 2002 4:44 PM To: Commons HttpClient Project Subject: javadoc fix and 1 bug found Hello, i was looked into httpclient project and found few things: Uri.java (line 214) parameter String fragment is never used - so = constructed url is incorrect - mayby new bugzilla bug HttpMethodBase.java (line 2025) method private static boolean isIpAddress(String value) is never used a attach patch to fix javadoc comments and reorganize imports (remove = unused and sort) also patch bellow will remove call to deprecated method Can someone look at my patch and commit this to repository? Sylwester Index: org/apache/commons/httpclient/methods/PutMethod.java =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/cvspublic/jakarta-commons/httpclient/src/java/org/apache/commons/ht= tpc lient/methods/PutMethod.java,v retrieving revision 1.16 diff -u -r1.16 PutMethod.java --- org/apache/commons/httpclient/methods/PutMethod.java 25 Oct 2002 10:15:52 -0000 1.16 +++ org/apache/commons/httpclient/methods/PutMethod.java 17 Dec 2002 15:21:04 -0000 @@ -62,21 +62,11 @@ package org.apache.commons.httpclient.methods; -import org.apache.commons.httpclient.HttpConnection; -import org.apache.commons.httpclient.HttpException; -import org.apache.commons.httpclient.HttpMethodBase; -import org.apache.commons.httpclient.HttpState; -import org.apache.commons.httpclient.HttpStatus; +import org.apache.commons.httpclient.*; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; -import java.io.ByteArrayInputStream; -import java.io.ByteArrayOutputStream; -import java.io.File; -import java.io.FileInputStream; -import java.io.IOException; -import java.io.InputStream; -import java.io.OutputStream; +import java.io.*; import java.net.URL; @@ -254,7 +244,12 @@ getStatusLine().getStatusCode() !=3D = HttpStatus.SC_CONTINUE) { return false; } - OutputStream out =3D conn.getRequestOutputStream((isHttp11() && = (null =3D=3D getRequestHeader("Content-Length")))); + OutputStream out =3D null; + // getRequestOutputStream(boolean useChunking) was deprecated + if ((isHttp11() && (null =3D=3D = getRequestHeader("Content-Length")))) + out =3D new = ChunkedOutputStream(conn.getRequestOutputStream()); + else + out =3D conn.getRequestOutputStream(); InputStream inputStream =3D null; if (file !=3D null && file.exists()) {