hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Becke <be...@u.washington.edu>
Subject Re: [PATCH]Protocol take 1
Date Sat, 14 Dec 2002 00:09:56 GMT
>
> As far as I can see it is shaping up very well. HttpConnection.open() 
> is now much cleaner. Unfortunately it appears Ortwin is busy these 
> days, as he's had some good suggestions about protocol management. I 
> take liberty of re-posting of some of his previous points:
>
> - Use Flyweight pattern to ensure there is only a single Object per 
> protocol.

I'm not sure Flyweight is appropriate here.  Perhaps I don't understand 
it correctly, but I though it is meant to be used when there are a 
large number of objects containing potentially the same data.

> - Just Protocol class may suffice. Static methods of the 
> ProtocolManager may be put in to the Protocol class and the 
> ProtocolManager may be done away with altogether

Agreed.  I'll move it all into Protocol.

> Ortwin, please correct me if I missed something
>
> Cheers
>
> Oleg
>
>> Attached is a first attempt at changing how protocol is used.  All
>> criticism is welcome.  In particular, if Oleg or Ortwin have any
>> comments I would appreciate them.
>>
>> This patch should be backwards compatible, except for the removal of
>> setSSLSocketFactory() in HttpClient and HttpConnection.
>>
>> Enjoy,
>>
>> Mike
>>
>>
>>
>>  <<Attachment: Protocol.patch >>
>>
>> --
>> To unsubscribe, e-mail:   
>> <mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
>> For additional commands, e-mail: 
>> <mailto:commons-httpclient-dev-help@jakarta.apache.org>
>
> --
> To unsubscribe, e-mail:   
> <mailto:commons-httpclient-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: 
> <mailto:commons-httpclient-dev-help@jakarta.apache.org>
>


Mime
View raw message