hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <o.kalnichev...@dplanet.ch>
Subject Re: [PATCH]: Cookie management refactored. Proposal
Date Thu, 05 Dec 2002 21:01:07 GMT

> - not sure I like statemgmt as a package name.  just cookie is more 
> descriptive
> 

Done.

Tastes differ, of course. I just though cookie was a bit too narrow.
Besides, the Cookie class is still in org.apavche.commons.httpclient. 

> One thing that bothers me about httpclient, is the flow from headers -> 
> datastructure -> header.  Two things happen here: 1) all headers of one 
> type are "compressed" into a single header.  2) the value that is pushed 
> back out is the reconstructed form from the internal data structure.  
> 
> I think that the assumptions that lead the the above are naive.  
> 
> If everyone conformed exactly to the spec, there would be little problem 
> with converting to an internal datastructure.  The value could be 
> reconstructed exactly.  But there are always variations in the input 
> which are allowed but lost after parsing.
> 
> I also think that it is better to seperate out multiple header values 
> into multiple headers, rather than compressing them all as multiple 
> values to a single header.  We save little in overhead, make the headers 
> more difficult to parse, ant loose possibly interesting formatting 
> information.
> 

No discussion.  RFC 2965 compliance is my ultimate target. Besides, the
current scheme is simply broken as it totally ignores possibility of
cookies having different versions. Consider it done

Cheers

Oleg



Mime
View raw message