hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ol...@apache.org
Subject [1/2] httpcomponents-client git commit: Removed #finalize() methods deprecated in Java 9
Date Sun, 22 Oct 2017 12:35:50 GMT
Repository: httpcomponents-client
Updated Branches:
  refs/heads/master 9368c5f5c -> 23425a137


Removed #finalize() methods deprecated in Java 9


Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/commit/09aee8c4
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/tree/09aee8c4
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/diff/09aee8c4

Branch: refs/heads/master
Commit: 09aee8c422ae3cd8a6bbd3f0fd2ddea8047aee12
Parents: 9368c5f
Author: Oleg Kalnichevski <olegk@apache.org>
Authored: Sun Oct 22 14:33:01 2017 +0200
Committer: Oleg Kalnichevski <olegk@apache.org>
Committed: Sun Oct 22 14:33:01 2017 +0200

----------------------------------------------------------------------
 .../hc/client5/http/impl/win/WindowsNegotiateScheme.java    | 6 ------
 .../http/impl/io/BasicHttpClientConnectionManager.java      | 9 ---------
 .../http/impl/io/PoolingHttpClientConnectionManager.java    | 9 ---------
 .../http/impl/nio/PoolingAsyncClientConnectionManager.java  | 9 ---------
 4 files changed, 33 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/09aee8c4/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WindowsNegotiateScheme.java
----------------------------------------------------------------------
diff --git a/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WindowsNegotiateScheme.java
b/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WindowsNegotiateScheme.java
index 501a168..90dc906 100644
--- a/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WindowsNegotiateScheme.java
+++ b/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WindowsNegotiateScheme.java
@@ -114,12 +114,6 @@ public class WindowsNegotiateScheme implements AuthScheme {
     }
 
     @Override
-    public void finalize() throws Throwable {
-        dispose();
-        super.finalize();
-    }
-
-    @Override
     public String getName() {
         return scheme;
     }

http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/09aee8c4/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java
b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java
index ecde0f2..11b31f9 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/BasicHttpClientConnectionManager.java
@@ -151,15 +151,6 @@ public class BasicHttpClientConnectionManager implements HttpClientConnectionMan
     }
 
     @Override
-    protected void finalize() throws Throwable {
-        try {
-            close();
-        } finally { // Make sure we call overridden method even if shutdown barfs
-            super.finalize();
-        }
-    }
-
-    @Override
     public void close() {
         if (this.closed.compareAndSet(false, true)) {
             shutdownConnection();

http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/09aee8c4/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
index e517ef8..f3ff470 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/PoolingHttpClientConnectionManager.java
@@ -220,15 +220,6 @@ public class PoolingHttpClientConnectionManager
     }
 
     @Override
-    protected void finalize() throws Throwable {
-        try {
-            close();
-        } finally {
-            super.finalize();
-        }
-    }
-
-    @Override
     public void close() {
         if (this.closed.compareAndSet(false, true)) {
             this.log.debug("Connection manager is shutting down");

http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/09aee8c4/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
----------------------------------------------------------------------
diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
index 8dbfc8a..b393a65 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/impl/nio/PoolingAsyncClientConnectionManager.java
@@ -186,15 +186,6 @@ public class PoolingAsyncClientConnectionManager implements AsyncClientConnectio
     }
 
     @Override
-    protected void finalize() throws Throwable {
-        try {
-            close();
-        } finally {
-            super.finalize();
-        }
-    }
-
-    @Override
     public void close() {
         if (closed.compareAndSet(false, true)) {
             log.debug("Connection manager is shutting down");


Mime
View raw message