hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ol...@apache.org
Subject [2/2] httpcomponents-client git commit: HTTPCLIENT-1855: disabled caching of DIGEST auth scheme instances due to unreliability of nonce counter when the auth cache is shared by multiple sessions
Date Fri, 20 Oct 2017 09:52:38 GMT
HTTPCLIENT-1855: disabled caching of DIGEST auth scheme instances due to unreliability of nonce
counter when the auth cache is shared by multiple sessions


Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/commit/ba47719c
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/tree/ba47719c
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-client/diff/ba47719c

Branch: refs/heads/4.6.x
Commit: ba47719c3adcc328fd800296ab5189d965ee216c
Parents: 722490c
Author: Oleg Kalnichevski <olegk@apache.org>
Authored: Fri Oct 20 11:45:12 2017 +0200
Committer: Oleg Kalnichevski <olegk@apache.org>
Committed: Fri Oct 20 11:50:31 2017 +0200

----------------------------------------------------------------------
 .../apache/http/impl/client/AuthenticationStrategyAdaptor.java    | 3 +--
 .../org/apache/http/impl/client/AuthenticationStrategyImpl.java   | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/ba47719c/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AuthenticationStrategyAdaptor.java
----------------------------------------------------------------------
diff --git a/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AuthenticationStrategyAdaptor.java
b/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AuthenticationStrategyAdaptor.java
index f72ae07..d09b670 100644
--- a/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AuthenticationStrategyAdaptor.java
+++ b/httpclient/src/main/java-deprecated/org/apache/http/impl/client/AuthenticationStrategyAdaptor.java
@@ -167,8 +167,7 @@ class AuthenticationStrategyAdaptor implements AuthenticationStrategy
{
             return false;
         }
         final String schemeName = authScheme.getSchemeName();
-        return schemeName.equalsIgnoreCase(AuthPolicy.BASIC) ||
-                schemeName.equalsIgnoreCase(AuthPolicy.DIGEST);
+        return schemeName.equalsIgnoreCase(AuthPolicy.BASIC);
     }
 
     public AuthenticationHandler getHandler() {

http://git-wip-us.apache.org/repos/asf/httpcomponents-client/blob/ba47719c/httpclient/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java
----------------------------------------------------------------------
diff --git a/httpclient/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java
b/httpclient/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java
index 1f35e61..4ca17c3 100644
--- a/httpclient/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java
+++ b/httpclient/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java
@@ -237,8 +237,7 @@ abstract class AuthenticationStrategyImpl implements AuthenticationStrategy
{
             return false;
         }
         final String schemeName = authScheme.getSchemeName();
-        return schemeName.equalsIgnoreCase(AuthSchemes.BASIC) ||
-                schemeName.equalsIgnoreCase(AuthSchemes.DIGEST);
+        return schemeName.equalsIgnoreCase(AuthSchemes.BASIC);
     }
 
     @Override


Mime
View raw message