hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ol...@apache.org
Subject [14/50] httpcomponents-core git commit: HTTPCORE-331: BasicFuture no longer executes notification callbacks inside a synchronized block (cleanup)
Date Tue, 09 May 2017 20:03:05 GMT
HTTPCORE-331: BasicFuture no longer executes notification callbacks inside a synchronized block
(cleanup)

git-svn-id: https://svn.apache.org/repos/asf/httpcomponents/httpcore/branches/4.2.x@1435147
13f79535-47bb-0310-9956-ffa450edef68


Project: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/commit/d0569b23
Tree: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/tree/d0569b23
Diff: http://git-wip-us.apache.org/repos/asf/httpcomponents-core/diff/d0569b23

Branch: refs/heads/4.2.x
Commit: d0569b23b9b87858da07c9d4afb0cfa910d8243c
Parents: 2d706f9
Author: Oleg Kalnichevski <olegk@apache.org>
Authored: Fri Jan 18 14:10:51 2013 +0000
Committer: Oleg Kalnichevski <olegk@apache.org>
Committed: Fri Jan 18 14:10:51 2013 +0000

----------------------------------------------------------------------
 .../src/main/java/org/apache/http/concurrent/BasicFuture.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/httpcomponents-core/blob/d0569b23/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java
----------------------------------------------------------------------
diff --git a/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java b/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java
index faca044..46a3aca 100644
--- a/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java
+++ b/httpcore/src/main/java/org/apache/http/concurrent/BasicFuture.java
@@ -99,7 +99,7 @@ public class BasicFuture<T> implements Future<T>, Cancellable
{
         }
     }
 
-    public synchronized boolean completed(final T result) {
+    public boolean completed(final T result) {
         synchronized(this) {
             if (this.completed) {
                 return false;
@@ -114,7 +114,7 @@ public class BasicFuture<T> implements Future<T>, Cancellable
{
         return true;
     }
 
-    public synchronized boolean failed(final Exception exception) {
+    public boolean failed(final Exception exception) {
         synchronized(this) {
             if (this.completed) {
                 return false;
@@ -129,7 +129,7 @@ public class BasicFuture<T> implements Future<T>, Cancellable
{
         return true;
     }
 
-    public synchronized boolean cancel(boolean mayInterruptIfRunning) {
+    public boolean cancel(boolean mayInterruptIfRunning) {
         synchronized(this) {
             if (this.completed) {
                 return false;


Mime
View raw message