Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9653A200C73 for ; Wed, 26 Apr 2017 01:26:10 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 950C4160BB6; Tue, 25 Apr 2017 23:26:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DE609160BB3 for ; Wed, 26 Apr 2017 01:26:09 +0200 (CEST) Received: (qmail 46020 invoked by uid 500); 25 Apr 2017 23:26:09 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 46011 invoked by uid 99); 25 Apr 2017 23:26:09 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Apr 2017 23:26:09 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 8B4D53A0F9A for ; Tue, 25 Apr 2017 23:26:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1792684 - /httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java Date: Tue, 25 Apr 2017 23:26:08 -0000 To: commits@hc.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20170425232608.8B4D53A0F9A@svn01-us-west.apache.org> archived-at: Tue, 25 Apr 2017 23:26:10 -0000 Author: ggregory Date: Tue Apr 25 23:26:07 2017 New Revision: 1792684 URL: http://svn.apache.org/viewvc?rev=1792684&view=rev Log: HTTPCORE-458: Validate port values. Add checks and Javadoc. Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java?rev=1792684&r1=1792683&r2=1792684&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java Tue Apr 25 23:26:07 2017 @@ -49,13 +49,23 @@ public final class URIAuthority implemen private final String hostname; private final int port; + /** + * @throws IllegalArgumentException + * If the port parameter is outside the specified range of valid port values, which is between 0 and + * 65535, inclusive. {@code -1} indicates the scheme default port. + */ private URIAuthority(final String userInfo, final String hostname, final int port, final boolean internal) { super(); this.userInfo = userInfo; this.hostname = hostname; - this.port = port; + this.port = Ports.check(port); } + /** + * @throws IllegalArgumentException + * If the port parameter is outside the specified range of valid port values, which is between 0 and + * 65535, inclusive. {@code -1} indicates the scheme default port. + */ public URIAuthority(final String userInfo, final String hostname, final int port) { super(); Args.containsNoBlanks(hostname, "Host name"); @@ -64,7 +74,7 @@ public final class URIAuthority implemen } this.userInfo = userInfo; this.hostname = hostname.toLowerCase(Locale.ROOT); - this.port = port; + this.port = Ports.check(port); } public URIAuthority(final String hostname, final int port) {