Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CF5E8200C3A for ; Fri, 31 Mar 2017 20:50:34 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CE08C160B80; Fri, 31 Mar 2017 18:50:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1FC03160B7C for ; Fri, 31 Mar 2017 20:50:33 +0200 (CEST) Received: (qmail 74937 invoked by uid 500); 31 Mar 2017 18:50:33 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 74928 invoked by uid 99); 31 Mar 2017 18:50:33 -0000 Received: from Unknown (HELO svn01-us-west.apache.org) (209.188.14.144) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Mar 2017 18:50:33 +0000 Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id D49133A00A6 for ; Fri, 31 Mar 2017 18:50:32 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1789730 - /httpcomponents/httpcore/trunk/httpcore5/src/test/java/org/apache/hc/core5/ssl/TestSSLContextBuilder.java Date: Fri, 31 Mar 2017 18:50:32 -0000 To: commits@hc.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20170331185032.D49133A00A6@svn01-us-west.apache.org> archived-at: Fri, 31 Mar 2017 18:50:35 -0000 Author: ggregory Date: Fri Mar 31 18:50:32 2017 New Revision: 1789730 URL: http://svn.apache.org/viewvc?rev=1789730&view=rev Log: Fix compiler warning: Use try-with-resources. Modified: httpcomponents/httpcore/trunk/httpcore5/src/test/java/org/apache/hc/core5/ssl/TestSSLContextBuilder.java Modified: httpcomponents/httpcore/trunk/httpcore5/src/test/java/org/apache/hc/core5/ssl/TestSSLContextBuilder.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/test/java/org/apache/hc/core5/ssl/TestSSLContextBuilder.java?rev=1789730&r1=1789729&r2=1789730&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/test/java/org/apache/hc/core5/ssl/TestSSLContextBuilder.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/test/java/org/apache/hc/core5/ssl/TestSSLContextBuilder.java Fri Mar 31 18:50:32 2017 @@ -163,15 +163,12 @@ public class TestSSLContextBuilder { }); final int localPort = serverSocket.getLocalPort(); - final Socket clientSocket = clientSslContext.getSocketFactory().createSocket(); - try { + try (final Socket clientSocket = clientSslContext.getSocketFactory().createSocket()) { clientSocket.connect(new InetSocketAddress("localhost", localPort), 5000); final InputStream inputStream = clientSocket.getInputStream(); Assert.assertEquals('H', inputStream.read()); Assert.assertEquals('i', inputStream.read()); Assert.assertEquals(-1, inputStream.read()); - } finally { - clientSocket.close(); } final Boolean result = future.get(5, TimeUnit.SECONDS);