Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 79654200B32 for ; Thu, 23 Jun 2016 22:20:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 77F65160A59; Thu, 23 Jun 2016 20:20:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 91E19160A35 for ; Thu, 23 Jun 2016 22:20:36 +0200 (CEST) Received: (qmail 96411 invoked by uid 500); 23 Jun 2016 20:20:35 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 96402 invoked by uid 99); 23 Jun 2016 20:20:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jun 2016 20:20:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 144C4C0247 for ; Thu, 23 Jun 2016 20:20:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.372 X-Spam-Level: X-Spam-Status: No, score=0.372 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-1.428] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1CBSJh-7KRfS for ; Thu, 23 Jun 2016 20:20:34 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A5BB15F368 for ; Thu, 23 Jun 2016 20:20:33 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 28CCFE002B for ; Thu, 23 Jun 2016 20:20:32 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 87A803A006B for ; Thu, 23 Jun 2016 20:20:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1750013 - in /httpcomponents/httpasyncclient/branches/4.1.x: httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/ httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ httpasyncclient/src/main/java/org/ap... Date: Thu, 23 Jun 2016 20:20:29 -0000 To: commits@hc.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20160623202030.87A803A006B@svn01-us-west.apache.org> archived-at: Thu, 23 Jun 2016 20:20:37 -0000 Author: ggregory Date: Thu Jun 23 20:20:29 2016 New Revision: 1750013 URL: http://svn.apache.org/viewvc?rev=1750013&view=rev Log: Add final modifier to local variables. Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java?rev=1750013&r1=1750012&r2=1750013&view=diff ============================================================================== --- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java (original) +++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/main/java/org/apache/http/impl/client/cache/AsynchronousAsyncValidationRequest.java Thu Jun 23 20:20:29 2016 @@ -94,9 +94,9 @@ class AsynchronousAsyncValidationRequest future.get(); } catch (final ProtocolException pe) { this.log.error("ProtocolException thrown during asynchronous revalidation", pe); - } catch (ExecutionException e) { + } catch (final ExecutionException e) { this.log.error("Exception thrown during asynchronous revalidation", e.getCause()); - } catch (InterruptedException e) { + } catch (final InterruptedException e) { Thread.currentThread().interrupt(); } finally { this.parent.markComplete(this.identifier); Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java?rev=1750013&r1=1750012&r2=1750013&view=diff ============================================================================== --- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java (original) +++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/CachingHttpAsyncClientExecChain.java Thu Jun 23 20:20:29 2016 @@ -100,21 +100,21 @@ public class CachingHttpAsyncClientExecC try { final Future future = client.execute(route.getTargetHost(), request, context, null); return Proxies.enhanceResponse(future.get()); - } catch (InterruptedException e) { + } catch (final InterruptedException e) { Thread.currentThread().interrupt(); return null; - } catch (ExecutionException e) { + } catch (final ExecutionException e) { try { throw e.getCause(); - } catch (IOException ex) { + } catch (final IOException ex) { throw ex; - } catch (HttpException ex) { + } catch (final HttpException ex) { throw ex; - } catch (RuntimeException ex) { + } catch (final RuntimeException ex) { throw ex; - } catch (Error ex) { + } catch (final Error ex) { throw ex; - } catch (Throwable ex) { + } catch (final Throwable ex) { throw new UndeclaredThrowableException(ex); } } Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java?rev=1750013&r1=1750012&r2=1750013&view=diff ============================================================================== --- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java (original) +++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient-cache/src/test/java/org/apache/http/impl/client/cache/ClientExecChainAsyncClient.java Thu Jun 23 20:20:29 2016 @@ -111,9 +111,9 @@ public class ClientExecChainAsyncClient HttpRequestWrapper.wrap(request), HttpClientContext.adapt(context), null); future.completed(result); - } catch (IOException e) { + } catch (final IOException e) { future.failed(e); - } catch (HttpException e) { + } catch (final HttpException e) { future.failed(e); } return future; Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java?rev=1750013&r1=1750012&r2=1750013&view=diff ============================================================================== --- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java (original) +++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/CloseableHttpAsyncClientBase.java Thu Jun 23 20:20:29 2016 @@ -97,7 +97,7 @@ abstract class CloseableHttpAsyncClientB if (this.reactorThread != null) { try { this.connmgr.shutdown(); - } catch (IOException ex) { + } catch (final IOException ex) { this.log.error("I/O error shutting down connection manager", ex); } try { Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java?rev=1750013&r1=1750012&r2=1750013&view=diff ============================================================================== --- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java (original) +++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java Thu Jun 23 20:20:29 2016 @@ -113,7 +113,7 @@ class PipeliningClientExchangeHandlerImp if (requestProducer != null) { try { requestProducer.close(); - } catch (IOException ex) { + } catch (final IOException ex) { this.log.debug("I/O error closing request producer", ex); } } @@ -123,7 +123,7 @@ class PipeliningClientExchangeHandlerImp if (responseConsumer != null) { try { responseConsumer.close(); - } catch (IOException ex) { + } catch (final IOException ex) { this.log.debug("I/O error closing response consumer", ex); } } @@ -236,7 +236,7 @@ class PipeliningClientExchangeHandlerImp requestProducer.requestCompleted(this.localContext); try { requestProducer.close(); - } catch (IOException ioex) { + } catch (final IOException ioex) { this.log.debug(ioex.getMessage(), ioex); } } @@ -293,7 +293,7 @@ class PipeliningClientExchangeHandlerImp final Exception ex = responseConsumer.getException(); try { responseConsumer.close(); - } catch (IOException ioex) { + } catch (final IOException ioex) { this.log.debug(ioex.getMessage(), ioex); } if (result != null) { Modified: httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java?rev=1750013&r1=1750012&r2=1750013&view=diff ============================================================================== --- httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java (original) +++ httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestHttpAsyncPrematureTermination.java Thu Jun 23 20:20:29 2016 @@ -305,7 +305,7 @@ public class TestHttpAsyncPrematureTermi try { future.get(); Assert.fail(); - } catch (ExecutionException e) { + } catch (final ExecutionException e) { final Throwable cause = e.getCause(); Assert.assertTrue("Unexpected cause: " + cause, cause instanceof IOException); }