Return-Path: X-Original-To: apmail-hc-commits-archive@www.apache.org Delivered-To: apmail-hc-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BCEEC182BA for ; Fri, 11 Mar 2016 02:45:58 +0000 (UTC) Received: (qmail 81874 invoked by uid 500); 11 Mar 2016 02:45:58 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 81832 invoked by uid 500); 11 Mar 2016 02:45:58 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 81823 invoked by uid 99); 11 Mar 2016 02:45:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Mar 2016 02:45:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3B3F3C0C99 for ; Fri, 11 Mar 2016 02:45:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.471 X-Spam-Level: * X-Spam-Status: No, score=1.471 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.329] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pl0Ie2ntdwzy for ; Fri, 11 Mar 2016 02:45:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTP id 539005F5CD for ; Fri, 11 Mar 2016 02:45:55 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9CDF5E0069 for ; Fri, 11 Mar 2016 02:45:54 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id 8A7D43A0318 for ; Fri, 11 Mar 2016 02:45:54 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1734489 - in /httpcomponents/httpcore/trunk: httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/ httpcore5-h2/src/main/java/org/apache/hc/core5/http2/frame/ httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/ httpcore5/s... Date: Fri, 11 Mar 2016 02:45:54 -0000 To: commits@hc.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20160311024554.8A7D43A0318@svn01-us-west.apache.org> Author: ggregory Date: Fri Mar 11 02:45:53 2016 New Revision: 1734489 URL: http://svn.apache.org/viewvc?rev=1734489&view=rev Log: https://github.com/apache/httpcore/pull/26 - Code quality fix - Utility classes should not have public constructors. Modified: httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/CommandLineUtils.java httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/ResultProcessor.java httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/frame/FrameConsts.java httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/Huffman.java httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/ConnSupport.java httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/TrailerNameFormatter.java httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContexts.java httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Args.java httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Asserts.java httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharsetUtils.java httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/NetUtils.java httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java Modified: httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/CommandLineUtils.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/CommandLineUtils.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/CommandLineUtils.java (original) +++ httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/CommandLineUtils.java Fri Mar 11 02:45:53 2016 @@ -37,6 +37,10 @@ import org.apache.commons.cli.Options; public class CommandLineUtils { + private CommandLineUtils() { + // Do not allow utility class to be instantiated. + } + public static Options getOptions() { final Option iopt = new Option("i", false, "Do HEAD requests instead of GET (deprecated)"); iopt.setRequired(false); Modified: httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/ResultProcessor.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/ResultProcessor.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/ResultProcessor.java (original) +++ httpcomponents/httpcore/trunk/httpcore5-ab/src/main/java/org/apache/hc/core5/http/benchmark/ResultProcessor.java Fri Mar 11 02:45:53 2016 @@ -32,6 +32,10 @@ import org.apache.hc.core5.http.HttpHost public class ResultProcessor { + private ResultProcessor() { + // Do not allow utility class to be instantiated. + } + static NumberFormat nf2 = NumberFormat.getInstance(); static NumberFormat nf3 = NumberFormat.getInstance(); static NumberFormat nf6 = NumberFormat.getInstance(); Modified: httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/frame/FrameConsts.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/frame/FrameConsts.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/frame/FrameConsts.java (original) +++ httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/frame/FrameConsts.java Fri Mar 11 02:45:53 2016 @@ -28,6 +28,10 @@ package org.apache.hc.core5.http2.frame; public final class FrameConsts { + private FrameConsts() { + // Do not allow utility class to be instantiated. + } + public final static int HEAD_LEN = 9; public final static int MAX_PADDING = 255; Modified: httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/Huffman.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/Huffman.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/Huffman.java (original) +++ httpcomponents/httpcore/trunk/httpcore5-h2/src/main/java/org/apache/hc/core5/http2/hpack/Huffman.java Fri Mar 11 02:45:53 2016 @@ -33,6 +33,10 @@ package org.apache.hc.core5.http2.hpack; */ public final class Huffman { + private Huffman() { + // Do not allow utility class to be instantiated. + } + static final int[] CODES = { 0x1ff8, 0x7fffd8, Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/ConnSupport.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/ConnSupport.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/ConnSupport.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/impl/ConnSupport.java Fri Mar 11 02:45:53 2016 @@ -40,6 +40,10 @@ import org.apache.hc.core5.http.config.C */ public final class ConnSupport { + private ConnSupport() { + // Do not allow utility class to be instantiated. + } + public static CharsetDecoder createDecoder(final ConnectionConfig cconfig) { if (cconfig == null) { return null; Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/TrailerNameFormatter.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/TrailerNameFormatter.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/TrailerNameFormatter.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/TrailerNameFormatter.java Fri Mar 11 02:45:53 2016 @@ -45,6 +45,10 @@ import org.apache.hc.core5.util.CharArra */ public class TrailerNameFormatter { + private TrailerNameFormatter() { + // Do not allow utility class to be instantiated. + } + public static Header format(final HttpEntity entity) { if (entity == null) { return null; Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContexts.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContexts.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContexts.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/ssl/SSLContexts.java Fri Mar 11 02:45:53 2016 @@ -51,6 +51,10 @@ import org.apache.hc.core5.annotation.Im @Immutable public class SSLContexts { + private SSLContexts() { + // Do not allow utility class to be instantiated. + } + /** * Creates default factory based on the standard JSSE trust material * ({@code cacerts} file in the security properties directory). System properties Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Args.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Args.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Args.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Args.java Fri Mar 11 02:45:53 2016 @@ -31,6 +31,10 @@ import java.util.Collection; public class Args { + private Args() { + // Do not allow utility class to be instantiated. + } + public static void check(final boolean expression, final String message) { if (!expression) { throw new IllegalArgumentException(message); Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Asserts.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Asserts.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Asserts.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/Asserts.java Fri Mar 11 02:45:53 2016 @@ -29,6 +29,10 @@ package org.apache.hc.core5.util; public class Asserts { + private Asserts() { + // Do not allow utility class to be instantiated. + } + public static void check(final boolean expression, final String message) { if (!expression) { throw new IllegalStateException(message); Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharsetUtils.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharsetUtils.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharsetUtils.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/CharsetUtils.java Fri Mar 11 02:45:53 2016 @@ -33,6 +33,10 @@ import java.nio.charset.UnsupportedChars public class CharsetUtils { + private CharsetUtils() { + // Do not allow utility class to be instantiated. + } + public static Charset lookup(final String name) { if (name == null) { return null; Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/NetUtils.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/NetUtils.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/NetUtils.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/NetUtils.java Fri Mar 11 02:45:53 2016 @@ -36,6 +36,10 @@ import java.net.SocketAddress; */ public final class NetUtils { + private NetUtils() { + // Do not allow utility class to be instantiated. + } + public static void formatAddress( final StringBuilder buffer, final SocketAddress socketAddress) { Modified: httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java?rev=1734489&r1=1734488&r2=1734489&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java (original) +++ httpcomponents/httpcore/trunk/httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java Fri Mar 11 02:45:53 2016 @@ -32,6 +32,10 @@ package org.apache.hc.core5.util; */ public final class TextUtils { + private TextUtils() { + // Do not allow utility class to be instantiated. + } + /** * Returns true if the parameter is null or of zero length */