Return-Path: X-Original-To: apmail-hc-commits-archive@www.apache.org Delivered-To: apmail-hc-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EC00018A43 for ; Wed, 27 Jan 2016 09:00:28 +0000 (UTC) Received: (qmail 49793 invoked by uid 500); 27 Jan 2016 09:00:28 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 49751 invoked by uid 500); 27 Jan 2016 09:00:28 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 49742 invoked by uid 99); 27 Jan 2016 09:00:28 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 09:00:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 6E072C2803 for ; Wed, 27 Jan 2016 09:00:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.799 X-Spam-Level: * X-Spam-Status: No, score=1.799 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id CHv7O7TrrJ7I for ; Wed, 27 Jan 2016 09:00:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTP id B5FA02059F for ; Wed, 27 Jan 2016 09:00:26 +0000 (UTC) Received: from svn01-us-west.apache.org (svn.apache.org [10.41.0.6]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C7572E050C for ; Wed, 27 Jan 2016 09:00:25 +0000 (UTC) Received: from svn01-us-west.apache.org (localhost [127.0.0.1]) by svn01-us-west.apache.org (ASF Mail Server at svn01-us-west.apache.org) with ESMTP id A3FBB3A0873 for ; Wed, 27 Jan 2016 09:00:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1726967 - in /httpcomponents/httpclient/branches/4.5.x: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/ httpclient-win/src/main/java/org/apache/http/impl/auth/win/ httpclient/src/main/java-deprecated/org/apache/http/conn/... Date: Wed, 27 Jan 2016 09:00:25 -0000 To: commits@hc.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20160127090025.A3FBB3A0873@svn01-us-west.apache.org> Author: ggregory Date: Wed Jan 27 09:00:25 2016 New Revision: 1726967 URL: http://svn.apache.org/viewvc?rev=1726967&view=rev Log: Add final modifier to private fields. Modified: httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java Modified: httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java?rev=1726967&r1=1726966&r2=1726967&view=diff ============================================================================== --- httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java (original) +++ httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java Wed Jan 27 09:00:25 2016 @@ -164,8 +164,8 @@ public class CacheConfig implements Clon private long maxObjectSize; private int maxCacheEntries; private int maxUpdateRetries; - private boolean allow303Caching; - private boolean weakETagOnPutDeleteAllowed; + private final boolean allow303Caching; + private final boolean weakETagOnPutDeleteAllowed; private boolean heuristicCachingEnabled; private float heuristicCoefficient; private long heuristicDefaultLifetime; Modified: httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java?rev=1726967&r1=1726966&r2=1726967&view=diff ============================================================================== --- httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java (original) +++ httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java Wed Jan 27 09:00:25 2016 @@ -45,7 +45,7 @@ import org.apache.http.protocol.HttpCont @Immutable public class WindowsNTLMSchemeFactory implements AuthSchemeProvider { - private String servicePrincipalName; + private final String servicePrincipalName; public WindowsNTLMSchemeFactory(final String servicePrincipalName) { super(); Modified: httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java?rev=1726967&r1=1726966&r2=1726967&view=diff ============================================================================== --- httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java (original) +++ httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java Wed Jan 27 09:00:25 2016 @@ -45,7 +45,7 @@ import org.apache.http.protocol.HttpCont @Immutable public class WindowsNegotiateSchemeFactory implements AuthSchemeProvider { - private String servicePrincipalName; + private final String servicePrincipalName; public WindowsNegotiateSchemeFactory(final String servicePrincipalName) { super(); Modified: httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java?rev=1726967&r1=1726966&r2=1726967&view=diff ============================================================================== --- httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java (original) +++ httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java Wed Jan 27 09:00:25 2016 @@ -68,8 +68,8 @@ public class SSLContextBuilder { static final String SSL = "SSL"; private String protocol; - private Set keymanagers; - private Set trustmanagers; + private final Set keymanagers; + private final Set trustmanagers; private SecureRandom secureRandom; public SSLContextBuilder() { Modified: httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java?rev=1726967&r1=1726966&r2=1726967&view=diff ============================================================================== --- httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java (original) +++ httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java Wed Jan 27 09:00:25 2016 @@ -39,7 +39,7 @@ import java.util.zip.ZipException; */ public class DeflateInputStream extends InputStream { - private InputStream sourceStream; + private final InputStream sourceStream; public DeflateInputStream(final InputStream wrapped) throws IOException {