hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1726967 - in /httpcomponents/httpclient/branches/4.5.x: httpclient-cache/src/main/java/org/apache/http/impl/client/cache/ httpclient-win/src/main/java/org/apache/http/impl/auth/win/ httpclient/src/main/java-deprecated/org/apache/http/conn/...
Date Wed, 27 Jan 2016 09:00:25 GMT
Author: ggregory
Date: Wed Jan 27 09:00:25 2016
New Revision: 1726967

URL: http://svn.apache.org/viewvc?rev=1726967&view=rev
Log:
Add final modifier to private fields.

Modified:
    httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java
    httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java
    httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java
    httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java
    httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java

Modified: httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java?rev=1726967&r1=1726966&r2=1726967&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java
(original)
+++ httpcomponents/httpclient/branches/4.5.x/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/CacheConfig.java
Wed Jan 27 09:00:25 2016
@@ -164,8 +164,8 @@ public class CacheConfig implements Clon
     private long maxObjectSize;
     private int maxCacheEntries;
     private int maxUpdateRetries;
-    private boolean allow303Caching;
-    private boolean weakETagOnPutDeleteAllowed;
+    private final boolean allow303Caching;
+    private final boolean weakETagOnPutDeleteAllowed;
     private boolean heuristicCachingEnabled;
     private float heuristicCoefficient;
     private long heuristicDefaultLifetime;

Modified: httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java?rev=1726967&r1=1726966&r2=1726967&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java
(original)
+++ httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNTLMSchemeFactory.java
Wed Jan 27 09:00:25 2016
@@ -45,7 +45,7 @@ import org.apache.http.protocol.HttpCont
 @Immutable
 public class WindowsNTLMSchemeFactory implements AuthSchemeProvider {
 
-    private String servicePrincipalName;
+    private final String servicePrincipalName;
 
     public WindowsNTLMSchemeFactory(final String servicePrincipalName) {
         super();

Modified: httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java?rev=1726967&r1=1726966&r2=1726967&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java
(original)
+++ httpcomponents/httpclient/branches/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/auth/win/WindowsNegotiateSchemeFactory.java
Wed Jan 27 09:00:25 2016
@@ -45,7 +45,7 @@ import org.apache.http.protocol.HttpCont
 @Immutable
 public class WindowsNegotiateSchemeFactory implements AuthSchemeProvider {
 
-    private String servicePrincipalName;
+    private final String servicePrincipalName;
 
     public WindowsNegotiateSchemeFactory(final String servicePrincipalName) {
         super();

Modified: httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java?rev=1726967&r1=1726966&r2=1726967&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java
(original)
+++ httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java-deprecated/org/apache/http/conn/ssl/SSLContextBuilder.java
Wed Jan 27 09:00:25 2016
@@ -68,8 +68,8 @@ public class SSLContextBuilder {
     static final String SSL   = "SSL";
 
     private String protocol;
-    private Set<KeyManager> keymanagers;
-    private Set<TrustManager> trustmanagers;
+    private final Set<KeyManager> keymanagers;
+    private final Set<TrustManager> trustmanagers;
     private SecureRandom secureRandom;
 
     public SSLContextBuilder() {

Modified: httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java?rev=1726967&r1=1726966&r2=1726967&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java
(original)
+++ httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/client/entity/DeflateInputStream.java
Wed Jan 27 09:00:25 2016
@@ -39,7 +39,7 @@ import java.util.zip.ZipException;
  */
 public class DeflateInputStream extends InputStream {
 
-    private InputStream sourceStream;
+    private final InputStream sourceStream;
 
     public DeflateInputStream(final InputStream wrapped) throws IOException {
 



Mime
View raw message