hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1726957 - in /httpcomponents/httpclient/branches/4.5.x: RELEASE_NOTES.txt httpclient/src/main/java/org/apache/http/impl/auth/NTLMEngineImpl.java
Date Wed, 27 Jan 2016 08:34:23 GMT
Author: ggregory
Date: Wed Jan 27 08:34:23 2016
New Revision: 1726957

URL: http://svn.apache.org/viewvc?rev=1726957&view=rev
Log:
[HTTPCLIENT-1715] NTLMEngineImpl.Type1Message not thread safe but declared as a constant.

Modified:
    httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt
    httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/impl/auth/NTLMEngineImpl.java

Modified: httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt?rev=1726957&r1=1726956&r2=1726957&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt (original)
+++ httpcomponents/httpclient/branches/4.5.x/RELEASE_NOTES.txt Wed Jan 27 08:34:23 2016
@@ -11,6 +11,8 @@ Changelog:
 * [HTTPCLIENT-1714] Add HttpClientBuilder.setDnsResolver(DnsResolver).
   Contributed by Alexis Thaveau <alexis.thaveau at gmail.com>
 
+* [HTTPCLIENT-1715] NTLMEngineImpl.Type1Message not thread safe but declared as a constant.
+  Contributed by Olivier Lafontaine <olafontaine at gmail.com>, Gary Gregory <ggregory
at apache.org>
 
 
 Release 4.5.1

Modified: httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/impl/auth/NTLMEngineImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/impl/auth/NTLMEngineImpl.java?rev=1726957&r1=1726956&r2=1726957&view=diff
==============================================================================
--- httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/impl/auth/NTLMEngineImpl.java
(original)
+++ httpcomponents/httpclient/branches/4.5.x/httpclient/src/main/java/org/apache/http/impl/auth/NTLMEngineImpl.java
Wed Jan 27 08:34:23 2016
@@ -98,7 +98,7 @@ final class NTLMEngineImpl implements NT
         SIGNATURE[bytesWithoutNull.length] = (byte) 0x00;
     }
 
-    private static final Type1Message TYPE_1_MESSAGE = new Type1Message();
+    private static final String TYPE_1_MESSAGE = new Type1Message().getResponse();
 
     /**
      * Returns the response for the given message.
@@ -145,7 +145,7 @@ final class NTLMEngineImpl implements NT
     static String getType1Message(final String host, final String domain) throws NTLMEngineException
{
         // For compatibility reason do not include domain and host in type 1 message
         //return new Type1Message(domain, host).getResponse();
-        return TYPE_1_MESSAGE.getResponse();
+        return TYPE_1_MESSAGE;
     }
 
     /**



Mime
View raw message