Return-Path: X-Original-To: apmail-hc-commits-archive@www.apache.org Delivered-To: apmail-hc-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 833DCC6AD for ; Wed, 12 Nov 2014 19:17:05 +0000 (UTC) Received: (qmail 45298 invoked by uid 500); 12 Nov 2014 19:17:05 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 45259 invoked by uid 500); 12 Nov 2014 19:17:05 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 45249 invoked by uid 99); 12 Nov 2014 19:17:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2014 19:17:05 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2014 19:16:43 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id D403423888E4 for ; Wed, 12 Nov 2014 19:16:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1638960 - /httpcomponents/httpcore/branches/4.4.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java Date: Wed, 12 Nov 2014 19:16:11 -0000 To: commits@hc.apache.org From: olegk@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20141112191611.D403423888E4@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: olegk Date: Wed Nov 12 19:16:11 2014 New Revision: 1638960 URL: http://svn.apache.org/r1638960 Log: IOSessionImpl: use volatiles for time access functions instead of synchronized access Contributed by Dmitry Potapov Modified: httpcomponents/httpcore/branches/4.4.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java Modified: httpcomponents/httpcore/branches/4.4.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/branches/4.4.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java?rev=1638960&r1=1638959&r2=1638960&view=diff ============================================================================== --- httpcomponents/httpcore/branches/4.4.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java (original) +++ httpcomponents/httpcore/branches/4.4.x/httpcore-nio/src/main/java/org/apache/http/impl/nio/reactor/IOSessionImpl.java Wed Nov 12 19:16:11 2014 @@ -65,9 +65,9 @@ public class IOSessionImpl implements IO private final long startedTime; - private long lastReadTime; - private long lastWriteTime; - private long lastAccessTime; + private volatile long lastReadTime; + private volatile long lastWriteTime; + private volatile long lastAccessTime; /** * Creates new instance of IOSessionImpl. @@ -207,7 +207,7 @@ public class IOSessionImpl implements IO } @Override - public synchronized void setSocketTimeout(final int timeout) { + public void setSocketTimeout(final int timeout) { this.socketTimeout = timeout; this.lastAccessTime = System.currentTimeMillis(); } @@ -282,29 +282,29 @@ public class IOSessionImpl implements IO this.attributes.put(name, obj); } - public synchronized long getStartedTime() { + public long getStartedTime() { return this.startedTime; } - public synchronized long getLastReadTime() { + public long getLastReadTime() { return this.lastReadTime; } - public synchronized long getLastWriteTime() { + public long getLastWriteTime() { return this.lastWriteTime; } - public synchronized long getLastAccessTime() { + public long getLastAccessTime() { return this.lastAccessTime; } - synchronized void resetLastRead() { + void resetLastRead() { final long now = System.currentTimeMillis(); this.lastReadTime = now; this.lastAccessTime = now; } - synchronized void resetLastWrite() { + void resetLastWrite() { final long now = System.currentTimeMillis(); this.lastWriteTime = now; this.lastAccessTime = now;