Return-Path: X-Original-To: apmail-hc-commits-archive@www.apache.org Delivered-To: apmail-hc-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3E7581121E for ; Fri, 8 Aug 2014 13:23:09 +0000 (UTC) Received: (qmail 92187 invoked by uid 500); 8 Aug 2014 13:23:09 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 92141 invoked by uid 500); 8 Aug 2014 13:23:09 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 92127 invoked by uid 99); 8 Aug 2014 13:23:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2014 13:23:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2014 13:23:06 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id F19B623889CB for ; Fri, 8 Aug 2014 13:22:43 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1616752 - in /httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message: BasicHeaderValueParser.java TokenParser.java Date: Fri, 08 Aug 2014 13:22:43 -0000 To: commits@hc.apache.org From: olegk@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140808132243.F19B623889CB@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: olegk Date: Fri Aug 8 13:22:43 2014 New Revision: 1616752 URL: http://svn.apache.org/r1616752 Log: Javadoc updates Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueParser.java httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueParser.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueParser.java?rev=1616752&r1=1616751&r2=1616752&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueParser.java (original) +++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueParser.java Fri Aug 8 13:22:43 2014 @@ -64,6 +64,9 @@ public class BasicHeaderValueParser impl private final static char PARAM_DELIMITER = ';'; private final static char ELEM_DELIMITER = ','; + + // IMPORTANT! + // These private static variables must be treated as immutable and never exposed outside this class private static final BitSet TOKEN_DELIMS = TokenParser.INIT_BITSET('=', PARAM_DELIMITER, ELEM_DELIMITER); private static final BitSet VALUE_DELIMS = TokenParser.INIT_BITSET(PARAM_DELIMITER, ELEM_DELIMITER); Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java?rev=1616752&r1=1616751&r2=1616752&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java (original) +++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java Fri Aug 8 13:22:43 2014 @@ -29,6 +29,7 @@ package org.apache.http.message; import java.util.BitSet; +import org.apache.http.annotation.Immutable; import org.apache.http.util.CharArrayBuffer; /** @@ -39,6 +40,7 @@ import org.apache.http.util.CharArrayBuf * * @since 4.4 */ +@Immutable public class TokenParser { public static BitSet INIT_BITSET(final int ... b) {