hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ol...@apache.org
Subject svn commit: r1616430 - /httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java
Date Thu, 07 Aug 2014 07:47:00 GMT
Author: olegk
Date: Thu Aug  7 07:46:59 2014
New Revision: 1616430

URL: http://svn.apache.org/r1616430
Log:
Code optimizations and cleanups per Sebb's comments

Modified:
    httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java?rev=1616430&r1=1616429&r2=1616430&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java
(original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/TokenParser.java
Thu Aug  7 07:46:59 2014
@@ -36,11 +36,13 @@ import org.apache.http.util.CharArrayBuf
  * to produce near zero intermediate garbage and make no intermediate copies of input data.
  * <p>
  * This class is immutable and thread safe.
+ *
+ * @since 4.4
  */
 public class TokenParser {
 
     public static BitSet INIT_BITSET(final int ... b) {
-        final BitSet bitset = new BitSet(b.length);
+        final BitSet bitset = new BitSet();
         for (final int aB : b) {
             bitset.set(aB);
         }
@@ -48,16 +50,22 @@ public class TokenParser {
     }
 
     /** US-ASCII CR, carriage return (13) */
-    public static final int CR = '\r';
+    public static final char CR = '\r';
 
     /** US-ASCII LF, line feed (10) */
-    public static final int LF = '\n';
+    public static final char LF = '\n';
 
     /** US-ASCII SP, space (32) */
-    public static final int SP = ' ';
+    public static final char SP = ' ';
 
     /** US-ASCII HT, horizontal-tab (9) */
-    public static final int HT = '\t';
+    public static final char HT = '\t';
+
+    /** Double quote */
+    public static final char DQUOTE = '\"';
+
+    /** Backward slash / escape character */
+    public static final char ESCAPE = '\\';
 
     public static boolean isWhitespace(final char ch) {
         return ch == SP || ch == HT || ch == CR || ch == LF;
@@ -85,7 +93,7 @@ public class TokenParser {
                 skipWhiteSpace(buf, cursor);
                 whitespace = true;
             } else {
-                if (dst.length() > 0 && whitespace) {
+                if (whitespace && dst.length() > 0) {
                     dst.append(' ');
                 }
                 copyContent(buf, cursor, delimiters, dst);
@@ -115,14 +123,14 @@ public class TokenParser {
             } else if (isWhitespace(current)) {
                 skipWhiteSpace(buf, cursor);
                 whitespace = true;
-            } else if (current == '\"') {
-                if (dst.length() > 0 && whitespace) {
+            } else if (current == DQUOTE) {
+                if (whitespace && dst.length() > 0) {
                     dst.append(' ');
                 }
                 copyQuotedContent(buf, cursor, dst);
                 whitespace = false;
             } else {
-                if (dst.length() > 0 && whitespace) {
+                if (whitespace && dst.length() > 0) {
                     dst.append(' ');
                 }
                 copyUnquotedContent(buf, cursor, delimiters, dst);
@@ -199,7 +207,7 @@ public class TokenParser {
         for (int i = indexFrom; i < indexTo; i++) {
             final char current = buf.charAt(i);
             if ((delimiters != null && delimiters.get(current))
-                    || isWhitespace(current) || current == '\"') {
+                    || isWhitespace(current) || current == DQUOTE) {
                 break;
             } else {
                 pos++;
@@ -225,7 +233,7 @@ public class TokenParser {
         int indexFrom = cursor.getPos();
         final int indexTo = cursor.getUpperBound();
         char current = buf.charAt(pos);
-        if (current != '\"') {
+        if (current != DQUOTE) {
             return;
         }
         pos++;
@@ -234,19 +242,19 @@ public class TokenParser {
         for (int i = indexFrom; i < indexTo; i++, pos++) {
             current = buf.charAt(i);
             if (escaped) {
-                if (current != '\"' && current != '\\') {
-                    dst.append('\\');
+                if (current != DQUOTE && current != ESCAPE) {
+                    dst.append(ESCAPE);
                 }
                 dst.append(current);
                 escaped = false;
             } else {
-                if (current == '\"') {
+                if (current == DQUOTE) {
                     pos++;
                     break;
                 }
-                if (current == '\\') {
+                if (current == ESCAPE) {
                     escaped = true;
-                } else if (current != '\r' && current != '\n') {
+                } else if (current != CR && current != LF) {
                     dst.append(current);
                 }
             }



Mime
View raw message