Return-Path: X-Original-To: apmail-hc-commits-archive@www.apache.org Delivered-To: apmail-hc-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8326F11147 for ; Mon, 23 Jun 2014 17:46:54 +0000 (UTC) Received: (qmail 49089 invoked by uid 500); 23 Jun 2014 17:46:54 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 49051 invoked by uid 500); 23 Jun 2014 17:46:54 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 49042 invoked by uid 99); 23 Jun 2014 17:46:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jun 2014 17:46:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jun 2014 17:46:55 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 6235F2388980 for ; Mon, 23 Jun 2014 17:46:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1604892 - in /httpcomponents/httpclient/trunk: httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ httpclient/src/main/java/org/apache/http/impl/auth/ httpclient/src/test/java/org/apache/http/conn/ssl/ Date: Mon, 23 Jun 2014 17:46:30 -0000 To: commits@hc.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20140623174630.6235F2388980@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Mon Jun 23 17:46:29 2014 New Revision: 1604892 URL: http://svn.apache.org/r1604892 Log: Add TODOs for code that needs looking at Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java?rev=1604892&r1=1604891&r2=1604892&view=diff ============================================================================== --- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java (original) +++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolRequirements.java Mon Jun 23 17:46:29 2014 @@ -6049,7 +6049,7 @@ public class TestProtocolRequirements ex // received-by if (!Pattern.matches(tokenRegexp, parts[1])) { // host : port - new HttpHost(parts[1]); + new HttpHost(parts[1]); // TODO - unused - is this a test bug? else use Assert.assertNotNull } // comment Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java?rev=1604892&r1=1604891&r2=1604892&view=diff ============================================================================== --- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java (original) +++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java Mon Jun 23 17:46:29 2014 @@ -177,7 +177,7 @@ public class HttpAuthenticator { final HttpContext context) throws HttpException, IOException { AuthScheme authScheme = authState.getAuthScheme(); Credentials creds = authState.getCredentials(); - switch (authState.getState()) { + switch (authState.getState()) { // TODO add UNCHALLENGED and HANDSHAKE cases case FAILURE: return; case SUCCESS: Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java?rev=1604892&r1=1604891&r2=1604892&view=diff ============================================================================== --- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java (original) +++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/conn/ssl/TestSSLSocketFactory.java Mon Jun 23 17:46:29 2014 @@ -176,6 +176,7 @@ public class TestSSLSocketFactory { @Test public void testClientAuthSSLAliasChoice() throws Exception { + // TODO unused - is there a bug in the test? final PrivateKeyStrategy aliasStrategy = new PrivateKeyStrategy() { @Override