hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ol...@apache.org
Subject svn commit: r1593923 - /httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java
Date Mon, 12 May 2014 11:12:49 GMT
Author: olegk
Date: Mon May 12 11:12:48 2014
New Revision: 1593923

URL: http://svn.apache.org/r1593923
Log:
Use a separate setter for shared connection manager flag

Modified:
    httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java

Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java?rev=1593923&r1=1593922&r2=1593923&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java
Mon May 12 11:12:48 2014
@@ -334,25 +334,25 @@ public class HttpClientBuilder {
      */
     public final HttpClientBuilder setConnectionManager(
             final HttpClientConnectionManager connManager) {
-        return setConnectionManager(connManager, false);
+        this.connManager = connManager;
+        return this;
     }
 
     /**
-     * Assigns {@link HttpClientConnectionManager} instance.
+     * Defines the connection manager is to be shared by multiple
+     * client instances.
      * <p/>
      * If the connection manager is shared its life-cycle is expected
      * to be managed by the caller and it will not be shut down
      * if the client is closed.
      *
-     * @param connManager connection manager
      * @param shared defines whether or not the connection manager can be shared
      *  by multiple clients.
      *
      * @since 4.4
      */
-    public final HttpClientBuilder setConnectionManager(
-            final HttpClientConnectionManager connManager, final boolean shared) {
-        this.connManager = connManager;
+    public final HttpClientBuilder setConnectionManagerShared(
+            final boolean shared) {
         this.connManagerShared = shared;
         return this;
     }



Mime
View raw message