hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ol...@apache.org
Subject svn commit: r1485210 - in /httpcomponents/httpclient/trunk: RELEASE_NOTES.txt httpclient/src/main/java/org/apache/http/impl/auth/DigestScheme.java
Date Wed, 22 May 2013 13:49:31 GMT
Author: olegk
Date: Wed May 22 13:49:31 2013
New Revision: 1485210

URL: http://svn.apache.org/r1485210
Log:
HTTPCLIENT-1354: do not quote algorithm parameter in DIGEST auth response

Modified:
    httpcomponents/httpclient/trunk/RELEASE_NOTES.txt
    httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/DigestScheme.java

Modified: httpcomponents/httpclient/trunk/RELEASE_NOTES.txt
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/RELEASE_NOTES.txt?rev=1485210&r1=1485209&r2=1485210&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/RELEASE_NOTES.txt (original)
+++ httpcomponents/httpclient/trunk/RELEASE_NOTES.txt Wed May 22 13:49:31 2013
@@ -1,6 +1,9 @@
 Changes since release 4.3 BETA1
 -------------------
 
+* [HTTPCLIENT-1354] do not quote algorithm parameter in DIGEST auth response.
+  Contributed by Oleg Kalnichevski <olegk at apache.org>
+
 * [HTTPCLIENT-1351] Preserve last request URI in the execution context. 
   Contributed by James Leigh <james at 3roundstones.com> 
 

Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/DigestScheme.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/DigestScheme.java?rev=1485210&r1=1485209&r2=1485210&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/DigestScheme.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/auth/DigestScheme.java
Wed May 22 13:49:31 2013
@@ -423,7 +423,9 @@ public class DigestScheme extends RFC261
             if (i > 0) {
                 buffer.append(", ");
             }
-            final boolean noQuotes = "nc".equals(param.getName()) || "qop".equals(param.getName());
+            final String name = param.getName();
+            final boolean noQuotes = ("nc".equals(name) || "qop".equals(name)
+                    || "algorithm".equals(name));
             BasicHeaderValueFormatter.INSTANCE.formatNameValuePair(buffer, param, !noQuotes);
         }
         return new BufferedHeader(buffer);
@@ -476,7 +478,7 @@ public class DigestScheme extends RFC261
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        final StringBuilder builder = new StringBuilder();
         builder.append("DIGEST [complete=").append(complete)
                 .append(", nonce=").append(lastNonce)
                 .append(", nc=").append(nounceCount)



Mime
View raw message