hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1433569 [11/12] - in /httpcomponents: benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/ benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/ benchmark/httpcore/trunk/src/main/java/org/apache/http/bench...
Date Tue, 15 Jan 2013 18:30:06 GMT
Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java Tue Jan 15 18:29:58 2013
@@ -81,7 +81,7 @@ public class ContentLengthInputStream ex
      * @param contentLength The maximum number of bytes that can be read from
      * the stream. Subsequent read operations will return -1.
      */
-    public ContentLengthInputStream(final SessionInputBuffer in, long contentLength) {
+    public ContentLengthInputStream(final SessionInputBuffer in, final long contentLength) {
         super();
         this.in = Args.notNull(in, "Session input buffer");
         this.contentLength = Args.notNegative(contentLength, "Content length");
@@ -162,7 +162,7 @@ public class ContentLengthInputStream ex
      * @throws java.io.IOException Should an error occur on the wrapped stream.
      */
     @Override
-    public int read (byte[] b, int off, int len) throws java.io.IOException {
+    public int read (final byte[] b, final int off, int len) throws java.io.IOException {
         if (closed) {
             throw new IOException("Attempted read from closed stream.");
         }
@@ -195,7 +195,7 @@ public class ContentLengthInputStream ex
      * @see java.io.InputStream#read(byte[])
      */
     @Override
-    public int read(byte[] b) throws IOException {
+    public int read(final byte[] b) throws IOException {
         return read(b, 0, b.length);
     }
 
@@ -208,7 +208,7 @@ public class ContentLengthInputStream ex
      * @see InputStream#skip(long)
      */
     @Override
-    public long skip(long n) throws IOException {
+    public long skip(final long n) throws IOException {
         if (n <= 0) {
             return 0;
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthOutputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthOutputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthOutputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthOutputStream.java Tue Jan 15 18:29:58 2013
@@ -77,7 +77,7 @@ public class ContentLengthOutputStream e
      *
      * @since 4.0
      */
-    public ContentLengthOutputStream(final SessionOutputBuffer out, long contentLength) {
+    public ContentLengthOutputStream(final SessionOutputBuffer out, final long contentLength) {
         super();
         this.out = Args.notNull(out, "Session output buffer");
         this.contentLength = Args.notNegative(contentLength, "Content length");
@@ -102,7 +102,7 @@ public class ContentLengthOutputStream e
     }
 
     @Override
-    public void write(byte[] b, int off, int len) throws IOException {
+    public void write(final byte[] b, final int off, int len) throws IOException {
         if (this.closed) {
             throw new IOException("Attempted write to closed stream.");
         }
@@ -117,12 +117,12 @@ public class ContentLengthOutputStream e
     }
 
     @Override
-    public void write(byte[] b) throws IOException {
+    public void write(final byte[] b) throws IOException {
         write(b, 0, b.length);
     }
 
     @Override
-    public void write(int b) throws IOException {
+    public void write(final int b) throws IOException {
         if (this.closed) {
             throw new IOException("Attempted write to closed stream.");
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/HttpTransportMetricsImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/HttpTransportMetricsImpl.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/HttpTransportMetricsImpl.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/HttpTransportMetricsImpl.java Tue Jan 15 18:29:58 2013
@@ -48,11 +48,11 @@ public class HttpTransportMetricsImpl im
         return this.bytesTransferred;
     }
 
-    public void setBytesTransferred(long count) {
+    public void setBytesTransferred(final long count) {
         this.bytesTransferred = count;
     }
 
-    public void incrementBytesTransferred(long count) {
+    public void incrementBytesTransferred(final long count) {
         this.bytesTransferred += count;
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/IdentityInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/IdentityInputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/IdentityInputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/IdentityInputStream.java Tue Jan 15 18:29:58 2013
@@ -88,7 +88,7 @@ public class IdentityInputStream extends
     }
 
     @Override
-    public int read(final byte[] b, int off, int len) throws IOException {
+    public int read(final byte[] b, final int off, final int len) throws IOException {
         if (this.closed) {
             return -1;
         } else {

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/IdentityOutputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/IdentityOutputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/IdentityOutputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/IdentityOutputStream.java Tue Jan 15 18:29:58 2013
@@ -81,7 +81,7 @@ public class IdentityOutputStream extend
     }
 
     @Override
-    public void write(byte[] b, int off, int len) throws IOException {
+    public void write(final byte[] b, final int off, final int len) throws IOException {
         if (this.closed) {
             throw new IOException("Attempted write to closed stream.");
         }
@@ -89,12 +89,12 @@ public class IdentityOutputStream extend
     }
 
     @Override
-    public void write(byte[] b) throws IOException {
+    public void write(final byte[] b) throws IOException {
         write(b, 0, b.length);
     }
 
     @Override
-    public void write(int b) throws IOException {
+    public void write(final int b) throws IOException {
         if (this.closed) {
             throw new IOException("Attempted write to closed stream.");
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SessionInputBufferImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SessionInputBufferImpl.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SessionInputBufferImpl.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SessionInputBufferImpl.java Tue Jan 15 18:29:58 2013
@@ -89,8 +89,8 @@ public class SessionInputBufferImpl impl
      */
     public SessionInputBufferImpl(
             final HttpTransportMetricsImpl metrics,
-            int buffersize,
-            int minChunkLimit,
+            final int buffersize,
+            final int minChunkLimit,
             final MessageConstraints constraints,
             final CharsetDecoder chardecoder) {
         Args.notNull(metrics, "HTTP transport metrcis");
@@ -125,7 +125,7 @@ public class SessionInputBufferImpl impl
         return capacity() - length();
     }
 
-    private int streamRead(final byte[] b, int off, int len) throws IOException {
+    private int streamRead(final byte[] b, final int off, final int len) throws IOException {
         Asserts.notNull(this.instream, "Input stream");
         return this.instream.read(b, off, len);
     }
@@ -168,7 +168,7 @@ public class SessionInputBufferImpl impl
         return this.buffer[this.bufferpos++] & 0xff;
     }
 
-    public int read(final byte[] b, int off, int len) throws IOException {
+    public int read(final byte[] b, final int off, final int len) throws IOException {
         if (b == null) {
             return 0;
         }
@@ -376,7 +376,7 @@ public class SessionInputBufferImpl impl
         }
     }
 
-    public boolean isDataAvailable(int timeout) throws IOException {
+    public boolean isDataAvailable(final int timeout) throws IOException {
         return hasBufferedData();
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SessionOutputBufferImpl.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SessionOutputBufferImpl.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SessionOutputBufferImpl.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SessionOutputBufferImpl.java Tue Jan 15 18:29:58 2013
@@ -82,8 +82,8 @@ public class SessionOutputBufferImpl imp
      */
     public SessionOutputBufferImpl(
             final HttpTransportMetricsImpl metrics,
-            int buffersize,
-            int minChunkLimit,
+            final int buffersize,
+            final int minChunkLimit,
             final CharsetEncoder charencoder) {
         super();
         Args.positive(buffersize, "Buffer size");
@@ -114,7 +114,7 @@ public class SessionOutputBufferImpl imp
         return capacity() - length();
     }
 
-    private void streamWrite(final byte[] b, int off, int len) throws IOException {
+    private void streamWrite(final byte[] b, final int off, final int len) throws IOException {
         Asserts.notNull(outstream, "Output stream");
         this.outstream.write(b, off, len);
     }
@@ -139,7 +139,7 @@ public class SessionOutputBufferImpl imp
         flushStream();
     }
 
-    public void write(final byte[] b, int off, int len) throws IOException {
+    public void write(final byte[] b, final int off, final int len) throws IOException {
         if (b == null) {
             return;
         }
@@ -171,7 +171,7 @@ public class SessionOutputBufferImpl imp
         write(b, 0, b.length);
     }
 
-    public void write(int b) throws IOException {
+    public void write(final int b) throws IOException {
         if (this.buffer.isFull()) {
             flushBuffer();
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SocketInputBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SocketInputBuffer.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SocketInputBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/SocketInputBuffer.java Tue Jan 15 18:29:58 2013
@@ -86,7 +86,7 @@ public class SocketInputBuffer extends A
         return i;
     }
 
-    public boolean isDataAvailable(int timeout) throws IOException {
+    public boolean isDataAvailable(final int timeout) throws IOException {
         boolean result = hasBufferedData();
         if (!result) {
             int oldtimeout = this.socket.getSoTimeout();

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/AbstractHttpMessage.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/AbstractHttpMessage.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/AbstractHttpMessage.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/AbstractHttpMessage.java Tue Jan 15 18:29:58 2013
@@ -64,7 +64,7 @@ public abstract class AbstractHttpMessag
     }
 
     // non-javadoc, see interface HttpMessage
-    public boolean containsHeader(String name) {
+    public boolean containsHeader(final String name) {
         return this.headergroup.containsHeader(name);
     }
 
@@ -139,7 +139,7 @@ public abstract class AbstractHttpMessag
     }
 
     // non-javadoc, see interface HttpMessage
-    public HeaderIterator headerIterator(String name) {
+    public HeaderIterator headerIterator(final String name) {
         return this.headergroup.iterator(name);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderElement.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderElement.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderElement.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderElement.java Tue Jan 15 18:29:58 2013
@@ -93,7 +93,7 @@ public class BasicHeaderElement implemen
         return this.parameters.length;
     }
 
-    public NameValuePair getParameter(int index) {
+    public NameValuePair getParameter(final int index) {
         // ArrayIndexOutOfBoundsException is appropriate
         return this.parameters[index];
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderIterator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderIterator.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderIterator.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderIterator.java Tue Jan 15 18:29:58 2013
@@ -73,7 +73,7 @@ public class BasicHeaderIterator impleme
      * @param name      the name of the headers over which to iterate, or
      *                  <code>null</code> for any
      */
-    public BasicHeaderIterator(Header[] headers, String name) {
+    public BasicHeaderIterator(final Header[] headers, final String name) {
         super();
         this.allHeaders = Args.notNull(headers, "Header array");
         this.headerName = name;
@@ -113,7 +113,7 @@ public class BasicHeaderIterator impleme
      * @return  <code>true</code> if the header should be part of the
      *          iteration, <code>false</code> to skip
      */
-    protected boolean filterHeader(int index) {
+    protected boolean filterHeader(final int index) {
         return (this.headerName == null) ||
             this.headerName.equalsIgnoreCase(this.allHeaders[index].getName());
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueFormatter.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueFormatter.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueFormatter.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHeaderValueFormatter.java Tue Jan 15 18:29:58 2013
@@ -154,7 +154,7 @@ public class BasicHeaderValueFormatter i
      */
     public final static
         String formatHeaderElement(final HeaderElement elem,
-                                   boolean quote,
+                                   final boolean quote,
                                    HeaderValueFormatter formatter) {
         if (formatter == null) {
 			formatter = BasicHeaderValueFormatter.INSTANCE;
@@ -251,8 +251,8 @@ public class BasicHeaderValueFormatter i
 
     // non-javadoc, see interface HeaderValueFormatter
     public CharArrayBuffer formatParameters(CharArrayBuffer buffer,
-                                            NameValuePair[] nvps,
-                                            boolean quote) {
+                                            final NameValuePair[] nvps,
+                                            final boolean quote) {
         Args.notNull(nvps, "Header parameter array");
         int len = estimateParametersLen(nvps);
         if (buffer == null) {
@@ -404,7 +404,7 @@ public class BasicHeaderValueFormatter i
      * @return  <code>true</code> if the character is a separator,
      *          <code>false</code> otherwise
      */
-    protected boolean isSeparator(char ch) {
+    protected boolean isSeparator(final char ch) {
         return SEPARATORS.indexOf(ch) >= 0;
     }
 
@@ -417,7 +417,7 @@ public class BasicHeaderValueFormatter i
      * @return  <code>true</code> if the character is unsafe,
      *          <code>false</code> otherwise
      */
-    protected boolean isUnsafe(char ch) {
+    protected boolean isUnsafe(final char ch) {
         return UNSAFE_CHARS.indexOf(ch) >= 0;
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java Tue Jan 15 18:29:58 2013
@@ -176,14 +176,14 @@ public class BasicHttpResponse extends A
     }
 
     // non-javadoc, see interface HttpResponse
-    public void setStatusCode(int code) {
+    public void setStatusCode(final int code) {
         Args.notNegative(code, "Status code");
         this.statusline = null;
         this.code = code;
     }
 
     // non-javadoc, see interface HttpResponse
-    public void setReasonPhrase(String reason) {
+    public void setReasonPhrase(final String reason) {
         this.statusline = null;
         this.reasonPhrase = reason;
     }
@@ -197,7 +197,7 @@ public class BasicHttpResponse extends A
      * @deprecated (4.3) use {@link DefaultHttpRequestFactory}
      */
     @Deprecated
-    public void setLocale(Locale locale) {
+    public void setLocale(final Locale locale) {
         this.locale =  Args.notNull(locale, "Locale");
         this.statusline = null;
     }
@@ -214,7 +214,7 @@ public class BasicHttpResponse extends A
      * @deprecated (4.3) use {@link DefaultHttpRequestFactory}
      */
     @Deprecated
-    protected String getReason(int code) {
+    protected String getReason(final int code) {
         return this.reasonCatalog != null ? this.reasonCatalog.getReason(code,
                 this.locale != null ? this.locale : Locale.getDefault()) : null;
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineFormatter.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineFormatter.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineFormatter.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineFormatter.java Tue Jan 15 18:29:58 2013
@@ -163,8 +163,8 @@ public class BasicLineFormatter implemen
 
 
     // non-javadoc, see interface LineFormatter
-    public CharArrayBuffer formatRequestLine(CharArrayBuffer buffer,
-                                             RequestLine reqline) {
+    public CharArrayBuffer formatRequestLine(final CharArrayBuffer buffer,
+                                             final RequestLine reqline) {
         Args.notNull(reqline, "Request line");
         CharArrayBuffer result = initBuffer(buffer);
         doFormatRequestLine(result, reqline);
@@ -279,8 +279,8 @@ public class BasicLineFormatter implemen
 
 
     // non-javadoc, see interface LineFormatter
-    public CharArrayBuffer formatHeader(CharArrayBuffer buffer,
-                                        Header header) {
+    public CharArrayBuffer formatHeader(final CharArrayBuffer buffer,
+                                        final Header header) {
         Args.notNull(header, "Header");
         CharArrayBuffer result = null;
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineParser.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineParser.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineParser.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicLineParser.java Tue Jan 15 18:29:58 2013
@@ -103,7 +103,7 @@ public class BasicLineParser implements 
 
 
     public final static
-        ProtocolVersion parseProtocolVersion(String value,
+        ProtocolVersion parseProtocolVersion(final String value,
                                              LineParser parser) throws ParseException {
         Args.notNull(value, "Value");
         if (parser == null) {
@@ -200,7 +200,7 @@ public class BasicLineParser implements 
      *
      * @return  the protocol version
      */
-    protected ProtocolVersion createProtocolVersion(int major, int minor) {
+    protected ProtocolVersion createProtocolVersion(final int major, final int minor) {
         return protocol.forVersion(major, minor);
     }
 
@@ -443,7 +443,7 @@ public class BasicLineParser implements 
 
 
     // non-javadoc, see interface LineParser
-    public Header parseHeader(CharArrayBuffer buffer)
+    public Header parseHeader(final CharArrayBuffer buffer)
         throws ParseException {
 
         // the actual parser code is in the constructor of BufferedHeader

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicListHeaderIterator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicListHeaderIterator.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicListHeaderIterator.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicListHeaderIterator.java Tue Jan 15 18:29:58 2013
@@ -81,7 +81,7 @@ public class BasicListHeaderIterator imp
      * @param name      the name of the headers over which to iterate, or
      *                  <code>null</code> for any
      */
-    public BasicListHeaderIterator(List<Header> headers, String name) {
+    public BasicListHeaderIterator(final List<Header> headers, final String name) {
         super();
         this.allHeaders = Args.notNull(headers, "Header list");
         this.headerName = name;
@@ -122,7 +122,7 @@ public class BasicListHeaderIterator imp
      * @return  <code>true</code> if the header should be part of the
      *          iteration, <code>false</code> to skip
      */
-    protected boolean filterHeader(int index) {
+    protected boolean filterHeader(final int index) {
         if (this.headerName == null) {
 			return true;
 		}

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicStatusLine.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicStatusLine.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicStatusLine.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicStatusLine.java Tue Jan 15 18:29:58 2013
@@ -64,7 +64,7 @@ public class BasicStatusLine implements 
      * @param reasonPhrase      the reason phrase to the status code, or
      *                          <code>null</code>
      */
-    public BasicStatusLine(final ProtocolVersion version, int statusCode,
+    public BasicStatusLine(final ProtocolVersion version, final int statusCode,
                            final String reasonPhrase) {
         super();
         this.protoVersion = Args.notNull(version, "Version");

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicTokenIterator.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicTokenIterator.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicTokenIterator.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicTokenIterator.java Tue Jan 15 18:29:58 2013
@@ -207,7 +207,7 @@ public class BasicTokenIterator implemen
      *
      * @return  a string representing the token identified by the arguments
      */
-    protected String createToken(String value, int start, int end) {
+    protected String createToken(final String value, final int start, final int end) {
         return value.substring(start, end);
     }
 
@@ -310,7 +310,7 @@ public class BasicTokenIterator implemen
      *          The behavior is undefined if <code>from</code> does not
      *          point to a token character in the current header value.
      */
-    protected int findTokenEnd(int from) {
+    protected int findTokenEnd(final int from) {
         Args.notNegative(from, "Search position");
         final int to = this.currentHeader.length();
         int end = from+1;
@@ -333,7 +333,7 @@ public class BasicTokenIterator implemen
      * @return  <code>true</code> if the character is a token separator,
      *          <code>false</code> otherwise
      */
-    protected boolean isTokenSeparator(char ch) {
+    protected boolean isTokenSeparator(final char ch) {
         return (ch == ',');
     }
 
@@ -349,7 +349,7 @@ public class BasicTokenIterator implemen
      * @return  <code>true</code> if the character is whitespace,
      *          <code>false</code> otherwise
      */
-    protected boolean isWhitespace(char ch) {
+    protected boolean isWhitespace(final char ch) {
 
         // we do not use Character.isWhitspace(ch) here, since that allows
         // many control characters which are not whitespace as per RFC 2616
@@ -369,7 +369,7 @@ public class BasicTokenIterator implemen
      * @return  <code>true</code> if the character is a valid token start,
      *          <code>false</code> otherwise
      */
-    protected boolean isTokenChar(char ch) {
+    protected boolean isTokenChar(final char ch) {
 
         // common sense extension of ALPHA + DIGIT
         if (Character.isLetterOrDigit(ch)) {
@@ -406,7 +406,7 @@ public class BasicTokenIterator implemen
      *
      * @return  <code>true</code> if the character is an HTTP separator
      */
-    protected boolean isHttpSeparator(char ch) {
+    protected boolean isHttpSeparator(final char ch) {
         return (HTTP_SEPARATORS.indexOf(ch) >= 0);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/HeaderGroup.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/HeaderGroup.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/HeaderGroup.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/HeaderGroup.java Tue Jan 15 18:29:58 2013
@@ -73,7 +73,7 @@ public class HeaderGroup implements Clon
      *
      * @param header the header to add
      */
-    public void addHeader(Header header) {
+    public void addHeader(final Header header) {
         if (header == null) {
             return;
         }
@@ -85,7 +85,7 @@ public class HeaderGroup implements Clon
      *
      * @param header the header to remove
      */
-    public void removeHeader(Header header) {
+    public void removeHeader(final Header header) {
         if (header == null) {
             return;
         }
@@ -99,7 +99,7 @@ public class HeaderGroup implements Clon
      * @param header the new header that should replace the first header with the same
      * name if present in the list.
      */
-    public void updateHeader(Header header) {
+    public void updateHeader(final Header header) {
         if (header == null) {
             return;
         }
@@ -120,7 +120,7 @@ public class HeaderGroup implements Clon
      *
      * @param headers the headers to set
      */
-    public void setHeaders(Header[] headers) {
+    public void setHeaders(final Header[] headers) {
         clear();
         if (headers == null) {
             return;
@@ -141,7 +141,7 @@ public class HeaderGroup implements Clon
      * @return a header with a condensed value or <code>null</code> if no
      * headers by the given name are present
      */
-    public Header getCondensedHeader(String name) {
+    public Header getCondensedHeader(final String name) {
         Header[] headers = getHeaders(name);
 
         if (headers.length == 0) {
@@ -170,7 +170,7 @@ public class HeaderGroup implements Clon
      *
      * @return an array of length >= 0
      */
-    public Header[] getHeaders(String name) {
+    public Header[] getHeaders(final String name) {
         List<Header> headersFound = new ArrayList<Header>();
 
         for (int i = 0; i < headers.size(); i++) {
@@ -191,7 +191,7 @@ public class HeaderGroup implements Clon
      * @param name the name of the header to get
      * @return the first header or <code>null</code>
      */
-    public Header getFirstHeader(String name) {
+    public Header getFirstHeader(final String name) {
         for (int i = 0; i < headers.size(); i++) {
             Header header = headers.get(i);
             if (header.getName().equalsIgnoreCase(name)) {
@@ -209,7 +209,7 @@ public class HeaderGroup implements Clon
      * @param name the name of the header to get
      * @return the last header or <code>null</code>
      */
-    public Header getLastHeader(String name) {
+    public Header getLastHeader(final String name) {
         // start at the end of the list and work backwards
         for (int i = headers.size() - 1; i >= 0; i--) {
             Header header = headers.get(i);
@@ -239,7 +239,7 @@ public class HeaderGroup implements Clon
      * @return <code>true</code> if at least one header with the name is
      * contained, <code>false</code> otherwise
      */
-    public boolean containsHeader(String name) {
+    public boolean containsHeader(final String name) {
         for (int i = 0; i < headers.size(); i++) {
             Header header = headers.get(i);
             if (header.getName().equalsIgnoreCase(name)) {

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/ParserCursor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/ParserCursor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/ParserCursor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/ParserCursor.java Tue Jan 15 18:29:58 2013
@@ -45,7 +45,7 @@ public class ParserCursor {
     private final int upperBound;
     private int pos;
 
-    public ParserCursor(int lowerBound, int upperBound) {
+    public ParserCursor(final int lowerBound, final int upperBound) {
         super();
         if (lowerBound < 0) {
             throw new IndexOutOfBoundsException("Lower bound cannot be negative");
@@ -70,7 +70,7 @@ public class ParserCursor {
         return this.pos;
     }
 
-    public void updatePos(int pos) {
+    public void updatePos(final int pos) {
         if (pos < this.lowerBound) {
             throw new IndexOutOfBoundsException("pos: "+pos+" < lowerBound: "+this.lowerBound);
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/AbstractHttpParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/AbstractHttpParams.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/AbstractHttpParams.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/AbstractHttpParams.java Tue Jan 15 18:29:58 2013
@@ -49,7 +49,7 @@ public abstract class AbstractHttpParams
         super();
     }
 
-    public long getLongParameter(final String name, long defaultValue) {
+    public long getLongParameter(final String name, final long defaultValue) {
         Object param = getParameter(name);
         if (param == null) {
             return defaultValue;
@@ -57,12 +57,12 @@ public abstract class AbstractHttpParams
         return ((Long)param).longValue();
     }
 
-    public HttpParams setLongParameter(final String name, long value) {
+    public HttpParams setLongParameter(final String name, final long value) {
         setParameter(name, new Long(value));
         return this;
     }
 
-    public int getIntParameter(final String name, int defaultValue) {
+    public int getIntParameter(final String name, final int defaultValue) {
         Object param = getParameter(name);
         if (param == null) {
             return defaultValue;
@@ -70,12 +70,12 @@ public abstract class AbstractHttpParams
         return ((Integer)param).intValue();
     }
 
-    public HttpParams setIntParameter(final String name, int value) {
+    public HttpParams setIntParameter(final String name, final int value) {
         setParameter(name, new Integer(value));
         return this;
     }
 
-    public double getDoubleParameter(final String name, double defaultValue) {
+    public double getDoubleParameter(final String name, final double defaultValue) {
         Object param = getParameter(name);
         if (param == null) {
             return defaultValue;
@@ -83,12 +83,12 @@ public abstract class AbstractHttpParams
         return ((Double)param).doubleValue();
     }
 
-    public HttpParams setDoubleParameter(final String name, double value) {
+    public HttpParams setDoubleParameter(final String name, final double value) {
         setParameter(name, new Double(value));
         return this;
     }
 
-    public boolean getBooleanParameter(final String name, boolean defaultValue) {
+    public boolean getBooleanParameter(final String name, final boolean defaultValue) {
         Object param = getParameter(name);
         if (param == null) {
             return defaultValue;
@@ -96,7 +96,7 @@ public abstract class AbstractHttpParams
         return ((Boolean)param).booleanValue();
     }
 
-    public HttpParams setBooleanParameter(final String name, boolean value) {
+    public HttpParams setBooleanParameter(final String name, final boolean value) {
         setParameter(name, value ? Boolean.TRUE : Boolean.FALSE);
         return this;
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/BasicHttpParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/BasicHttpParams.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/BasicHttpParams.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/BasicHttpParams.java Tue Jan 15 18:29:58 2013
@@ -75,7 +75,7 @@ public class BasicHttpParams extends Abs
         return this;
     }
 
-    public boolean removeParameter(String name) {
+    public boolean removeParameter(final String name) {
         //this is to avoid the case in which the key has a null value
         if (this.parameters.containsKey(name)) {
             this.parameters.remove(name);
@@ -168,7 +168,7 @@ public class BasicHttpParams extends Abs
      * @param target    the parameters to which to copy
      * @since 4.2
      */
-    public void copyParams(HttpParams target) {
+    public void copyParams(final HttpParams target) {
         for (Map.Entry<String, Object> me : this.parameters.entrySet()) {
             target.setParameter(me.getKey(), me.getValue());
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/DefaultedHttpParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/DefaultedHttpParams.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/DefaultedHttpParams.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/DefaultedHttpParams.java Tue Jan 15 18:29:58 2013
@@ -153,7 +153,7 @@ public final class DefaultedHttpParams e
     }
 
     // Helper method
-    private Set<String> getNames(HttpParams params) {
+    private Set<String> getNames(final HttpParams params) {
         if (params instanceof HttpParamsNames) {
             return ((HttpParamsNames) params).getNames();
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpConnectionParamBean.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpConnectionParamBean.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpConnectionParamBean.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpConnectionParamBean.java Tue Jan 15 18:29:58 2013
@@ -44,27 +44,27 @@ public class HttpConnectionParamBean ext
         super(params);
     }
 
-    public void setSoTimeout (int soTimeout) {
+    public void setSoTimeout (final int soTimeout) {
         HttpConnectionParams.setSoTimeout(params, soTimeout);
     }
 
-    public void setTcpNoDelay (boolean tcpNoDelay) {
+    public void setTcpNoDelay (final boolean tcpNoDelay) {
         HttpConnectionParams.setTcpNoDelay(params, tcpNoDelay);
     }
 
-    public void setSocketBufferSize (int socketBufferSize) {
+    public void setSocketBufferSize (final int socketBufferSize) {
         HttpConnectionParams.setSocketBufferSize(params, socketBufferSize);
     }
 
-    public void setLinger (int linger) {
+    public void setLinger (final int linger) {
         HttpConnectionParams.setLinger(params, linger);
     }
 
-    public void setConnectionTimeout (int connectionTimeout) {
+    public void setConnectionTimeout (final int connectionTimeout) {
         HttpConnectionParams.setConnectionTimeout(params, connectionTimeout);
     }
 
-    public void setStaleCheckingEnabled (boolean staleCheckingEnabled) {
+    public void setStaleCheckingEnabled (final boolean staleCheckingEnabled) {
         HttpConnectionParams.setStaleCheckingEnabled(params, staleCheckingEnabled);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpConnectionParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpConnectionParams.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpConnectionParams.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpConnectionParams.java Tue Jan 15 18:29:58 2013
@@ -62,7 +62,7 @@ public final class HttpConnectionParams 
      * @param params HTTP parameters.
      * @param timeout SO_TIMEOUT.
      */
-    public static void setSoTimeout(final HttpParams params, int timeout) {
+    public static void setSoTimeout(final HttpParams params, final int timeout) {
         Args.notNull(params, "HTTP parameters");
         params.setIntParameter(CoreConnectionPNames.SO_TIMEOUT, timeout);
 
@@ -90,7 +90,7 @@ public final class HttpConnectionParams 
      *
      * @since 4.1
      */
-    public static void setSoReuseaddr(final HttpParams params, boolean reuseaddr) {
+    public static void setSoReuseaddr(final HttpParams params, final boolean reuseaddr) {
         Args.notNull(params, "HTTP parameters");
         params.setBooleanParameter(CoreConnectionPNames.SO_REUSEADDR, reuseaddr);
     }
@@ -113,7 +113,7 @@ public final class HttpConnectionParams 
      * @param params HTTP parameters.
      * @param value Nagle's algorithm flag
      */
-    public static void setTcpNoDelay(final HttpParams params, boolean value) {
+    public static void setTcpNoDelay(final HttpParams params, final boolean value) {
         Args.notNull(params, "HTTP parameters");
         params.setBooleanParameter(CoreConnectionPNames.TCP_NODELAY, value);
     }
@@ -137,7 +137,7 @@ public final class HttpConnectionParams 
      * @param params HTTP parameters.
      * @param size socket buffer size
      */
-    public static void setSocketBufferSize(final HttpParams params, int size) {
+    public static void setSocketBufferSize(final HttpParams params, final int size) {
         Args.notNull(params, "HTTP parameters");
         params.setIntParameter(CoreConnectionPNames.SOCKET_BUFFER_SIZE, size);
     }
@@ -160,7 +160,7 @@ public final class HttpConnectionParams 
      * @param params HTTP parameters.
      * @param value SO_LINGER.
      */
-    public static void setLinger(final HttpParams params, int value) {
+    public static void setLinger(final HttpParams params, final int value) {
         Args.notNull(params, "HTTP parameters");
         params.setIntParameter(CoreConnectionPNames.SO_LINGER, value);
     }
@@ -184,7 +184,7 @@ public final class HttpConnectionParams 
      * @param params HTTP parameters.
      * @param timeout connect timeout.
      */
-    public static void setConnectionTimeout(final HttpParams params, int timeout) {
+    public static void setConnectionTimeout(final HttpParams params, final int timeout) {
         Args.notNull(params, "HTTP parameters");
         params.setIntParameter(CoreConnectionPNames.CONNECTION_TIMEOUT, timeout);
     }
@@ -208,7 +208,7 @@ public final class HttpConnectionParams 
      * @param params HTTP parameters.
      * @param value stale connection check flag.
      */
-    public static void setStaleCheckingEnabled(final HttpParams params, boolean value) {
+    public static void setStaleCheckingEnabled(final HttpParams params, final boolean value) {
         Args.notNull(params, "HTTP parameters");
         params.setBooleanParameter(CoreConnectionPNames.STALE_CONNECTION_CHECK, value);
     }
@@ -235,7 +235,7 @@ public final class HttpConnectionParams 
      *
      * @since 4.2
      */
-    public static void setSoKeepalive(final HttpParams params, boolean enableKeepalive) {
+    public static void setSoKeepalive(final HttpParams params, final boolean enableKeepalive) {
         Args.notNull(params, "HTTP parameters");
         params.setBooleanParameter(CoreConnectionPNames.SO_KEEPALIVE, enableKeepalive);
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpProtocolParamBean.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpProtocolParamBean.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpProtocolParamBean.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpProtocolParamBean.java Tue Jan 15 18:29:58 2013
@@ -62,7 +62,7 @@ public class HttpProtocolParamBean exten
         HttpProtocolParams.setUserAgent(params, userAgent);
     }
 
-    public void setUseExpectContinue (boolean useExpectContinue) {
+    public void setUseExpectContinue (final boolean useExpectContinue) {
         HttpProtocolParams.setUseExpectContinue(params, useExpectContinue);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpProtocolParams.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpProtocolParams.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpProtocolParams.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/params/HttpProtocolParams.java Tue Jan 15 18:29:58 2013
@@ -174,7 +174,7 @@ public final class HttpProtocolParams im
      * @param params HTTP parameters.
      * @param b expect-continue flag.
      */
-    public static void setUseExpectContinue(final HttpParams params, boolean b) {
+    public static void setUseExpectContinue(final HttpParams params, final boolean b) {
         Args.notNull(params, "HTTP parameters");
         params.setBooleanParameter(CoreProtocolPNames.USE_EXPECT_CONTINUE, b);
     }
@@ -203,7 +203,7 @@ public final class HttpProtocolParams im
      *
      * @since 4.2
      */
-    public static void setMalformedInputAction(final HttpParams params, CodingErrorAction action) {
+    public static void setMalformedInputAction(final HttpParams params, final CodingErrorAction action) {
         Args.notNull(params, "HTTP parameters");
         params.setParameter(CoreProtocolPNames.HTTP_MALFORMED_INPUT_ACTION, action);
     }
@@ -232,7 +232,7 @@ public final class HttpProtocolParams im
      *
      * @since 4.2
      */
-    public static void setUnmappableInputAction(final HttpParams params, CodingErrorAction action) {
+    public static void setUnmappableInputAction(final HttpParams params, final CodingErrorAction action) {
         Args.notNull(params, "HTTP parameters");
         params.setParameter(CoreProtocolPNames.HTTP_UNMAPPABLE_INPUT_ACTION, action);
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/AbstractConnPool.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/AbstractConnPool.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/AbstractConnPool.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/AbstractConnPool.java Tue Jan 15 18:29:58 2013
@@ -78,8 +78,8 @@ public abstract class AbstractConnPool<T
 
     public AbstractConnPool(
             final ConnFactory<T, C> connFactory,
-            int defaultMaxPerRoute,
-            int maxTotal) {
+            final int defaultMaxPerRoute,
+            final int maxTotal) {
         super();
         this.connFactory = Args.notNull(connFactory, "Connection factory");
         this.defaultMaxPerRoute = Args.notNegative(defaultMaxPerRoute, "Max per route value");
@@ -134,7 +134,7 @@ public abstract class AbstractConnPool<T
             pool = new RouteSpecificPool<T, C, E>(route) {
 
                 @Override
-                protected E createEntry(C conn) {
+                protected E createEntry(final C conn) {
                     return AbstractConnPool.this.createEntry(route, conn);
                 }
 
@@ -159,8 +159,8 @@ public abstract class AbstractConnPool<T
 
             @Override
             public E getPoolEntry(
-                    long timeout,
-                    TimeUnit tunit)
+                    final long timeout,
+                    final TimeUnit tunit)
                         throws InterruptedException, TimeoutException, IOException {
                 return getPoolEntryBlocking(route, state, timeout, tunit, this);
             }
@@ -298,7 +298,7 @@ public abstract class AbstractConnPool<T
         }
     }
 
-    public void release(E entry, boolean reusable) {
+    public void release(final E entry, final boolean reusable) {
         this.lock.lock();
         try {
             if (this.leased.remove(entry)) {
@@ -325,7 +325,7 @@ public abstract class AbstractConnPool<T
         }
     }
 
-    public void setMaxTotal(int max) {
+    public void setMaxTotal(final int max) {
         Args.notNegative(max, "Max value");
         this.lock.lock();
         try {
@@ -344,7 +344,7 @@ public abstract class AbstractConnPool<T
         }
     }
 
-    public void setDefaultMaxPerRoute(int max) {
+    public void setDefaultMaxPerRoute(final int max) {
         Args.notNegative(max, "Max per route value");
         this.lock.lock();
         try {
@@ -363,7 +363,7 @@ public abstract class AbstractConnPool<T
         }
     }
 
-    public void setMaxPerRoute(final T route, int max) {
+    public void setMaxPerRoute(final T route, final int max) {
         Args.notNull(route, "Route");
         Args.notNegative(max, "Max per route value");
         this.lock.lock();
@@ -374,7 +374,7 @@ public abstract class AbstractConnPool<T
         }
     }
 
-    public int getMaxPerRoute(T route) {
+    public int getMaxPerRoute(final T route) {
         Args.notNull(route, "Route");
         this.lock.lock();
         try {
@@ -419,7 +419,7 @@ public abstract class AbstractConnPool<T
      * @param idletime maximum idle time.
      * @param tunit time unit.
      */
-    public void closeIdle(long idletime, final TimeUnit tunit) {
+    public void closeIdle(final long idletime, final TimeUnit tunit) {
         Args.notNull(tunit, "Time unit");
         long time = tunit.toMillis(idletime);
         if (time < 0) {

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/PoolEntryFuture.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/PoolEntryFuture.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/PoolEntryFuture.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/PoolEntryFuture.java Tue Jan 15 18:29:58 2013
@@ -55,7 +55,7 @@ abstract class PoolEntryFuture<T> implem
         this.callback = callback;
     }
 
-    public boolean cancel(boolean mayInterruptIfRunning) {
+    public boolean cancel(final boolean mayInterruptIfRunning) {
         this.lock.lock();
         try {
             if (this.completed) {
@@ -90,7 +90,7 @@ abstract class PoolEntryFuture<T> implem
     }
 
     public T get(
-            long timeout,
+            final long timeout,
             final TimeUnit unit) throws InterruptedException, ExecutionException, TimeoutException {
         this.lock.lock();
         try {

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/PoolStats.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/PoolStats.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/PoolStats.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/PoolStats.java Tue Jan 15 18:29:58 2013
@@ -44,7 +44,7 @@ public class PoolStats {
     private final int available;
     private final int max;
 
-    public PoolStats(int leased, int pending, int free, int max) {
+    public PoolStats(final int leased, final int pending, final int free, final int max) {
         super();
         this.leased = leased;
         this.pending = pending;

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/RouteSpecificPool.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/RouteSpecificPool.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/RouteSpecificPool.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/pool/RouteSpecificPool.java Tue Jan 15 18:29:58 2013
@@ -117,7 +117,7 @@ abstract class RouteSpecificPool<T, C, E
         return true;
     }
 
-    public void free(final E entry, boolean reusable) {
+    public void free(final E entry, final boolean reusable) {
         Args.notNull(entry, "Pool entry");
         boolean found = this.leased.remove(entry);
         Asserts.check(found, "Entry %s has not been leased from this pool", entry);

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/BasicHttpProcessor.java Tue Jan 15 18:29:58 2013
@@ -67,7 +67,7 @@ public final class BasicHttpProcessor im
     }
 
     public void addRequestInterceptor(
-            final HttpRequestInterceptor itcp, int index) {
+            final HttpRequestInterceptor itcp, final int index) {
         if (itcp == null) {
             return;
         }
@@ -75,7 +75,7 @@ public final class BasicHttpProcessor im
     }
 
     public void addResponseInterceptor(
-            final HttpResponseInterceptor itcp, int index) {
+            final HttpResponseInterceptor itcp, final int index) {
         if (itcp == null) {
             return;
         }
@@ -106,7 +106,7 @@ public final class BasicHttpProcessor im
         addRequestInterceptor(interceptor);
     }
 
-     public final void addInterceptor(final HttpRequestInterceptor interceptor, int index) {
+     public final void addInterceptor(final HttpRequestInterceptor interceptor, final int index) {
         addRequestInterceptor(interceptor, index);
     }
 
@@ -114,7 +114,7 @@ public final class BasicHttpProcessor im
         return this.requestInterceptors.size();
     }
 
-    public HttpRequestInterceptor getRequestInterceptor(int index) {
+    public HttpRequestInterceptor getRequestInterceptor(final int index) {
         if ((index < 0) || (index >= this.requestInterceptors.size())) {
 			return null;
 		}
@@ -136,7 +136,7 @@ public final class BasicHttpProcessor im
         addResponseInterceptor(interceptor);
     }
 
-    public final void addInterceptor(final HttpResponseInterceptor interceptor, int index) {
+    public final void addInterceptor(final HttpResponseInterceptor interceptor, final int index) {
         addResponseInterceptor(interceptor, index);
     }
 
@@ -144,7 +144,7 @@ public final class BasicHttpProcessor im
         return this.responseInterceptors.size();
     }
 
-    public HttpResponseInterceptor getResponseInterceptor(int index) {
+    public HttpResponseInterceptor getResponseInterceptor(final int index) {
         if ((index < 0) || (index >= this.responseInterceptors.size())) {
 			return null;
 		}

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/ChainBuilder.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/ChainBuilder.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/ChainBuilder.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/ChainBuilder.java Tue Jan 15 18:29:58 2013
@@ -89,7 +89,7 @@ final class ChainBuilder<E> {
         return this;
     }
 
-    public ChainBuilder<E> addAllFirst(E... c) {
+    public ChainBuilder<E> addAllFirst(final E... c) {
         if (c == null) {
             return this;
         }
@@ -109,7 +109,7 @@ final class ChainBuilder<E> {
         return this;
     }
 
-    public ChainBuilder<E> addAllLast(E... c) {
+    public ChainBuilder<E> addAllLast(final E... c) {
         if (c == null) {
             return this;
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HTTP.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HTTP.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HTTP.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HTTP.java Tue Jan 15 18:29:58 2013
@@ -125,7 +125,7 @@ public final class HTTP {
     @Deprecated
     public final static String DEFAULT_CONTENT_TYPE = OCTET_STREAM_TYPE;
 
-    public static boolean isWhitespace(char ch) {
+    public static boolean isWhitespace(final char ch) {
         return ch == SP || ch == HT || ch == CR || ch == LF;
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HttpRequestExecutor.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HttpRequestExecutor.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HttpRequestExecutor.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HttpRequestExecutor.java Tue Jan 15 18:29:58 2013
@@ -67,7 +67,7 @@ public class HttpRequestExecutor {
      *
      * @since 4.3
      */
-    public HttpRequestExecutor(int waitForContinue) {
+    public HttpRequestExecutor(final int waitForContinue) {
         super();
         this.waitForContinue = Args.positive(waitForContinue, "Wait for continue time");
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HttpService.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HttpService.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HttpService.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/HttpService.java Tue Jan 15 18:29:58 2013
@@ -438,7 +438,7 @@ public class HttpService {
             this.resolver = resolver;
         }
 
-        public HttpRequestHandler lookup(HttpRequest request) {
+        public HttpRequestHandler lookup(final HttpRequest request) {
             return resolver.lookup(request.getRequestLine().getUri());
         }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/RequestContent.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/RequestContent.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/RequestContent.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/RequestContent.java Tue Jan 15 18:29:58 2013
@@ -75,7 +75,7 @@ public class RequestContent implements H
      *
      * @since 4.2
      */
-     public RequestContent(boolean overwrite) {
+     public RequestContent(final boolean overwrite) {
          super();
          this.overwrite = overwrite;
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/ResponseContent.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/ResponseContent.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/ResponseContent.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/protocol/ResponseContent.java Tue Jan 15 18:29:58 2013
@@ -75,7 +75,7 @@ public class ResponseContent implements 
      *
      * @since 4.2
      */
-     public ResponseContent(boolean overwrite) {
+     public ResponseContent(final boolean overwrite) {
          super();
          this.overwrite = overwrite;
     }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/Args.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/Args.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/Args.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/Args.java Tue Jan 15 18:29:58 2013
@@ -31,13 +31,13 @@ import java.util.Collection;
 
 public class Args {
 
-    public static void check(boolean expression, final String message) {
+    public static void check(final boolean expression, final String message) {
         if (!expression) {
             throw new IllegalArgumentException(message);
         }
     }
 
-    public static void check(boolean expression, final String message, final Object... args) {
+    public static void check(final boolean expression, final String message, final Object... args) {
         if (!expression) {
             throw new IllegalArgumentException(String.format(message, args));
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/Asserts.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/Asserts.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/Asserts.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/Asserts.java Tue Jan 15 18:29:58 2013
@@ -29,13 +29,13 @@ package org.apache.http.util;
 
 public class Asserts {
 
-    public static void check(boolean expression, final String message) {
+    public static void check(final boolean expression, final String message) {
         if (!expression) {
             throw new IllegalStateException(message);
         }
     }
 
-    public static void check(boolean expression, final String message, final Object... args) {
+    public static void check(final boolean expression, final String message, final Object... args) {
         if (!expression) {
             throw new IllegalStateException(String.format(message, args));
         }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/ByteArrayBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/ByteArrayBuffer.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/ByteArrayBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/ByteArrayBuffer.java Tue Jan 15 18:29:58 2013
@@ -50,13 +50,13 @@ public final class ByteArrayBuffer imple
      *
      * @param capacity the capacity
      */
-    public ByteArrayBuffer(int capacity) {
+    public ByteArrayBuffer(final int capacity) {
         super();
         Args.notNegative(capacity, "Buffer capacity");
         this.buffer = new byte[capacity];
     }
 
-    private void expand(int newlen) {
+    private void expand(final int newlen) {
         byte newbuffer[] = new byte[Math.max(this.buffer.length << 1, newlen)];
         System.arraycopy(this.buffer, 0, newbuffer, 0, this.len);
         this.buffer = newbuffer;
@@ -74,7 +74,7 @@ public final class ByteArrayBuffer imple
      * range, <code>len</code> is negative, or
      * <code>off</code> + <code>len</code> is out of range.
      */
-    public void append(final byte[] b, int off, int len) {
+    public void append(final byte[] b, final int off, final int len) {
         if (b == null) {
             return;
         }
@@ -99,7 +99,7 @@ public final class ByteArrayBuffer imple
      *
      * @param   b        the byte to be appended.
      */
-    public void append(int b) {
+    public void append(final int b) {
         int newlen = this.len + 1;
         if (newlen > this.buffer.length) {
             expand(newlen);
@@ -122,7 +122,7 @@ public final class ByteArrayBuffer imple
      * range, <code>len</code> is negative, or
      * <code>off</code> + <code>len</code> is out of range.
      */
-    public void append(final char[] b, int off, int len) {
+    public void append(final char[] b, final int off, final int len) {
         if (b == null) {
             return;
         }
@@ -159,7 +159,7 @@ public final class ByteArrayBuffer imple
      * range, <code>len</code> is negative, or
      * <code>off</code> + <code>len</code> is out of range.
      */
-    public void append(final CharArrayBuffer b, int off, int len) {
+    public void append(final CharArrayBuffer b, final int off, final int len) {
         if (b == null) {
             return;
         }
@@ -196,7 +196,7 @@ public final class ByteArrayBuffer imple
      * @throws     IndexOutOfBoundsException  if <code>index</code> is
      *             negative or greater than or equal to {@link #length()}.
      */
-    public int byteAt(int i) {
+    public int byteAt(final int i) {
         return this.buffer[i];
     }
 
@@ -230,7 +230,7 @@ public final class ByteArrayBuffer imple
      *
      * @since 4.1
      */
-    public void ensureCapacity(int required) {
+    public void ensureCapacity(final int required) {
         if (required <= 0) {
             return;
         }
@@ -259,7 +259,7 @@ public final class ByteArrayBuffer imple
      *               <code>len</code> argument is greater than the current
      *               capacity of the buffer or less than <code>0</code>.
      */
-    public void setLength(int len) {
+    public void setLength(final int len) {
         if (len < 0 || len > this.buffer.length) {
             throw new IndexOutOfBoundsException("len: "+len+" < 0 or > buffer len: "+this.buffer.length);
         }
@@ -309,7 +309,7 @@ public final class ByteArrayBuffer imple
      *
      * @since 4.1
      */
-    public int indexOf(byte b, int beginIndex, int endIndex) {
+    public int indexOf(final byte b, int beginIndex, int endIndex) {
         if (beginIndex < 0) {
             beginIndex = 0;
         }
@@ -339,7 +339,7 @@ public final class ByteArrayBuffer imple
      *
      * @since 4.1
      */
-    public int indexOf(byte b) {
+    public int indexOf(final byte b) {
         return indexOf(b, 0, this.len);
     }
 }

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/CharArrayBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/CharArrayBuffer.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/CharArrayBuffer.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/CharArrayBuffer.java Tue Jan 15 18:29:58 2013
@@ -51,13 +51,13 @@ public final class CharArrayBuffer imple
      *
      * @param capacity the capacity
      */
-    public CharArrayBuffer(int capacity) {
+    public CharArrayBuffer(final int capacity) {
         super();
         Args.notNegative(capacity, "Buffer capacity");
         this.buffer = new char[capacity];
     }
 
-    private void expand(int newlen) {
+    private void expand(final int newlen) {
         char newbuffer[] = new char[Math.max(this.buffer.length << 1, newlen)];
         System.arraycopy(this.buffer, 0, newbuffer, 0, this.len);
         this.buffer = newbuffer;
@@ -75,7 +75,7 @@ public final class CharArrayBuffer imple
      * range, <code>len</code> is negative, or
      * <code>off</code> + <code>len</code> is out of range.
      */
-    public void append(final char[] b, int off, int len) {
+    public void append(final char[] b, final int off, final int len) {
         if (b == null) {
             return;
         }
@@ -126,7 +126,7 @@ public final class CharArrayBuffer imple
      * range, <code>len</code> is negative, or
      * <code>off</code> + <code>len</code> is out of range.
      */
-    public void append(final CharArrayBuffer b, int off, int len) {
+    public void append(final CharArrayBuffer b, final int off, final int len) {
         if (b == null) {
             return;
         }
@@ -153,7 +153,7 @@ public final class CharArrayBuffer imple
      *
      * @param   ch        the char to be appended.
      */
-    public void append(char ch) {
+    public void append(final char ch) {
         int newlen = this.len + 1;
         if (newlen > this.buffer.length) {
             expand(newlen);
@@ -176,7 +176,7 @@ public final class CharArrayBuffer imple
      * range, <code>len</code> is negative, or
      * <code>off</code> + <code>len</code> is out of range.
      */
-    public void append(final byte[] b, int off, int len) {
+    public void append(final byte[] b, final int off, final int len) {
         if (b == null) {
             return;
         }
@@ -212,7 +212,7 @@ public final class CharArrayBuffer imple
      * range, <code>len</code> is negative, or
      * <code>off</code> + <code>len</code> is out of range.
      */
-    public void append(final ByteArrayBuffer b, int off, int len) {
+    public void append(final ByteArrayBuffer b, final int off, final int len) {
         if (b == null) {
             return;
         }
@@ -260,7 +260,7 @@ public final class CharArrayBuffer imple
      * @throws     IndexOutOfBoundsException  if <code>index</code> is
      *             negative or greater than or equal to {@link #length()}.
      */
-    public char charAt(int i) {
+    public char charAt(final int i) {
         return this.buffer[i];
     }
 
@@ -301,7 +301,7 @@ public final class CharArrayBuffer imple
      *
      * @param   required   the minimum required capacity.
      */
-    public void ensureCapacity(int required) {
+    public void ensureCapacity(final int required) {
         if (required <= 0) {
             return;
         }
@@ -321,7 +321,7 @@ public final class CharArrayBuffer imple
      *               <code>len</code> argument is greater than the current
      *               capacity of the buffer or less than <code>0</code>.
      */
-    public void setLength(int len) {
+    public void setLength(final int len) {
         if (len < 0 || len > this.buffer.length) {
             throw new IndexOutOfBoundsException("len: "+len+" < 0 or > buffer len: "+this.buffer.length);
         }
@@ -369,7 +369,7 @@ public final class CharArrayBuffer imple
      *   within the given bounds, or <code>-1</code> if the character does
      *   not occur.
      */
-    public int indexOf(int ch, int beginIndex, int endIndex) {
+    public int indexOf(final int ch, int beginIndex, int endIndex) {
         if (beginIndex < 0) {
             beginIndex = 0;
         }
@@ -397,7 +397,7 @@ public final class CharArrayBuffer imple
      * @return  the index of the first occurrence of the character in the
      *   buffer, or <code>-1</code> if the character does not occur.
      */
-    public int indexOf(int ch) {
+    public int indexOf(final int ch) {
         return indexOf(ch, 0, this.len);
     }
 
@@ -415,7 +415,7 @@ public final class CharArrayBuffer imple
      *             buffer, or <code>beginIndex</code> is larger than
      *             <code>endIndex</code>.
      */
-    public String substring(int beginIndex, int endIndex) {
+    public String substring(final int beginIndex, final int endIndex) {
         return new String(this.buffer, beginIndex, endIndex - beginIndex);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/EncodingUtils.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/EncodingUtils.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/EncodingUtils.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/EncodingUtils.java Tue Jan 15 18:29:58 2013
@@ -51,9 +51,9 @@ public final class EncodingUtils {
      */
     public static String getString(
         final byte[] data,
-        int offset,
-        int length,
-        String charset) {
+        final int offset,
+        final int length,
+        final String charset) {
         Args.notNull(data, "Input");
         Args.notEmpty(charset, "Charset");
         try {
@@ -121,7 +121,7 @@ public final class EncodingUtils {
      * @param length the number of bytes to encode
      * @return The string representation of the byte array
      */
-    public static String getAsciiString(final byte[] data, int offset, int length) {
+    public static String getAsciiString(final byte[] data, final int offset, final int length) {
         Args.notNull(data, "Input");
         try {
             return new String(data, offset, length, Consts.ASCII.name());

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/ExceptionUtils.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/ExceptionUtils.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/ExceptionUtils.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/ExceptionUtils.java Tue Jan 15 18:29:58 2013
@@ -66,7 +66,7 @@ public final class ExceptionUtils {
      * @param  throwable The throwable.
      * @param  cause     The cause of the throwable.
      */
-    public static void initCause(Throwable throwable, Throwable cause) {
+    public static void initCause(final Throwable throwable, final Throwable cause) {
         if (INIT_CAUSE_METHOD != null) {
             try {
                 INIT_CAUSE_METHOD.invoke(throwable, new Object[] { cause });

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/VersionInfo.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/VersionInfo.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/VersionInfo.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/util/VersionInfo.java Tue Jan 15 18:29:58 2013
@@ -85,8 +85,8 @@ public class VersionInfo {
      * @param time      the build time, or <code>null</code>
      * @param clsldr    the class loader, or <code>null</code>
      */
-    protected VersionInfo(String pckg, String module,
-                          String release, String time, String clsldr) {
+    protected VersionInfo(final String pckg, final String module,
+                          final String release, final String time, final String clsldr) {
         Args.notNull(pckg, "Package identifier");
         infoPackage     = pckg;
         infoModule      = (module  != null) ? module  : UNAVAILABLE;
@@ -193,8 +193,8 @@ public class VersionInfo {
      * @return  the version information for all packages found,
      *          never <code>null</code>
      */
-    public final static VersionInfo[] loadVersionInfo(String[] pckgs,
-                                                      ClassLoader clsldr) {
+    public final static VersionInfo[] loadVersionInfo(final String[] pckgs,
+                                                      final ClassLoader clsldr) {
         Args.notNull(pckgs, "Package identifier array");
         List<VersionInfo> vil = new ArrayList<VersionInfo>(pckgs.length);
         for (String pckg : pckgs) {
@@ -265,8 +265,8 @@ public class VersionInfo {
      *
      * @return  the version information
      */
-    protected final static VersionInfo fromMap(String pckg, Map<?, ?> info,
-                                               ClassLoader clsldr) {
+    protected final static VersionInfo fromMap(final String pckg, final Map<?, ?> info,
+                                               final ClassLoader clsldr) {
         Args.notNull(pckg, "Package identifier");
         String module = null;
         String release = null;
@@ -315,7 +315,7 @@ public class VersionInfo {
      *            the class' class loader to load from, or <code>null</code> for the thread context class loader
      * @since 4.3
      */
-    public static String getUserAgent(String name, String pkg, Class<?> cls) {
+    public static String getUserAgent(final String name, final String pkg, final Class<?> cls) {
         // determine the release version from packaged version info
         final VersionInfo vi = VersionInfo.loadVersionInfo(pkg, cls.getClassLoader());
         final String release = (vi != null) ? vi.getRelease() : VersionInfo.UNAVAILABLE;

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/entity/TestStringEntity.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/entity/TestStringEntity.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/entity/TestStringEntity.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/entity/TestStringEntity.java Tue Jan 15 18:29:58 2013
@@ -79,7 +79,7 @@ public class TestStringEntity {
                 httpentity.getContentType().getValue());
     }
 
-    private static String constructString(int [] unicodeChars) {
+    private static String constructString(final int [] unicodeChars) {
         StringBuilder buffer = new StringBuilder();
         if (unicodeChars != null) {
             for (int unicodeChar : unicodeChars) {

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/SessionInputBufferMock.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/SessionInputBufferMock.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/SessionInputBufferMock.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/SessionInputBufferMock.java Tue Jan 15 18:29:58 2013
@@ -47,7 +47,7 @@ public class SessionInputBufferMock exte
 
     public SessionInputBufferMock(
             final InputStream instream,
-            int buffersize,
+            final int buffersize,
             final MessageConstraints constrains,
             final CharsetDecoder decoder) {
         super(new HttpTransportMetricsImpl(), buffersize, -1, constrains, decoder);
@@ -56,13 +56,13 @@ public class SessionInputBufferMock exte
 
     public SessionInputBufferMock(
             final InputStream instream,
-            int buffersize) {
+            final int buffersize) {
         this(instream, buffersize, null, null);
     }
 
     public SessionInputBufferMock(
             final byte[] bytes,
-            int buffersize,
+            final int buffersize,
             final MessageConstraints constrains,
             final CharsetDecoder decoder) {
         this(new ByteArrayInputStream(bytes), buffersize, constrains, decoder);
@@ -70,14 +70,14 @@ public class SessionInputBufferMock exte
 
     public SessionInputBufferMock(
             final byte[] bytes,
-            int buffersize,
+            final int buffersize,
             final MessageConstraints constrains) {
         this(new ByteArrayInputStream(bytes), buffersize, constrains, null);
     }
 
     public SessionInputBufferMock(
             final byte[] bytes,
-            int buffersize) {
+            final int buffersize) {
         this(new ByteArrayInputStream(bytes), buffersize);
     }
 
@@ -104,7 +104,7 @@ public class SessionInputBufferMock exte
     }
 
     @Override
-    public boolean isDataAvailable(int timeout) throws IOException {
+    public boolean isDataAvailable(final int timeout) throws IOException {
         return true;
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/SessionOutputBufferMock.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/SessionOutputBufferMock.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/SessionOutputBufferMock.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/SessionOutputBufferMock.java Tue Jan 15 18:29:58 2013
@@ -46,8 +46,8 @@ public class SessionOutputBufferMock ext
 
     public SessionOutputBufferMock(
             final ByteArrayOutputStream buffer,
-            int buffersize,
-            int minChunkLimit,
+            final int buffersize,
+            final int minChunkLimit,
             final CharsetEncoder encoder) {
         super(new HttpTransportMetricsImpl(), buffersize, minChunkLimit, encoder);
         bind(buffer);
@@ -56,7 +56,7 @@ public class SessionOutputBufferMock ext
 
     public SessionOutputBufferMock(
             final ByteArrayOutputStream buffer,
-            int buffersize) {
+            final int buffersize) {
         this(buffer, buffersize, -1, null);
     }
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/io/TestSessionInOutBuffers.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/io/TestSessionInOutBuffers.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/io/TestSessionInOutBuffers.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/io/TestSessionInOutBuffers.java Tue Jan 15 18:29:58 2013
@@ -372,7 +372,7 @@ public class TestSessionInOutBuffers {
         0x432, 0x435, 0x442
     };
 
-    private static String constructString(int [] unicodeChars) {
+    private static String constructString(final int [] unicodeChars) {
         StringBuilder buffer = new StringBuilder();
         if (unicodeChars != null) {
             for (int unicodeChar : unicodeChars) {

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/io/TimeoutByteArrayInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/io/TimeoutByteArrayInputStream.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/io/TimeoutByteArrayInputStream.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/io/TimeoutByteArrayInputStream.java Tue Jan 15 18:29:58 2013
@@ -42,14 +42,14 @@ class TimeoutByteArrayInputStream extend
     private int pos;
     protected int count;
 
-    public TimeoutByteArrayInputStream(byte[] buf, int off, int len) {
+    public TimeoutByteArrayInputStream(final byte[] buf, final int off, final int len) {
         super();
         this.buf = buf;
         this.pos = off;
         this.count = Math.min(off + len, buf.length);
     }
 
-    public TimeoutByteArrayInputStream(byte[] buf) {
+    public TimeoutByteArrayInputStream(final byte[] buf) {
         this(buf, 0, buf.length);
     }
 
@@ -67,7 +67,7 @@ class TimeoutByteArrayInputStream extend
     }
 
     @Override
-    public int read(byte b[], int off, int len) throws IOException {
+    public int read(final byte b[], final int off, int len) throws IOException {
         if (b == null) {
             throw new NullPointerException();
         } else if ((off < 0) || (off > b.length) || (len < 0) ||

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java?rev=1433569&r1=1433568&r2=1433569&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java (original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java Tue Jan 15 18:29:58 2013
@@ -603,7 +603,7 @@ public class TestSyncHttp {
         private final byte[] raw;
         private final int n;
 
-        public RepeatingEntity(final String content, Charset charset, int n) {
+        public RepeatingEntity(final String content, Charset charset, final int n) {
             super();
             if (charset == null) {
                 charset = Charset.forName("US-ASCII"); // US-ASCII is built-in



Mime
View raw message