hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1432552 - in /httpcomponents: benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/ httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/ httpasyncclient/trunk/httpasyncclient/src/test/java...
Date Sun, 13 Jan 2013 04:49:34 GMT
Author: ggregory
Date: Sun Jan 13 04:49:33 2013
New Revision: 1432552

URL: http://svn.apache.org/viewvc?rev=1432552&view=rev
Log:
Add final modifier to private fields.

Modified:
    httpcomponents/benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/RandomDataHandler.java
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/DefaultClientAsyncConnection.java
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestClientReauthentication.java
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestAsyncConsumers.java
    httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestZeroCopy.java
    httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/WarningValue.java
    httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/PrefixKeyHashingScheme.java
    httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ConsumableInputStream.java
    httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/RequestEquivalent.java
    httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java
    httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestResponseCachingPolicy.java
    httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
    httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java
    httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/client/utils/TestURIUtils.java
    httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestAbortHandling.java
    httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientAuthentication.java
    httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientReauthentication.java
    httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestRedirects.java
    httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentBufferEntity.java
    httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestSessionInOutBuffers.java
    httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ChunkedOutputStream.java
    httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
    httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java
    httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/TestNoConnectionReuseStrategy.java
    httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java

Modified: httpcomponents/benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/RandomDataHandler.java
URL: http://svn.apache.org/viewvc/httpcomponents/benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/RandomDataHandler.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/RandomDataHandler.java
(original)
+++ httpcomponents/benchmark/httpcore/trunk/src/main/java/org/apache/http/benchmark/httpcore/RandomDataHandler.java
Sun Jan 13 04:49:33 2013
@@ -88,7 +88,7 @@ class RandomDataHandler implements HttpR
 
     static class RandomEntity extends AbstractHttpEntity {
 
-        private int count;
+        private final int count;
         private final byte[] buf;
 
         public RandomEntity(int count) {

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/DefaultClientAsyncConnection.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/DefaultClientAsyncConnection.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/DefaultClientAsyncConnection.java
(original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/main/java/org/apache/http/impl/nio/conn/DefaultClientAsyncConnection.java
Sun Jan 13 04:49:33 2013
@@ -45,7 +45,7 @@ public class DefaultClientAsyncConnectio
     private final Log wirelog   = LogFactory.getLog("org.apache.http.wire");
     private final Log log;
 
-    private String id;
+    private final String id;
     private IOSession original;
 
     public DefaultClientAsyncConnection(

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestClientReauthentication.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestClientReauthentication.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestClientReauthentication.java
(original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/integration/TestClientReauthentication.java
Sun Jan 13 04:49:33 2013
@@ -160,7 +160,7 @@ public class TestClientReauthentication 
 
     static class AuthHandler implements HttpRequestHandler {
 
-        private AtomicLong count = new AtomicLong(0);
+        private final AtomicLong count = new AtomicLong(0);
 
         public void handle(
                 final HttpRequest request,

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestAsyncConsumers.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestAsyncConsumers.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestAsyncConsumers.java
(original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestAsyncConsumers.java
Sun Jan 13 04:49:33 2013
@@ -128,7 +128,7 @@ public class TestAsyncConsumers extends 
             super(bufSize);
         }
 
-        private AtomicLong count = new AtomicLong(0);
+        private final AtomicLong count = new AtomicLong(0);
 
         @Override
         protected void onResponseReceived(final HttpResponse response) {
@@ -180,7 +180,7 @@ public class TestAsyncConsumers extends 
             super(bufSize);
         }
 
-        private StringBuilder sb = new StringBuilder();
+        private final StringBuilder sb = new StringBuilder();
 
         @Override
         public void onResponseReceived(final HttpResponse response) {

Modified: httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestZeroCopy.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestZeroCopy.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestZeroCopy.java
(original)
+++ httpcomponents/httpasyncclient/trunk/httpasyncclient/src/test/java/org/apache/http/nio/client/methods/TestZeroCopy.java
Sun Jan 13 04:49:33 2013
@@ -207,7 +207,7 @@ public class TestZeroCopy extends HttpAs
 
     static class TestHandler implements HttpRequestHandler {
 
-        private boolean forceChunking;
+        private final boolean forceChunking;
 
         TestHandler(boolean forceChunking) {
             super();

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/WarningValue.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/WarningValue.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/WarningValue.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/WarningValue.java
Sun Jan 13 04:49:33 2013
@@ -45,7 +45,7 @@ class WarningValue {
 
     private int offs;
     private int init_offs;
-    private String src;
+    private final String src;
     private int warnCode;
     private String warnAgent;
     private String warnText;

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/PrefixKeyHashingScheme.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/PrefixKeyHashingScheme.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/PrefixKeyHashingScheme.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/main/java/org/apache/http/impl/client/cache/memcached/PrefixKeyHashingScheme.java
Sun Jan 13 04:49:33 2013
@@ -35,8 +35,8 @@ package org.apache.http.impl.client.cach
  */
 public class PrefixKeyHashingScheme implements KeyHashingScheme {
 
-    private String prefix;
-    private KeyHashingScheme backingScheme;
+    private final String prefix;
+    private final KeyHashingScheme backingScheme;
 
     /**
      * Creates a new {@link KeyHashingScheme} that prepends the given

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ConsumableInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ConsumableInputStream.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ConsumableInputStream.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/ConsumableInputStream.java
Sun Jan 13 04:49:33 2013
@@ -32,7 +32,7 @@ import java.io.InputStream;
 
 public class ConsumableInputStream extends InputStream {
 
-    private ByteArrayInputStream buf;
+    private final ByteArrayInputStream buf;
     private boolean closed = false;
 
     public ConsumableInputStream(ByteArrayInputStream buf) {

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/RequestEquivalent.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/RequestEquivalent.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/RequestEquivalent.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/RequestEquivalent.java
Sun Jan 13 04:49:33 2013
@@ -31,7 +31,7 @@ import org.easymock.IArgumentMatcher;
 
 public class RequestEquivalent implements IArgumentMatcher {
 
-    private HttpRequest expected;
+    private final HttpRequest expected;
 
     public RequestEquivalent(HttpRequest expected) {
         this.expected = expected;

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestProtocolDeviations.java
Sun Jan 13 04:49:33 2013
@@ -75,7 +75,7 @@ public class TestProtocolDeviations {
 
     private static final int MAX_BYTES = 1024;
     private static final int MAX_ENTRIES = 100;
-    private int entityLength = 128;
+    private final int entityLength = 128;
 
     private HttpHost host;
     private HttpRoute route;

Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestResponseCachingPolicy.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestResponseCachingPolicy.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestResponseCachingPolicy.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/impl/client/cache/TestResponseCachingPolicy.java
Sun Jan 13 04:49:33 2013
@@ -49,7 +49,7 @@ public class TestResponseCachingPolicy {
     private ResponseCachingPolicy policy;
     private HttpResponse response;
     private HttpRequest request;
-    private int[] acceptableCodes = new int[] { HttpStatus.SC_OK,
+    private final int[] acceptableCodes = new int[] { HttpStatus.SC_OK,
             HttpStatus.SC_NON_AUTHORITATIVE_INFORMATION, HttpStatus.SC_MULTIPLE_CHOICES,
             HttpStatus.SC_MOVED_PERMANENTLY, HttpStatus.SC_GONE };
     private Date now;

Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
Sun Jan 13 04:49:33 2013
@@ -198,7 +198,7 @@ public class DefaultRequestDirector impl
 
     private int redirectCount;
 
-    private int maxRedirects;
+    private final int maxRedirects;
 
     private HttpHost virtualHost;
 

Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java
Sun Jan 13 04:49:33 2013
@@ -51,7 +51,7 @@ public class InMemoryDnsResolver impleme
      * In-memory collection that will hold the associations between a host name
      * and an array of InetAddress instances.
      */
-    private Map<String, InetAddress[]> dnsMap;
+    private final Map<String, InetAddress[]> dnsMap;
 
     /**
      * Builds a DNS resolver that will resolve the host names against a

Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/client/utils/TestURIUtils.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/client/utils/TestURIUtils.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/client/utils/TestURIUtils.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/client/utils/TestURIUtils.java
Sun Jan 13 04:49:33 2013
@@ -38,7 +38,7 @@ import org.junit.Test;
  */
 public class TestURIUtils {
 
-    private URI baseURI = URI.create("http://a/b/c/d;p?q");
+    private final URI baseURI = URI.create("http://a/b/c/d;p?q");
 
     @Test
     public void testRewrite() throws Exception {

Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestAbortHandling.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestAbortHandling.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestAbortHandling.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestAbortHandling.java
Sun Jan 13 04:49:33 2013
@@ -325,8 +325,8 @@ public class TestAbortHandling extends I
     }
 
    private static class BasicRedirectService implements HttpRequestHandler {
-        private int statuscode = HttpStatus.SC_SEE_OTHER;
-        private int port;
+        private final int statuscode = HttpStatus.SC_SEE_OTHER;
+        private final int port;
 
         public BasicRedirectService(int port) {
             this.port = port;

Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientAuthentication.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientAuthentication.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientAuthentication.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientAuthentication.java
Sun Jan 13 04:49:33 2013
@@ -331,7 +331,7 @@ public class TestClientAuthentication ex
 
     static class TestTargetAuthenticationStrategy extends TargetAuthenticationStrategy {
 
-        private AtomicLong count;
+        private final AtomicLong count;
 
         public TestTargetAuthenticationStrategy() {
             super();
@@ -424,7 +424,7 @@ public class TestClientAuthentication ex
 
     static class CountingAuthHandler implements HttpRequestHandler {
 
-        private AtomicLong count;
+        private final AtomicLong count;
 
         public CountingAuthHandler() {
             super();

Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientReauthentication.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientReauthentication.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientReauthentication.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestClientReauthentication.java
Sun Jan 13 04:49:33 2013
@@ -99,7 +99,7 @@ public class TestClientReauthentication 
 
     static class AuthHandler implements HttpRequestHandler {
 
-        private AtomicLong count = new AtomicLong(0);
+        private final AtomicLong count = new AtomicLong(0);
 
         public void handle(
                 final HttpRequest request,

Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestRedirects.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestRedirects.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestRedirects.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/integration/TestRedirects.java
Sun Jan 13 04:49:33 2013
@@ -186,7 +186,7 @@ public class TestRedirects extends Integ
     }
 
     private static class BogusRedirectService implements HttpRequestHandler {
-        private String url;
+        private final String url;
 
         public BogusRedirectService(String redirectUrl) {
             super();

Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentBufferEntity.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentBufferEntity.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentBufferEntity.java
(original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/main/java/org/apache/http/nio/entity/ContentBufferEntity.java
Sun Jan 13 04:49:33 2013
@@ -43,7 +43,7 @@ import org.apache.http.util.Args;
 @NotThreadSafe
 public class ContentBufferEntity extends BasicHttpEntity {
 
-    private HttpEntity wrappedEntity;
+    private final HttpEntity wrappedEntity;
 
     /**
      * Creates new instance of ContentBufferEntity.

Modified: httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestSessionInOutBuffers.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestSessionInOutBuffers.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestSessionInOutBuffers.java
(original)
+++ httpcomponents/httpcore/trunk/httpcore-nio/src/test/java/org/apache/http/impl/nio/reactor/TestSessionInOutBuffers.java
Sun Jan 13 04:49:33 2013
@@ -60,7 +60,7 @@ import org.junit.runners.Parameterized.P
 @RunWith(Parameterized.class)
 public class TestSessionInOutBuffers {
 
-    private ByteBufferAllocator allocator;
+    private final ByteBufferAllocator allocator;
 
     public TestSessionInOutBuffers(final ByteBufferAllocator allocator) {
         super();

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ChunkedOutputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ChunkedOutputStream.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ChunkedOutputStream.java
(original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ChunkedOutputStream.java
Sun Jan 13 04:49:33 2013
@@ -51,7 +51,7 @@ public class ChunkedOutputStream extends
     // ----------------------------------------------------- Instance Variables
     private final SessionOutputBuffer out;
 
-    private byte[] cache;
+    private final byte[] cache;
 
     private int cachePosition = 0;
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
(original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
Sun Jan 13 04:49:33 2013
@@ -60,7 +60,7 @@ public class ContentLengthInputStream ex
      * The maximum number of bytes that can be read from the stream. Subsequent
      * read operations will return -1.
      */
-    private long contentLength;
+    private final long contentLength;
 
     /** The current position */
     private long pos = 0;

Modified: httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java
(original)
+++ httpcomponents/httpcore/trunk/httpcore/src/main/java/org/apache/http/message/BasicHttpResponse.java
Sun Jan 13 04:49:33 2013
@@ -55,7 +55,7 @@ public class BasicHttpResponse extends A
     private int                 code;
     private String              reasonPhrase;
     private HttpEntity          entity;
-    private ReasonPhraseCatalog reasonCatalog;
+    private final ReasonPhraseCatalog reasonCatalog;
     private Locale              locale;
 
     /**

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/TestNoConnectionReuseStrategy.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/TestNoConnectionReuseStrategy.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/TestNoConnectionReuseStrategy.java
(original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/impl/TestNoConnectionReuseStrategy.java
Sun Jan 13 04:49:33 2013
@@ -38,7 +38,7 @@ import org.mockito.MockitoAnnotations;
 
 public class TestNoConnectionReuseStrategy {
 
-    private NoConnectionReuseStrategy strat = new NoConnectionReuseStrategy();
+    private final NoConnectionReuseStrategy strat = new NoConnectionReuseStrategy();
     @Mock private HttpResponse response;
     @Mock private HttpContext context;
 

Modified: httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java?rev=1432552&r1=1432551&r2=1432552&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java
(original)
+++ httpcomponents/httpcore/trunk/httpcore/src/test/java/org/apache/http/integration/TestSyncHttp.java
Sun Jan 13 04:49:33 2013
@@ -601,7 +601,7 @@ public class TestSyncHttp {
     static class RepeatingEntity extends AbstractHttpEntity {
 
         private final byte[] raw;
-        private int n;
+        private final int n;
 
         public RepeatingEntity(final String content, Charset charset, int n) {
             super();



Mime
View raw message