Return-Path: X-Original-To: apmail-hc-commits-archive@www.apache.org Delivered-To: apmail-hc-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6223745A for ; Mon, 10 Oct 2011 20:18:45 +0000 (UTC) Received: (qmail 81388 invoked by uid 500); 10 Oct 2011 20:18:45 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 81358 invoked by uid 500); 10 Oct 2011 20:18:45 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 81351 invoked by uid 99); 10 Oct 2011 20:18:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Oct 2011 20:18:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Oct 2011 20:18:44 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 7278F23888FD for ; Mon, 10 Oct 2011 20:18:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1181208 - /httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/PoolingClientConnectionManager.java Date: Mon, 10 Oct 2011 20:18:24 -0000 To: commits@hc.apache.org From: olegk@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20111010201824.7278F23888FD@eris.apache.org> Author: olegk Date: Mon Oct 10 20:18:24 2011 New Revision: 1181208 URL: http://svn.apache.org/viewvc?rev=1181208&view=rev Log: HTTPCLIENT-1123: fixed broken PoolingClientConnectionManager constructor Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/PoolingClientConnectionManager.java Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/PoolingClientConnectionManager.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/PoolingClientConnectionManager.java?rev=1181208&r1=1181207&r2=1181208&view=diff ============================================================================== --- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/PoolingClientConnectionManager.java (original) +++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/PoolingClientConnectionManager.java Mon Oct 10 20:18:24 2011 @@ -96,14 +96,7 @@ public class PoolingClientConnectionMana public PoolingClientConnectionManager( final SchemeRegistry schemeRegistry, final long timeToLive, final TimeUnit tunit) { - super(); - if (schemeRegistry == null) { - throw new IllegalArgumentException("Scheme registry may not be null"); - } - this.schemeRegistry = schemeRegistry; - this.dnsResolver = new SystemDefaultDnsResolver(); - this.operator = createConnectionOperator(schemeRegistry); - this.pool = new HttpConnPool(this.log, 2, 20, timeToLive, tunit); + this(schemeRegistry, timeToLive, tunit, new SystemDefaultDnsResolver()); } public PoolingClientConnectionManager(final SchemeRegistry schemeRegistry, @@ -114,7 +107,7 @@ public class PoolingClientConnectionMana throw new IllegalArgumentException("Scheme registry may not be null"); } this.schemeRegistry = schemeRegistry; - this.dnsResolver = new SystemDefaultDnsResolver(); + this.dnsResolver = dnsResolver; this.operator = createConnectionOperator(schemeRegistry); this.pool = new HttpConnPool(this.log, 2, 20, timeToLive, tunit); }