Return-Path: Delivered-To: apmail-hc-commits-archive@www.apache.org Received: (qmail 36576 invoked from network); 11 May 2010 20:31:14 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 May 2010 20:31:14 -0000 Received: (qmail 56241 invoked by uid 500); 11 May 2010 20:31:14 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 56216 invoked by uid 500); 11 May 2010 20:31:14 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 56209 invoked by uid 99); 11 May 2010 20:31:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 May 2010 20:31:14 +0000 X-ASF-Spam-Status: No, hits=-1548.4 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 May 2010 20:31:13 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id C198C23889B6; Tue, 11 May 2010 20:30:52 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r943281 - /httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/HttpTestUtils.java Date: Tue, 11 May 2010 20:30:52 -0000 To: commits@hc.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100511203052.C198C23889B6@eris.apache.org> Author: sebb Date: Tue May 11 20:30:52 2010 New Revision: 943281 URL: http://svn.apache.org/viewvc?rev=943281&view=rev Log: Make constants final. Not used outside class, so don't expose mutable arrays Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/HttpTestUtils.java Modified: httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/HttpTestUtils.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/HttpTestUtils.java?rev=943281&r1=943280&r2=943281&view=diff ============================================================================== --- httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/HttpTestUtils.java (original) +++ httpcomponents/httpclient/trunk/httpclient-cache/src/test/java/org/apache/http/client/cache/impl/HttpTestUtils.java Tue May 11 20:30:52 2010 @@ -43,7 +43,7 @@ public class HttpTestUtils { * * @see http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.5.1 */ - public static String[] HOP_BY_HOP_HEADERS = { "Connection", "Keep-Alive", "Proxy-Authenticate", + private static final String[] HOP_BY_HOP_HEADERS = { "Connection", "Keep-Alive", "Proxy-Authenticate", "Proxy-Authorization", "TE", "Trailers", "Transfer-Encoding", "Upgrade" }; /* @@ -53,11 +53,11 @@ public class HttpTestUtils { * * @see http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 */ - public static String[] MULTI_HEADERS = { "Accept", "Accept-Charset", "Accept-Encoding", + private static final String[] MULTI_HEADERS = { "Accept", "Accept-Charset", "Accept-Encoding", "Accept-Language", "Allow", "Cache-Control", "Connection", "Content-Encoding", "Content-Language", "Expect", "Pragma", "Proxy-Authenticate", "TE", "Trailer", "Transfer-Encoding", "Upgrade", "Via", "Warning", "WWW-Authenticate" }; - public static String[] SINGLE_HEADERS = { "Accept-Ranges", "Age", "Authorization", + private static final String[] SINGLE_HEADERS = { "Accept-Ranges", "Age", "Authorization", "Content-Length", "Content-Location", "Content-MD5", "Content-Range", "Content-Type", "Date", "ETag", "Expires", "From", "Host", "If-Match", "If-Modified-Since", "If-None-Match", "If-Range", "If-Unmodified-Since", "Last-Modified", "Location",