hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ol...@apache.org
Subject svn commit: r829791 - in /httpcomponents/httpclient/trunk: RELEASE_NOTES.txt httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
Date Mon, 26 Oct 2009 13:38:39 GMT
Author: olegk
Date: Mon Oct 26 13:38:39 2009
New Revision: 829791

URL: http://svn.apache.org/viewvc?rev=829791&view=rev
Log:
HTTPCLIENT-882: Auth state is not correctly updated if a successful NTLM authentication results
in a redirect

Modified:
    httpcomponents/httpclient/trunk/RELEASE_NOTES.txt
    httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java

Modified: httpcomponents/httpclient/trunk/RELEASE_NOTES.txt
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/RELEASE_NOTES.txt?rev=829791&r1=829790&r2=829791&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/RELEASE_NOTES.txt (original)
+++ httpcomponents/httpclient/trunk/RELEASE_NOTES.txt Mon Oct 26 13:38:39 2009
@@ -1,6 +1,11 @@
 Changes since 4.0
 -------------------
 
+* [HTTPCLIENT-882] Auth state is not correctly updated if a successful NTLM 
+  authentication results in a redirect. This is a minor bug as HttpClient manages
+  to recover from the problem automatically.
+  Contributed by Oleg Kalnichevski <olegk at apache.org>
+
 * [HTTPCLIENT-881] Fixed race condition in AbstractClientConnAdapter that makes it
   possible for an aborted connection to be returned to the pool.
   Contributed by Tim Boemker <tboemker at elynx.com> and 

Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java?rev=829791&r1=829790&r2=829791&view=diff
==============================================================================
--- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
(original)
+++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/DefaultRequestDirector.java
Mon Oct 26 13:38:39 2009
@@ -951,6 +951,11 @@
                     uri.getPort(),
                     uri.getScheme());
             
+            // Unset auth scope
+            targetAuthState.setAuthScope(null);
+            proxyAuthState.setAuthScope(null);
+            
+            // Invalidate auth states if redirecting to another host
             if (!route.getTargetHost().equals(newTarget)) {
                 targetAuthState.invalidate();
                 AuthScheme authScheme = proxyAuthState.getAuthScheme();



Mime
View raw message