Return-Path: Delivered-To: apmail-hc-commits-archive@www.apache.org Received: (qmail 17109 invoked from network); 23 Jul 2009 22:43:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Jul 2009 22:43:51 -0000 Received: (qmail 33987 invoked by uid 500); 23 Jul 2009 22:44:56 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 33955 invoked by uid 500); 23 Jul 2009 22:44:56 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 33946 invoked by uid 99); 23 Jul 2009 22:44:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2009 22:44:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2009 22:44:54 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6A3B923888DA; Thu, 23 Jul 2009 22:44:34 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r797254 - /httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java Date: Thu, 23 Jul 2009 22:44:34 -0000 To: commits@hc.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090723224434.6A3B923888DA@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Thu Jul 23 22:44:34 2009 New Revision: 797254 URL: http://svn.apache.org/viewvc?rev=797254&view=rev Log: Document thread-safety of final fields Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java?rev=797254&r1=797253&r2=797254&view=diff ============================================================================== --- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java (original) +++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java Thu Jul 23 22:44:34 2009 @@ -75,13 +75,13 @@ private final Log log = LogFactory.getLog(getClass()); /** The schemes supported by this connection manager. */ - protected final SchemeRegistry schemeRegistry; + protected final SchemeRegistry schemeRegistry; // @ThreadSafe /** The pool of connections being managed. */ protected final AbstractConnPool connectionPool; /** The operator for opening and updating connections. */ - protected final ClientConnectionOperator connOperator; + protected final ClientConnectionOperator connOperator; // DefaultClientConnectionOperator is @ThreadSafe /** * Creates a new thread safe connection manager. @@ -137,7 +137,7 @@ protected ClientConnectionOperator createConnectionOperator(SchemeRegistry schreg) { - return new DefaultClientConnectionOperator(schreg); + return new DefaultClientConnectionOperator(schreg);// @ThreadSafe } public SchemeRegistry getSchemeRegistry() {