Return-Path: Delivered-To: apmail-hc-commits-archive@www.apache.org Received: (qmail 64655 invoked from network); 1 Dec 2008 14:36:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Dec 2008 14:36:53 -0000 Received: (qmail 57818 invoked by uid 500); 1 Dec 2008 14:37:04 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 57787 invoked by uid 500); 1 Dec 2008 14:37:04 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 57777 invoked by uid 99); 1 Dec 2008 14:37:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2008 06:37:04 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2008 14:35:44 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 545D82388975; Mon, 1 Dec 2008 06:36:32 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r722083 - in /httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing: TestHttpRoute.java TestRouteTracker.java Date: Mon, 01 Dec 2008 14:36:32 -0000 To: commits@hc.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20081201143632.545D82388975@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: sebb Date: Mon Dec 1 06:36:31 2008 New Revision: 722083 URL: http://svn.apache.org/viewvc?rev=722083&view=rev Log: Integer.valueOf() is cheaper than new Integer() Modified: httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestHttpRoute.java httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java Modified: httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestHttpRoute.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestHttpRoute.java?rev=722083&r1=722082&r2=722083&view=diff ============================================================================== --- httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestHttpRoute.java (original) +++ httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestHttpRoute.java Mon Dec 1 06:36:31 2008 @@ -223,14 +223,14 @@ // we can't test hashCode in general due to it's dependency // on InetAddress and HttpHost, but we can check for the flags Set routecodes = new HashSet(); - routecodes.add(new Integer(routefff.hashCode())); - routecodes.add(new Integer(routefft.hashCode())); - routecodes.add(new Integer(routeftf.hashCode())); - routecodes.add(new Integer(routeftt.hashCode())); - routecodes.add(new Integer(routetff.hashCode())); - routecodes.add(new Integer(routetft.hashCode())); - routecodes.add(new Integer(routettf.hashCode())); - routecodes.add(new Integer(routettt.hashCode())); + routecodes.add(Integer.valueOf(routefff.hashCode())); + routecodes.add(Integer.valueOf(routefft.hashCode())); + routecodes.add(Integer.valueOf(routeftf.hashCode())); + routecodes.add(Integer.valueOf(routeftt.hashCode())); + routecodes.add(Integer.valueOf(routetff.hashCode())); + routecodes.add(Integer.valueOf(routetft.hashCode())); + routecodes.add(Integer.valueOf(routettf.hashCode())); + routecodes.add(Integer.valueOf(routettt.hashCode())); assertEquals("some flagged routes have same hashCode", 8, routecodes.size()); Modified: httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java?rev=722083&r1=722082&r2=722083&view=diff ============================================================================== --- httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java (original) +++ httpcomponents/httpclient/trunk/module-client/src/test/java/org/apache/http/conn/routing/TestRouteTracker.java Mon Dec 1 06:36:31 2008 @@ -436,19 +436,19 @@ assertTrue(hs.add(rt4)); assertTrue(hs.add(rt6)); - assertTrue(hc0.add(new Integer(rt0.hashCode()))); - assertTrue(hc4.add(new Integer(rt4.hashCode()))); - assertTrue(hc6.add(new Integer(rt6.hashCode()))); + assertTrue(hc0.add(Integer.valueOf(rt0.hashCode()))); + assertTrue(hc4.add(Integer.valueOf(rt4.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt6.hashCode()))); rt = (RouteTracker) rt0.clone(); rt.connectTarget(false); assertTrue(hs.add(rt)); - assertTrue(hc0.add(new Integer(rt.hashCode()))); + assertTrue(hc0.add(Integer.valueOf(rt.hashCode()))); rt = (RouteTracker) rt0.clone(); rt.connectTarget(true); assertTrue(hs.add(rt)); - assertTrue(hc0.add(new Integer(rt.hashCode()))); + assertTrue(hc0.add(Integer.valueOf(rt.hashCode()))); // proxy (insecure) -> tunnel (insecure) -> layer (secure) @@ -456,15 +456,15 @@ rt.connectProxy(PROXY1, false); assertTrue(hs.add((RouteTracker) rt.clone())); // this is not guaranteed to be unique... - assertTrue(hc4.add(new Integer(rt.hashCode()))); + assertTrue(hc4.add(Integer.valueOf(rt.hashCode()))); rt.tunnelTarget(false); assertTrue(hs.add((RouteTracker) rt.clone())); - assertTrue(hc4.add(new Integer(rt.hashCode()))); + assertTrue(hc4.add(Integer.valueOf(rt.hashCode()))); rt.layerProtocol(true); assertTrue(hs.add((RouteTracker) rt.clone())); - assertTrue(hc4.add(new Integer(rt.hashCode()))); + assertTrue(hc4.add(Integer.valueOf(rt.hashCode()))); // proxy (secure) -> tunnel (secure) -> layer (insecure) @@ -472,15 +472,15 @@ rt.connectProxy(PROXY1, true); assertTrue(hs.add((RouteTracker) rt.clone())); // this is not guaranteed to be unique... - assertTrue(hc4.add(new Integer(rt.hashCode()))); + assertTrue(hc4.add(Integer.valueOf(rt.hashCode()))); rt.tunnelTarget(true); assertTrue(hs.add((RouteTracker) rt.clone())); - assertTrue(hc4.add(new Integer(rt.hashCode()))); + assertTrue(hc4.add(Integer.valueOf(rt.hashCode()))); rt.layerProtocol(false); assertTrue(hs.add((RouteTracker) rt.clone())); - assertTrue(hc4.add(new Integer(rt.hashCode()))); + assertTrue(hc4.add(Integer.valueOf(rt.hashCode()))); // PROXY1/i -> PROXY2/i -> tunnel/i -> layer/s @@ -488,20 +488,20 @@ rt.connectProxy(PROXY1, false); assertTrue(hs.add((RouteTracker) rt.clone())); // this is not guaranteed to be unique... - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.tunnelProxy(PROXY2, false); assertTrue(hs.add((RouteTracker) rt.clone())); // this is not guaranteed to be unique... - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.tunnelTarget(false); assertTrue(hs.add((RouteTracker) rt.clone())); - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.layerProtocol(true); assertTrue(hs.add((RouteTracker) rt.clone())); - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); // PROXY1/s -> PROXY2/s -> tunnel/s -> layer/i @@ -509,20 +509,20 @@ rt.connectProxy(PROXY1, true); assertTrue(hs.add((RouteTracker) rt.clone())); // this is not guaranteed to be unique... - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.tunnelProxy(PROXY2, true); assertTrue(hs.add((RouteTracker) rt.clone())); // this is not guaranteed to be unique... - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.tunnelTarget(true); assertTrue(hs.add((RouteTracker) rt.clone())); - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.layerProtocol(false); assertTrue(hs.add((RouteTracker) rt.clone())); - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); // PROXY2/i -> PROXY1/i -> tunnel/i -> layer/s @@ -530,22 +530,22 @@ rt.connectProxy(PROXY2, false); assertTrue(hs.add((RouteTracker) rt.clone())); // this is not guaranteed to be unique... - assertTrue(hc6.add(new Integer(rt.hashCode()))); + assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.tunnelProxy(PROXY1, false); assertTrue(hs.add((RouteTracker) rt.clone())); // proxy chain sequence does not affect hashcode, so duplicate: - // assertTrue(hc6.add(new Integer(rt.hashCode()))); + // assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.tunnelTarget(false); assertTrue(hs.add((RouteTracker) rt.clone())); // proxy chain sequence does not affect hashcode, so duplicate: - // assertTrue(hc6.add(new Integer(rt.hashCode()))); + // assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); rt.layerProtocol(true); assertTrue(hs.add((RouteTracker) rt.clone())); // proxy chain sequence does not affect hashcode, so duplicate: - // assertTrue(hc6.add(new Integer(rt.hashCode()))); + // assertTrue(hc6.add(Integer.valueOf(rt.hashCode()))); // check that all toString are OK and different