Return-Path: Delivered-To: apmail-hc-commits-archive@www.apache.org Received: (qmail 76620 invoked from network); 10 Aug 2008 19:44:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Aug 2008 19:44:39 -0000 Received: (qmail 769 invoked by uid 500); 10 Aug 2008 19:44:38 -0000 Delivered-To: apmail-hc-commits-archive@hc.apache.org Received: (qmail 747 invoked by uid 500); 10 Aug 2008 19:44:38 -0000 Mailing-List: contact commits-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list commits@hc.apache.org Received: (qmail 738 invoked by uid 99); 10 Aug 2008 19:44:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Aug 2008 12:44:38 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Aug 2008 19:43:44 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 8661923889E3; Sun, 10 Aug 2008 12:44:12 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r684579 - /httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java Date: Sun, 10 Aug 2008 19:44:12 -0000 To: commits@hc.apache.org From: olegk@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080810194412.8661923889E3@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: olegk Date: Sun Aug 10 12:44:11 2008 New Revision: 684579 URL: http://svn.apache.org/viewvc?rev=684579&view=rev Log: HTTPCORE-168: BasicNameValuePair made Serializable Contributed by Sanne Grinovero Modified: httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java Modified: httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java?rev=684579&r1=684578&r2=684579&view=diff ============================================================================== --- httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java (original) +++ httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/message/BasicNameValuePair.java Sun Aug 10 12:44:11 2008 @@ -31,6 +31,8 @@ package org.apache.http.message; +import java.io.Serializable; + import org.apache.http.NameValuePair; import org.apache.http.util.CharArrayBuffer; import org.apache.http.util.LangUtils; @@ -103,7 +105,9 @@ * @author Oleg Kalnichevski * */ -public class BasicNameValuePair implements NameValuePair, Cloneable { +public class BasicNameValuePair implements NameValuePair, Cloneable, Serializable { + + private static final long serialVersionUID = -6437800749411518984L; private final String name; private final String value; @@ -149,18 +153,17 @@ */ public String toString() { // don't call complex default formatting for a simple toString - - int len = this.name.length(); - if (this.value != null) - len += 1 + this.value.length(); - CharArrayBuffer buffer = new CharArrayBuffer(len); - - buffer.append(this.name); - if (this.value != null) { + + if (this.value == null) { + return name; + } else { + int len = this.name.length() + 1 + this.value.length(); + CharArrayBuffer buffer = new CharArrayBuffer(len); + buffer.append(this.name); buffer.append("="); buffer.append(this.value); + return buffer.toString(); } - return buffer.toString(); } public boolean equals(final Object object) {