hc-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r652091 - in /httpcomponents/httpcore/trunk/module-main/src: main/java/org/apache/http/impl/io/ test/java/org/apache/http/mockup/
Date Tue, 29 Apr 2008 20:41:07 GMT
Author: sebb
Date: Tue Apr 29 13:41:07 2008
New Revision: 652091

URL: http://svn.apache.org/viewvc?rev=652091&view=rev
Log:
HTTPCORE-160 - Static variables need to be final

Modified:
    httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/AbstractSessionOutputBuffer.java
    httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
    httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionInputBufferMockup.java
    httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionOutputBufferMockup.java

Modified: httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/AbstractSessionOutputBuffer.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/AbstractSessionOutputBuffer.java?rev=652091&r1=652090&r2=652091&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/AbstractSessionOutputBuffer.java
(original)
+++ httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/AbstractSessionOutputBuffer.java
Tue Apr 29 13:41:07 2008
@@ -53,7 +53,7 @@
 
     private static final byte[] CRLF = new byte[] {HTTP.CR, HTTP.LF};
     
-    private static int MAX_CHUNK = 256;
+    private static final int MAX_CHUNK = 256;
     
     private OutputStream outstream;
     private ByteArrayBuffer buffer;

Modified: httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java?rev=652091&r1=652090&r2=652091&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
(original)
+++ httpcomponents/httpcore/trunk/module-main/src/main/java/org/apache/http/impl/io/ContentLengthInputStream.java
Tue Apr 29 13:41:07 2008
@@ -70,7 +70,7 @@
  */
 public class ContentLengthInputStream extends InputStream {
     
-    private static int BUFFER_SIZE = 2048;
+    private static final int BUFFER_SIZE = 2048;
     /**
      * The maximum number of bytes that can be read from the stream. Subsequent
      * read operations will return -1.

Modified: httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionInputBufferMockup.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionInputBufferMockup.java?rev=652091&r1=652090&r2=652091&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionInputBufferMockup.java
(original)
+++ httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionInputBufferMockup.java
Tue Apr 29 13:41:07 2008
@@ -47,7 +47,7 @@
  */
 public class SessionInputBufferMockup extends AbstractSessionInputBuffer {
 
-    public static int BUFFER_SIZE = 16;
+    public static final int BUFFER_SIZE = 16;
     
     public SessionInputBufferMockup(
             final InputStream instream, 

Modified: httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionOutputBufferMockup.java
URL: http://svn.apache.org/viewvc/httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionOutputBufferMockup.java?rev=652091&r1=652090&r2=652091&view=diff
==============================================================================
--- httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionOutputBufferMockup.java
(original)
+++ httpcomponents/httpcore/trunk/module-main/src/test/java/org/apache/http/mockup/SessionOutputBufferMockup.java
Tue Apr 29 13:41:07 2008
@@ -46,7 +46,7 @@
 public class SessionOutputBufferMockup extends AbstractSessionOutputBuffer {
 
     private ByteArrayOutputStream buffer = new ByteArrayOutputStream();
-    public static int BUFFER_SIZE = 16;
+    public static final int BUFFER_SIZE = 16;
     
     public SessionOutputBufferMockup(
             final OutputStream outstream, 



Mime
View raw message