Return-Path: Delivered-To: apmail-jakarta-httpclient-commits-archive@www.apache.org Received: (qmail 35488 invoked from network); 7 Jan 2006 21:55:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Jan 2006 21:55:37 -0000 Received: (qmail 60391 invoked by uid 500); 7 Jan 2006 21:55:36 -0000 Mailing-List: contact httpclient-commits-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: httpclient-dev@jakarta.apache.org Delivered-To: mailing list httpclient-commits@jakarta.apache.org Received: (qmail 60379 invoked by uid 99); 7 Jan 2006 21:55:36 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Jan 2006 13:55:36 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [209.237.227.194] (HELO minotaur.apache.org) (209.237.227.194) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 07 Jan 2006 13:55:36 -0800 Received: (qmail 35445 invoked by uid 65534); 7 Jan 2006 21:55:15 -0000 Message-ID: <20060107215515.35444.qmail@minotaur.apache.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r366930 - /jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/impl/HeaderGroup.java Date: Sat, 07 Jan 2006 21:55:15 -0000 To: httpclient-commits@jakarta.apache.org From: olegk@apache.org X-Mailer: svnmailer-1.0.5 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: olegk Date: Sat Jan 7 13:55:04 2006 New Revision: 366930 URL: http://svn.apache.org/viewcvs?rev=366930&view=rev Log: Do not use iterator for better reasons Modified: jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/impl/HeaderGroup.java Modified: jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/impl/HeaderGroup.java URL: http://svn.apache.org/viewcvs/jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/impl/HeaderGroup.java?rev=366930&r1=366929&r2=366930&view=diff ============================================================================== --- jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/impl/HeaderGroup.java (original) +++ jakarta/httpcomponents/trunk/http-core/src/java/org/apache/http/impl/HeaderGroup.java Sat Jan 7 13:55:04 2006 @@ -141,8 +141,8 @@ public Header[] getHeaders(String name) { ArrayList headersFound = new ArrayList(); - for (Iterator headerIter = headers.iterator(); headerIter.hasNext();) { - Header header = (Header) headerIter.next(); + for (int i = 0; i < headers.size(); i++) { + Header header = (Header) headers.get(i); if (header.getName().equalsIgnoreCase(name)) { headersFound.add(header); } @@ -209,8 +209,8 @@ * contained, false otherwise */ public boolean containsHeader(String name) { - for (Iterator headerIter = headers.iterator(); headerIter.hasNext();) { - Header header = (Header) headerIter.next(); + for (int i = 0; i < headers.size(); i++) { + Header header = (Header) headers.get(i); if (header.getName().equalsIgnoreCase(name)) { return true; }