From user-return-55766-archive-asf-public=cust-asf.ponee.io@hbase.apache.org Mon Mar 11 12:28:50 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D2273180657 for ; Mon, 11 Mar 2019 13:28:49 +0100 (CET) Received: (qmail 79671 invoked by uid 500); 11 Mar 2019 12:28:48 -0000 Mailing-List: contact user-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: user@hbase.apache.org Delivered-To: mailing list user@hbase.apache.org Received: (qmail 79572 invoked by uid 99); 11 Mar 2019 12:28:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Mar 2019 12:28:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 4926FC23CE for ; Mon, 11 Mar 2019 12:28:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.799 X-Spam-Level: * X-Spam-Status: No, score=1.799 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id kyU5Pq5ADbL1 for ; Mon, 11 Mar 2019 12:28:45 +0000 (UTC) Received: from mail-yw1-f43.google.com (mail-yw1-f43.google.com [209.85.161.43]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 315626112A for ; Mon, 11 Mar 2019 12:11:55 +0000 (UTC) Received: by mail-yw1-f43.google.com with SMTP id e76so3627509ywa.9 for ; Mon, 11 Mar 2019 05:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Klabu3HpZUNzE65tqJzYpTgmYtKXEeUBGk4sGN5OSeE=; b=JVr915EhlqFlJJ7fFtLh6Alwh70vZv2UBBSunoi5dd9fKyv2obuaxVme6OhVflVqWi chYBO41rcSEqalKJCs19Cj8Hx2CSZ8/9jeQ6156NKfGtrB7YW+p8HsHEbEJgOV9Os+y8 kWLeFfrcFUFqRDZ6XhAzdt9ITJHPZ/L2Tqg3nSjQ/tqUGu7lwnHQOE+1xqawwr9gmMui MrtFTIiBubyvQ0NI6AvrSZPEwgRl2NUBAUPZUBmZH6TdgMqijle2jnE9v92HOO/85nut KBb3mPb2VML5bB6eJ0fy8ROGWN43QBvK+ONgzuyE3zqFYTV9jKL5hiIhu8qprkMRUVLt FBsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Klabu3HpZUNzE65tqJzYpTgmYtKXEeUBGk4sGN5OSeE=; b=Hl4fOyTj0+HoDFjuYsY0f1RcRAYgL6ekci5JmpWfgtEZ82WsUAXR58hJMlVU6uHvNx dABoELINBpfuPk+6WO92A7yXONhG1wMWaqwVNYzrkTAqt/Z1N8TNQs1aCocAF9lLAlBY 8ZBXRdc8PspvrVbAxWBBEKiIjEzXMghAgAbCBPSYR941ABgyiQs/q2z7/P/1DjyVywTG 66hWkjNmnU7R9wKblpDm342DbDKg6vWgmKNMggk0B0jRhY9GvIU0I7YAFpXppIsnFcNz JqFB1FVtUywVnVR/pyq+q9mtUiN9kmmGIgMu3z2hePqoQip0qsWqAY4w4DQKj9/9m/R9 00SA== X-Gm-Message-State: APjAAAWd9q9pHMWa3U3m0i6lw2HftQX38MyJn8o3m2n7JYZOvPwm3pzo AZVZqJx1nxaZenSle8PqvBMHDRZXYYdEnjsri4H0rw== X-Google-Smtp-Source: APXvYqw0nL2B0iWkHjzmOO0CI5PD1SpwnDF11Y6uZg5AOCF+s2LwcBLQ+n72mS4znaCs4+FkTkR+iChYrR/qgMllS+c= X-Received: by 2002:a25:7289:: with SMTP id n131mr25540440ybc.352.1552306309095; Mon, 11 Mar 2019 05:11:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Wellington Chevreuil Date: Mon, 11 Mar 2019 12:11:12 +0000 Message-ID: Subject: Re: Region flush delayed even memstore size above MEMSTORE_FLUSH config. To: user@hbase.apache.org Content-Type: multipart/alternative; boundary="00000000000022e80e0583d07ac0" --00000000000022e80e0583d07ac0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Well, there would be already a flush request for the region in the queue anyway, and this would force flush of all stores, so doesn't look adding an additional request would have any benefit, does it? Em seg, 11 de mar de 2019 =C3=A0s 04:22, Kang Minwoo escreveu: > Hello Users. > > --- > HBase version is 1.2.9 > --- > > I wonder this region operation is intended. > > I set "hbase.regionserver.optionalcacheflushinterval" slightly shorter > than the default setting. > So cf has old edit, they flush after a random delay. > > If the flush queue has a flush request by old edit, a flush request by > memstore size above MEMSTORE_FLUSH config in the same region is ignored. > Because region already has in regionsInQueue. > > As a result, memstore size increase until random delay. > > I think a flush request by memstore size above MEMSTORE_FLUSH config is a > higher priority than a flush request by old edit. > > > Here are related codes. > > --- > @Override > public void requestFlush(Region r, boolean forceFlushAllStores) { > synchronized (regionsInQueue) { > if (!regionsInQueue.containsKey(r)) { // <- Here > FlushRegionEntry fqe =3D new FlushRegionEntry(r, > forceFlushAllStores); > this.regionsInQueue.put(r, fqe); > this.flushQueue.add(fqe); > } > } > } > > @Override > public void requestDelayedFlush(Region r, long delay, boolean > forceFlushAllStores) { > synchronized (regionsInQueue) { > if (!regionsInQueue.containsKey(r)) { // <- Here > FlushRegionEntry fqe =3D new FlushRegionEntry(r, > forceFlushAllStores); > fqe.requeue(delay); > this.regionsInQueue.put(r, fqe); > this.flushQueue.add(fqe); > } > } > } > --- > > Best regards, > Minwoo Kang > --00000000000022e80e0583d07ac0--