hbase-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steen Manniche <boxun...@gmail.com>
Subject Re: request for review of patch
Date Tue, 11 Apr 2017 15:35:46 GMT
Hi Yu,

thanks for your suggestions. I wil upload the patch to reviewboard,
and take it from there.

And, yes - I did read the developing section in the hbase book, but
perhaps through not reading thorough enough, ended up in this

Best regards,

On Thu, Apr 6, 2017 at 10:23 AM, Yu Li <carp84@gmail.com> wrote:
> Hi Steen,
> First of all, you need to get some review comments on the patch, normally
> we recommend to post a request on ReviewBoard
> <https://reviews.apache.org/dashboard/> instead of simply attaching the
> patch on JIRA so as to draw committers' attention. Make sure to add *hbase*
> into reviewer group, take this one <https://reviews.apache.org/r/57379/> as
> an example.
> After resolving all review comments, you could simply press the "Submit
> Patch" button on JIRA, then HadoopQA will get triggered automatically and
> run UT against your patch.
> If no issue reported by HadoopQA and the patch has got more than two
> committers' +1, it's ready to be committed.
> Check more details on http://hbase.apache.org/book.html#developing (it
> seems we need some more doc on the process though...)
> W.r.t. HBASE-17817, I'd suggest to upload the patch onto review board first
> to draw more attentions.
> Best Regards,
> Yu
> On 6 April 2017 at 15:53, Steen Manniche <boxunbox@gmail.com> wrote:
>> Hi list,
>> I created and attached a patch to HBASE-17817 but I am unsure about
>> the process from here. I was under the impression that the build
>> server would pick up newly attached patches and test them, thus
>> putting it in some sort of pipeline, but I can see that this is
>> probably not going to happen.
>> What should I do from here?
>> Best,
>> Steen Manniche

View raw message