Mailing-List: contact user-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of serega.sheypak@gmail.com
 designates 209.85.217.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CALte62wpqSB0k-XyBVDqyLH6_8gT0qBWj9av_nC6xmEEXCf7fQ@mail.gmail.com>
References: 
 <CABNOTEUP+RHLNbREaYacmscdwOEmJ8i4_U+LCzyys9goN_0OFQ@mail.gmail.com>
 <CABNOTEUFm_65VAbJawumjiKVYBmk=JWXDV5R3F98Kz8LH36PCg@mail.gmail.com>
 <CALte62xnWsV4GJWxJdZJWg9tSCyWbUUqhN9DbzE=p9X2Y-eQ-g@mail.gmail.com>
 <CABNOTEUTA9nXtjspb1frfJWfz+SoVqbctFUcq0VCQs-di3pktQ@mail.gmail.com>
 <CALte62wpqSB0k-XyBVDqyLH6_8gT0qBWj9av_nC6xmEEXCf7fQ@mail.gmail.com>
From: Serega Sheypak <serega.sheypak@gmail.com>
Date: Fri, 3 Oct 2014 20:29:03 +0400
Message-ID: 
 <CABNOTEXwt=NCpJ3FHpW5Xb0ZCMe5fOn3Tq14bLzmMn+RPwpwHg@mail.gmail.com>
Subject: Re: Splits are not preserved during table copy using
 getAdmin().createTable(tableDescriptor);
To: user <user@hbase.apache.org>
Content-Type: multipart/alternative; boundary=089e0158c9645e342c0504873cd2

--089e0158c9645e342c0504873cd2
Content-Type: text/plain; charset=UTF-8

So easy, thanks :) I've missed that method.

2014-10-03 20:23 GMT+04:00 Ted Yu <yuzhihong@gmail.com>:

> You can simplify your code by utilizing the following from HTable:
>
>   public byte [][] getStartKeys() throws IOException {
>
> No need to sort the keys.
>
> Cheers
>
> On Fri, Oct 3, 2014 at 9:10 AM, Serega Sheypak <serega.sheypak@gmail.com>
> wrote:
>
> > Thanks, I'm already updated my end-to-end test, waiting for the result.
> >
> > Here is my code snippet, is it ok?
> >
> >  @SneakyThrows(IOException.class)
> >     private byte[][] collectSplits(String tableName){
> >         HTable table = new HTable(configuration, tableName);
> >         int splitSize =
> > table.getRegionLocations().descendingKeySet().size();
> >
> >         if(splitSize < 2){
> >             LOG.info(String.format("There is only one region for a
> > table[%s]. No splits to recreate", tableName));
> >             return new byte[][]{};
> >         }
> >         LOG.info(String.format("There are [%s] regions for a table[%s].
> > Skip pre-splitting", splitSize, tableName));
> >
> >         byte[][] splits = new byte[splitSize][];
> >       *  Iterator<HRegionInfo> itr =
> > table.getRegionLocations().descendingKeySet().iterator();*
> > *        int index = 0;*
> > *        while (itr.hasNext()){*
> > *            splits[index] = itr.next().getStartKey();*
> > *            index++;*
> > *        }*
> >
> >         table.close();
> >
> >         Arrays.sort(splits, Bytes.BYTES_COMPARATOR);
> >         return splits;
> >     }
> >
> >
> > 2014-10-03 20:02 GMT+04:00 Ted Yu <yuzhihong@gmail.com>:
> >
> > > Take a look at this method in HTable:
> > >
> > >   public Pair<byte[][],byte[][]> getStartEndKeys() throws IOException {
> > >
> > > You would see that the first dimension corresponds to the number of
> > > regions.
> > >
> > >
> > > Cheers
> > >
> > > On Fri, Oct 3, 2014 at 8:33 AM, Serega Sheypak <
> serega.sheypak@gmail.com
> > >
> > > wrote:
> > >
> > > > Ok, I found them:
> > > > hTable.getRegionLocations().descendingKeySet()
> > > > and
> > > > HRegionInfo has startKey and endKey
> > > > I have to prepare splits[][].
> > > > I'm confused a little, how keys should be placed there? splits[][]
> > shoud
> > > by
> > > > and array with length=region count and width = 2?
> > > >
> > > >
> > > > 2014-10-03 17:57 GMT+04:00 Serega Sheypak <serega.sheypak@gmail.com
> >:
> > > >
> > > > > Hi, here is my code:
> > > > >
> > > > > public void dropIfExistsAndCreate(String sourceTableName, String
> > > > > newTableName) throws IOException {
> > > > >         LOG.info(String.format("Use [%s] to create [%s]",
> > > > sourceTableName,
> > > > > newTableName));
> > > > >         HTableDescriptor descriptor =
> getDescriptor(sourceTableName);
> > > > >         dropIfExists(newTableName); // doesn't matter
> > > > >         createTable(descriptor, newTableName);
> > > > >     }
> > > > >
> > > > >     private void createTable(HTableDescriptor descriptor, String
> > > > > newTableName) throws IOException {
> > > > >         descriptor.setName(Bytes.toBytes(newTableName));
> > > > >         getAdmin().createTable(descriptor);
> > > > >         LOG.info(String.format("Table created[%s]", newTableName));
> > > > >     }
> > > > >
> > > > > My source table has 256 regions, newly created table has no splits.
> > > > > Is there any possibility to copy splits from source table?
> > > > >
> > > > > I supposed, that HTableDescriptor encasulates splits, but it was
> bad
> > > > > assumption.
> > > > >
> > > >
> > >
> >
>

--089e0158c9645e342c0504873cd2--