Mailing-List: contact user-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@hbase.apache.org
Received-SPF: pass (athena.apache.org: domain of taton@wibidata.com designates
 209.85.219.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1372677275.83181.YahooMailNeo@web140601.mail.bf1.yahoo.com>
References: 
 <CANBXuZA6xmQi6F8rAjQaxA-7y7taMugB8d8R5b=s8W93Qg-BzQ@mail.gmail.com>
	<CALte62yorU5u63bNf=ZJi6KK3-gPkm3YdaWDr1uHcdfu4HgsiA@mail.gmail.com>
	<CANBXuZB8Q-CeqojYxiLxS7w-k9M1pgXKG6Hpn9nLrbTCFsNdnQ@mail.gmail.com>
	<1372677275.83181.YahooMailNeo@web140601.mail.bf1.yahoo.com>
Date: Mon, 1 Jul 2013 10:27:49 -0700
Message-ID: 
 <CANBXuZCE5mEVRnHxyuussr=jjK_kYvuScYGq=h7bg0T3uGNzcA@mail.gmail.com>
Subject: Re: Behavior of Filter.transform() in FilterList?
From: Christophe Taton <taton@wibidata.com>
To: user@hbase.apache.org, lars hofhansl <larsh@apache.org>
Content-Type: multipart/alternative; boundary=089e0115ecf02b4c2704e0768c36

--089e0115ecf02b4c2704e0768c36
Content-Type: text/plain; charset=UTF-8

On Mon, Jul 1, 2013 at 4:14 AM, lars hofhansl <larsh@apache.org> wrote:

> You want transform to only be called on filters that are "reached"?
> I.e. FilterA and FilterB, FilterB.transform should not be called if a KV
> is already filtered by FilterA?
>

Yes, that's what I naively expected, at first.

That's not how it works right now, transform is called in a completely
> different code path from the actual filtering logic.
>

Indeed, I just learned that.
I found no documentation of this behavior, did I miss it?
In particular, the javadoc of the workflow of Filter doesn't mention
transform() at all.
Would it make sense to apply transform() only if the return code for
filterKeyValue() includes the KeyValue?

C.

-- Lars
>
> ----- Original Message -----
> From: Christophe Taton <taton@wibidata.com>
> To: user@hbase.apache.org
> Cc:
> Sent: Sunday, June 30, 2013 10:26 PM
> Subject: Re: Behavior of Filter.transform() in FilterList?
>
> On Sun, Jun 30, 2013 at 10:15 PM, Ted Yu <yuzhihong@gmail.com> wrote:
>
> > The clause 'family=X and column=Y and KeyOnlyFilter' would be represented
> > by a FilterList, right ?
> > (family=A and colymn=B) would be represented by another FilterList.
> >
>
> Yes, that would be FilterList(OR, [FilterList(AND, [family=X, column=Y,
> KeyOnlyFilter]), FilterList(AND, [family=A, column=B])]).
>
> So the behavior is expected.
> >
>
> Could you explain, I'm not sure how you reach this conclusion.
> Are you saying it is expected, given the actual implementation
> FilterList.transform()?
> Or are there some other details I missed?
>
> Thanks!
> C.
>
> On Mon, Jul 1, 2013 at 1:10 PM, Christophe Taton <taton@wibidata.com>
> wrote:
> >
> > > Hi,
> > >
> > > From
> > >
> > >
> >
> https://github.com/apache/hbase/blob/0.95/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java#L183
> > > ,
> > > it appears that Filter.transform() is invoked unconditionally on all
> > > filters in a FilterList hierarchy.
> > >
> > > This is quite confusing, especially since I may construct a filter
> like:
> > >     (family=X and column=Y and KeyOnlyFilter) or (family=A and
> colymn=B)
> > > The KeyOnlyFilter will remove all values from the KeyValues in A:B as
> > well.
> > >
> > > Is my understanding correct? Is this an expected/intended behavior?
> > >
> > > Thanks,
> > > C.
> > >
> >
>
>

--089e0115ecf02b4c2704e0768c36--