Mailing-List: contact hbase-user-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-user@hadoop.apache.org
Received-SPF: pass (nike.apache.org: domain of angushe@gmail.com designates
 74.125.92.26 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=MtonRy5fxoJgazxM3mivJQJLrjPArJ7nPpi++CLBx5qST4c7b7Iq25dRbGN9n+Jwfa
         1PoLGH2z2BXscZKMMnNGAUV/wf3zDqWEVr4Q73PM2nL1MifMrW/wOzLlP6zKidPlId3K
         tAc0SePhSw9m8f6zTmJPkePLkolxnmTQ07kzQ=
MIME-Version: 1.0
Date: Tue, 4 Aug 2009 14:00:50 +0800
Message-ID: <9b27a8a60908032300lf9fcfc2kd16c33c5388ee370@mail.gmail.com>
Subject: HBase 0.20.0rc not close the connection to zookeeper explicitly when
	closing HTable (and HBaseAdmin)
From: Angus He <angushe@gmail.com>
To: hbase-user@hadoop.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi All,

In HBase 0.20rc, HTable does not explicitly close the connection to
zookeeper in HTable::close.
It probably could be better.  And in my opinion, it should be for:

1. It is not well-behaved, although zookeeper is able to detect the
lost connection after issuing networking I/O operation, .
2. It is easy to get zookeeper server stuck with exceptions like "Too
many connections from /0:0:0:0:0     :0:0:1 - max is 30", when user
write codes like:
			for (int i = 0; i < 1024; ++i) {
				HTable table = new HTable("foobar");
				table.close();
			}

In the current implementation, different HTable instances share the
same connection to zookeeper if they have same HBaseConfiguration
instance. For this, we cannot close the connection directly in HTable,
but probably we could implement HConnection class with
reference-counting ability.

Any comments?

-- 
Regards
Angus