hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-24517) AssignmentManager.start should add meta region to ServerStateNode
Date Tue, 09 Jun 2020 14:16:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-24517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129327#comment-17129327
] 

Hudson commented on HBASE-24517:
--------------------------------

Results for branch master
	[build #1752 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1752/]:
(/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1752/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1752/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1752/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> AssignmentManager.start should add meta region to ServerStateNode
> -----------------------------------------------------------------
>
>                 Key: HBASE-24517
>                 URL: https://issues.apache.org/jira/browse/HBASE-24517
>             Project: HBase
>          Issue Type: Bug
>          Components: amv2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Critical
>             Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6
>
>
> In AssignmentManager.start, we will load the meta region state and location from zk and
create the RegionStateNode, but we forget to call regionStates.addRegionToServer to add the
region to the region server.
> Found this when implementing HBASE-24390. As in HBASE-24390, we will remove RegionInfoBuilder.FIRST_META_REGIONINFO
so in SCP, we need to use the getRegionsOnServer instead of RegionInfoBuilder.FIRST_META_REGIONINFO
when assigning meta, so the bug becomes a real problem.
> Though it is not a big problem for SCP for current 2.x and master branches, it is a high
risky bug. For example, in AssignmentManager.submitServerCrash, now we use the RegionStateNode
of meta regions to determine whether the given region server carries meta regions. But it
is also valid to test through the ServerStateNode's region list. If later we change this method
to use ServerStateNode, it will cause very serious data loss bug.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message