hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [hbase] virajjasani commented on a change in pull request #754: HBASE-22978 : Online slow response log
Date Tue, 28 Jan 2020 07:10:15 GMT
virajjasani commented on a change in pull request #754: HBASE-22978 : Online slow response
log
URL: https://github.com/apache/hbase/pull/754#discussion_r371620037
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
 ##########
 @@ -215,6 +224,17 @@
    */
   private RSRpcServices rsRpcServices;
 
+
+  /**
+   * Use to add online slowlog responses
+   */
+  private OnlineSlowLogProvider onlineSlowLogProvider;
 
 Review comment:
   If we make, we add up in constructor arg which I don't think we should do, so better have
setter method and let it be non-final please? :(

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message