hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (Jira)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-23196) The IndexChunkPool’s percentage is hard code to 0.1
Date Wed, 23 Oct 2019 04:40:00 GMT

    [ https://issues.apache.org/jira/browse/HBASE-23196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957546#comment-16957546
] 

Anoop Sam John commented on HBASE-23196:
----------------------------------------

Ya its a 10% waste in all the cases.  This issue is there in 2.0+ versions right?  Nice catch.
 Ya when its not COmpactingMS or not CHUNK_MAP index type this can be 0%.  Will work on a
patch?

> The IndexChunkPool’s percentage is hard code to 0.1
> ---------------------------------------------------
>
>                 Key: HBASE-23196
>                 URL: https://issues.apache.org/jira/browse/HBASE-23196
>             Project: HBase
>          Issue Type: Bug
>            Reporter: chenxu
>            Priority: Major
>
> Code in ChunkCreator#initialize
> {code:java}
> public static ChunkCreator initialize(...) {
>     if (instance != null) {
>       return instance;
>     }
>     instance = new ChunkCreator(chunkSize, offheap, globalMemStoreSize, poolSizePercentage,
>             initialCountPercentage, heapMemoryManager,
>             MemStoreLABImpl.INDEX_CHUNK_PERCENTAGE_DEFAULT);
>     return instance;
>   }
> {code}
> When mslab is enabled, the IndexChunkPool’s percentage is hard code to INDEX_CHUNK_PERCENTAGE_DEFAULT,
When we use IndexType#ARRAY_MAP other than IndexType#CHUNK_MAP, we should set IndexChunkPool’s
size to 0, or there will be a waste of memory space.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message